evm: Add SharedWormholeTransceiver

Author: bruce-riley

evm/NOTES.md

@@ -1,9 +1,25 @@
 # Notes on changes made in this integration branch
 
-## Change that wasn't made
+This file is meant to document the work in progress on this integration branch. It can probably be deleted (or the information moved some place better) before this PR is merged.
+
+This integration branch is PR #21.
+
+## Sub Branches
+
+Note that the indentation indicates branch dependencies.
+
+- **evm_TransceiverRegistry_split** (PR #22) - This branch splits transceiver admin into a separate contract.
+- **evm/add_MsgManager** (PR #23) - Creates `MsgManagerBase` and `MsgManager` and makes `NttManager` inherit from `MsgManagerBase`.
+  - **evm/add_SharedWormholeTransceiver** (PR #25) - Adds a shareable transceiver.
+
+## The change that wasn't made
 
 It is unfortunate that `token` and `mode` exist in `ManagerBase` rather than `NttManager`.
-I tried moving them, but that increases
+I tried moving them, but that increases the size of `NttManagerNoRateLimiting` considerably.
+I'm not sure why that is, or how to avoid it, so I did not pursue that change at this time.
+However, some of the other changes also cause that increase, so maybe we can revist this.
+
+## Contract Sizes
 
 ### Before we started
 
@@ -21,7 +37,7 @@ evm (main)$ forge build --sizes --via-ir --skip test
 
 ```
 
-### After moving token and mode
+### After moving token and mode (the change that wasn't made)
 
 ```bash
 evm (main)$ forge build --sizes --via-ir --skip test
@@ -34,28 +50,8 @@ evm (main)$ forge build --sizes --via-ir --skip test
 
 ```
 
-Question: Why did `NttManagerNoRateLimiting` grow so much?? Because of this, I am not pursuing moving these fields at this time.
-
 ## Creating TransceiverRegistryAdmin
 
-### Before
-
-```bash
-evm (main)$ forge build --sizes --via-ir --skip test
-
-╭-----------------------------------------+------------------+-------------------+--------------------+---------------------╮
-| Contract                                | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
-+===========================================================================================================================+
-|-----------------------------------------+------------------+-------------------+--------------------+---------------------|
-| NttManager                              | 24,066           | 25,673            | 510                | 23,479              |
-|-----------------------------------------+------------------+-------------------+--------------------+---------------------|
-| NttManagerNoRateLimiting                | 17,141           | 18,557            | 7,435              | 30,595              |
-|-----------------------------------------+------------------+-------------------+--------------------+---------------------|
-
-```
-
-### After
-
 ```bash
 evm (main)$ forge build --sizes --via-ir --skip test
 
@@ -69,26 +65,6 @@ evm (main)$ forge build --sizes --via-ir --skip test
 
 ## Creating MsgManagerBase
 
-Note that this change is not dependent on `TransceiverRegistryAdmin`.
-
-### Before
-
-```bash
-evm (main)$ forge build --sizes --via-ir --skip test
-
-╭-----------------------------------------+------------------+-------------------+--------------------+---------------------╮
-| Contract                                | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
-+===========================================================================================================================+
-|-----------------------------------------+------------------+-------------------+--------------------+---------------------|
-| NttManager                              | 24,066           | 25,673            | 510                | 23,479              |
-|-----------------------------------------+------------------+-------------------+--------------------+---------------------|
-| NttManagerNoRateLimiting                | 17,141           | 18,557            | 7,435              | 30,595              |
-|-----------------------------------------+------------------+-------------------+--------------------+---------------------|
-
-```
-
-### After
-
 ```bash
 evm (main)$ forge build --sizes --via-ir --skip test