evm: Per-chain thresholds

Author: bruce-riley

evm/script/helpers/DeployWormholeNttBase.sol

@@ -100,7 +100,8 @@ contract DeployWormholeNttBase is ParseNttConfig {
         }
 
         // Hardcoded to one since these scripts handle Wormhole-only deployments.
-        INttManager(nttManager).setThreshold(1);
+        // TODO: We need the sourceChainId to set the threshold. Also need to enable sending and receiving.
+        // INttManager(nttManager).setThreshold(1);
         console2.log("Threshold set on NttManager: %d", uint256(1));
     }
 

evm/src/NttManager/ManagerBase.sol

@@ -166,7 +166,7 @@ abstract contract ManagerBase is
     ) internal returns (bytes32, bool) {
         bytes32 digest = TransceiverStructs.nttManagerMessageDigest(sourceChainId, message);
 
-        if (!isMessageApproved(digest)) {
+        if (!isMessageApproved(sourceChainId, digest)) {
             revert MessageNotApproved(digest);
         }
 
@@ -284,15 +284,16 @@ abstract contract ManagerBase is
     }
 
     /// @inheritdoc IManagerBase
-    function getThreshold() public view returns (uint8) {
-        return _getThresholdStorage().num;
+    /// @dev This is here because it is defined in IManagerBase.
+    function getThreshold(
+        uint16 sourceChainId
+    ) public view returns (uint8) {
+        return _getPerChainRecvTransceiverDataStorage()[sourceChainId].threshold;
     }
 
     /// @inheritdoc IManagerBase
-    function isMessageApproved(
-        bytes32 digest
-    ) public view returns (bool) {
-        uint8 threshold = getThreshold();
+    function isMessageApproved(uint16 sourceChainId, bytes32 digest) public view returns (bool) {
+        uint8 threshold = getThreshold(sourceChainId);
         return messageAttestations(digest) >= threshold && threshold > 0;
     }
 
@@ -401,20 +402,9 @@ abstract contract ManagerBase is
     }
 
     /// @inheritdoc IManagerBase
-    function setThreshold(
-        uint8 threshold
-    ) external onlyOwner {
-        if (threshold == 0) {
-            revert ZeroThreshold();
-        }
-
-        _Threshold storage _threshold = _getThresholdStorage();
-        uint8 oldThreshold = _threshold.num;
-
-        _threshold.num = threshold;
-        _checkThresholdInvariants();
-
-        emit ThresholdChanged(oldThreshold, threshold);
+    /// @dev This is here because it is defined in IManagerBase.
+    function setThreshold(uint16 sourceChainId, uint8 threshold) external onlyOwner {
+        _setThreshold(sourceChainId, threshold);
     }
 
     // =============== Internal ==============================================================
@@ -484,20 +474,4 @@ abstract contract ManagerBase is
             );
         }
     }
-
-    function _checkThresholdInvariants() internal view {
-        uint8 threshold = _getThresholdStorage().num;
-        _NumTransceivers memory numTransceivers = _getNumTransceiversStorage();
-
-        // invariant: threshold <= enabledTransceivers.length
-        if (threshold > numTransceivers.enabled) {
-            revert ThresholdTooHigh(threshold, numTransceivers.enabled);
-        }
-
-        if (numTransceivers.registered > 0) {
-            if (threshold == 0) {
-                revert ZeroThreshold();
-            }
-        }
-    }
 }

evm/src/NttManager/NttManager.sol

@@ -192,7 +192,7 @@ contract NttManager is INttManager, RateLimiter, ManagerBase {
         // Compute manager message digest and record transceiver attestation.
         bytes32 nttManagerMessageHash = _recordTransceiverAttestation(sourceChainId, payload);
 
-        if (isMessageApproved(nttManagerMessageHash)) {
+        if (isMessageApproved(sourceChainId, nttManagerMessageHash)) {
             executeMsg(sourceChainId, sourceNttManagerAddress, payload);
         }
     }