svm/wormhole-core-shims: support non-solana SVM deployments (wormhole-foundation#4527)

* svm/definitions: use const computation to derive static PDAs

This allows us to only have to specify the program id

* svm/definitions: add feature flag to pick up addresses from env

* svm/definitions: fix path in test

* svm/definitions: error when 'solana' and 'from-env' are both passed

* svm/definitions: small formatting

* svm/definitions: fix *correct* spelling to make spellcheck happy

* svm/definitions: remove bs58 validation

https://docs.rs/const-crypto/latest/src/const_crypto/bs58.rs.html#8-15
already handles this

* svm/definitions: std-finality -> standard-finality

* svm/definitions: mention commitment level in docs

Author: kcsongor

svm/wormhole-core-shims/Cargo.lock

@@ -12,21 +12,26 @@ version.workspace = true
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [features]
-default = []
+default = [ "standard-finality" ]
 borsh = ["dep:borsh"]
 
 ### Network types
 testnet = []
 localnet = []
+from-env = []
+
+### Standard finality definition
+standard-finality = []
 
 ### Specific networks
-solana = []
+solana = [ "standard-finality" ]
 
 [dependencies]
+const-crypto = "0.3.0"
 borsh = { optional = true, workspace = true }
 cfg-if.workspace = true
 sha2-const-stable.workspace = true
 solana-program.workspace = true
 
 [dev-dependencies]
-base64.workspace = true
+base64.workspace = true

svm/wormhole-core-shims/anchor/Cargo.lock

@@ -4,31 +4,36 @@ Definitions relating to Wormhole SVM programs. These definitions include finding
 PDA addresses (and corresponding bump seeds), various consts (like program IDs),
 and other things that define these program accounts and data.
 
-## Cargo Features
-
-There are features that define network types and specific SVM networks.
-
-### Network Types
-
-The default network type is mainnet. There is no feature that defines mainnet.
-But if one of the following features are defined, program IDs and account
-addresses will not use the ones defined for mainnet.
-
-- `localnet`: Wormhole's Tilt devnet. Programs like the Wormhole Core Bridge and
-  its associated PDAs have addresses specific to this local development network.
-- `testnet`: Public devnet or testnet depending on the specific SVM network. For
-  Solana specifically, this feature corresponds to the public Solana devnet.
-
-### Specific Networks
-
-There are no default network features. These feature labels also exist as
-submodules in this crate. By defining a particular SVM network feature, the
-definitions found in this submodule are simply exported into the crate root.
-
-- `solana`
+The crate is parameterized over a set of program IDs (the Wormhole program, the
+post-vaa shim program, and the verify-vaa shim program). Since this crate may be
+used in many different scenarios, and many different SVM networks, we expose
+feature flags to control which program IDs are used to derive the other constants.
+
+For Solana, we have a hardcoded set of addresses for `mainnet`, `devnet` and a
+local testing environment. If the `solana` feature is specified, it will default
+to the mainnet addresses. Otherwise, the `testnet` flag provides the addresses
+for Solana Devnet, and the `localnet` flag provides the addresses for the local
+testing environment.
+
+Alternatively, when using on another SVM chain (or on Solana, but against an
+independent Wormhole deployment) just specify the `from-env` feature flag (and
+don't specify Solana, even if the chain is Solana). In this case, the following
+4 environment variables are needed:
+- `CHAIN_ID`: the Wormhole ID of the chain deployed on. e.g. Solana is 1, Fogo is 51.
+- `BRIDGE_ADDRESS`: program ID of the Wormhole program
+- `POST_MESSAGE_SHIM_PROGRAM_ID`: program ID of the [../../programs/post-message/](post-message shim).
+- `VERIFY_VAA_SHIM_PROGRAM_ID`: program ID of the [../../programs/verify-vaa](verify-vaa shim).
+
+The definitions crate can be compiled without either the `solana` or the
+`from-env` feature flags. In this case, it will not expose any addresses in the top-level crate, for example `crate::CORE_BRIDGE_FEE_COLLECTOR` won't be available. However, the predefined Solana addresses are still available via their qualified paths:
+e.g. `crate::solana::devnet::CORE_BRIDGE_FEE_COLLECTOR`.
+
+A crate wishing to build on top of this crate should pass through the
+`from-env`, `solana`, `testnet`, and `devnet` flags, but may wish to specify
+`from-env` as the default.
 
 ### Other Features
 
 - `borsh`: Accounts and events relating to Wormhole SVM programs that follow
   Borsh serialization. This feature also supports deserializing data with
-  discriminators.
+  discriminators.

svm/wormhole-core-shims/crates/definitions/Cargo.toml

@@ -0,0 +1,6 @@
+#[macro_export]
+macro_rules! env_pubkey {
+    ($name: literal) => {
+        const_crypto::bs58::decode_pubkey(env!($name))
+    };
+}