Remove regex dependency #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

dbanty wants to merge 1 commit into wot-rust:master from dbanty:master

dbanty commented May 10, 2025

regex is quite a heavy dependency, and this crate is the only reason my project needs to pull it in.

This PR removes the dependency by using std Rust code instead. This also speeds up percent encoding quite a bit (when benchmarking an existing test):

old: bench_literal_expansion: 10,046.55 ns/iter (+/- 477.77)
new: bench_literal_expansion: 85.61 ns/iter (+/- 3.48)


          Remove regex dependency

039ac0f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet