Skip to content

Commit afc4e2c

Browse files
authored
Upgrade to L12 (#22)
* Upgrade to L12 --------- Co-authored-by: jyrkidn <2447042+jyrkidn@users.noreply.github.com>
1 parent c636609 commit afc4e2c

File tree

5 files changed

+36
-28
lines changed

5 files changed

+36
-28
lines changed

.github/workflows/phpstan.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
- name: Setup PHP
1717
uses: shivammathur/setup-php@v2
1818
with:
19-
php-version: "8.2"
19+
php-version: "8.4"
2020
coverage: none
2121

2222
- name: Install composer dependencies

.github/workflows/run-tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ jobs:
1313
fail-fast: true
1414
matrix:
1515
os: [ubuntu-latest, windows-latest]
16-
php: [8.2, 8.3]
17-
laravel: [10.*, 11.*]
16+
php: [8.2, 8.3, 8.4]
17+
laravel: [10.*, 11.*, 12.*]
1818
stability: [prefer-stable]
1919

2020
name: P${{ matrix.php }} - L${{ matrix.laravel }} - ${{ matrix.stability }} - ${{ matrix.os }}

composer.json

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -9,24 +9,24 @@
99
"homepage": "https://github.com/codedor/filament-seo",
1010
"license": "MIT",
1111
"require": {
12-
"php": "^8.2|^8.3",
13-
"codedor/filament-media-library": "^2.0",
14-
"codedor/filament-translatable-tabs": "^1.0",
15-
"codedor/laravel-locale-collection": "^1.0",
16-
"illuminate/contracts": "^10.0|^11.0",
12+
"php": "^8.2",
13+
"codedor/filament-media-library": "^2.1|^3.0",
14+
"codedor/filament-translatable-tabs": "^1.3",
15+
"codedor/laravel-locale-collection": "^1.2",
16+
"illuminate/contracts": "^10.0|^11.0|^12.0",
1717
"spatie/laravel-package-tools": "^1.12",
1818
"spatie/laravel-translatable": "^6.5"
1919
},
2020
"require-dev": {
2121
"laravel/pint": "^1.0",
2222
"nunomaduro/collision": "^7.0|^8.0",
23-
"larastan/larastan": "^2.0",
24-
"orchestra/testbench": "^8.0|^9.0",
25-
"pestphp/pest": "^2.0",
26-
"pestphp/pest-plugin-laravel": "^2.0",
27-
"phpstan/extension-installer": "^1.1",
28-
"phpstan/phpstan-deprecation-rules": "^1.0",
29-
"phpstan/phpstan-phpunit": "^1.0"
23+
"larastan/larastan": "^2.0|^3.0",
24+
"orchestra/testbench": "^8.0|^9.0|^10.0",
25+
"pestphp/pest": "^2.0|^3.0",
26+
"pestphp/pest-plugin-laravel": "^2.0|^3.0",
27+
"phpstan/extension-installer": "^1.1|^2.0",
28+
"phpstan/phpstan-deprecation-rules": "^1.0|^2.0",
29+
"phpstan/phpstan-phpunit": "^1.0|^2.0"
3030
},
3131
"autoload": {
3232
"psr-4": {

phpstan-baseline.neon

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,14 @@
11
parameters:
2-
ignoreErrors:
3-
-
4-
message: "#^Call to an undefined method Illuminate\\\\Database\\\\Eloquent\\\\Model\\:\\:fillSeoFieldState\\(\\)\\.$#"
5-
count: 1
6-
path: src/Filament/SeoCard.php
2+
ignoreErrors:
3+
-
4+
message: "#^Call to an undefined method Illuminate\\\\Database\\\\Eloquent\\\\Model\\:\\:fillSeoFieldState\\(\\)\\.$#"
5+
count: 1
6+
path: src/Filament/SeoCard.php
7+
-
8+
identifier: trait.unused
9+
count: 1
10+
path: src/Filament/Traits/SavesSeoFields.php
11+
-
12+
identifier: trait.unused
13+
count: 1
14+
path: src/Models/Traits/HasSeoFields.php

tests/Feature/Models/Traits/HasSeoFieldsTest.php

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -59,13 +59,13 @@
5959
$this->assertDatabaseHas(SeoField::class, [
6060
'type' => BaseTag::class,
6161
'name' => 'title',
62-
'content' => 'new title',
62+
'content' => json_encode('new title'),
6363
]);
6464

6565
$this->assertDatabaseHas(SeoField::class, [
6666
'type' => BaseTag::class,
6767
'name' => 'description',
68-
'content' => 'new description',
68+
'content' => json_encode('new description'),
6969
]);
7070
});
7171

@@ -78,13 +78,13 @@
7878
$this->assertDatabaseHas(SeoField::class, [
7979
'type' => BaseTag::class,
8080
'name' => 'title',
81-
'content' => 'seo title',
81+
'content' => json_encode('seo title'),
8282
]);
8383

8484
$this->assertDatabaseHas(SeoField::class, [
8585
'type' => BaseTag::class,
8686
'name' => 'description',
87-
'content' => 'new description',
87+
'content' => json_encode('new description'),
8888
]);
8989
});
9090

@@ -96,14 +96,14 @@
9696
$this->assertDatabaseHas(SeoField::class, [
9797
'type' => BaseTag::class,
9898
'name' => 'title',
99-
'content' => 'title',
99+
'content' => json_encode('title'),
100100
]);
101101
});
102102

103103
it('can init the seo', function () {
104104
$page = Page::create([
105105
'title' => 'Title',
106-
'description' => 'Description',
106+
'description' => json_encode('Description'),
107107
]);
108108

109109
// 2 from beforeEach
@@ -118,14 +118,14 @@
118118
'model_id' => $page->id,
119119
'type' => BaseTag::class,
120120
'name' => 'title',
121-
'content' => 'Title',
121+
'content' => json_encode('Title'),
122122
]);
123123

124124
$this->assertDatabaseHas(SeoField::class, [
125125
'model_type' => Page::class,
126126
'model_id' => $page->id,
127127
'type' => BaseTag::class,
128128
'name' => 'description',
129-
'content' => '',
129+
'content' => json_encode(''),
130130
]);
131131
});

0 commit comments

Comments
 (0)