Skip to content

TrustedDeviceCondition does not work without configuration #10

@galimru

Description

@galimru

First of all, let me say you did a great work, thank you for that extension!

I think I found a small bug for condition TrustedDeviceCondition when it's added without setting up alias and configuration.
Despite UI shows Negate toggle is enabled by default, the whole configuration is null.
So without it, condition returns always false which skips whole 2FA subflow.

if (authConfig != null && authConfig.getConfig() != null) {
boolean negateOutput = Boolean.parseBoolean(
authConfig.getConfig().get(TrustedDeviceConditionFactory.CONF_NEGATE));
return negateOutput != trustedDevice;
}
return false;

In fact, I don't understand what is purpose of this toggle.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions