-
Notifications
You must be signed in to change notification settings - Fork 16
Open
Description
First of all, let me say you did a great work, thank you for that extension!
I think I found a small bug for condition TrustedDeviceCondition when it's added without setting up alias and configuration.
Despite UI shows Negate toggle is enabled by default, the whole configuration is null.
So without it, condition returns always false which skips whole 2FA subflow.
Lines 27 to 34 in 05cb4d8
| if (authConfig != null && authConfig.getConfig() != null) { | |
| boolean negateOutput = Boolean.parseBoolean( | |
| authConfig.getConfig().get(TrustedDeviceConditionFactory.CONF_NEGATE)); | |
| return negateOutput != trustedDevice; | |
| } | |
| return false; |
In fact, I don't understand what is purpose of this toggle.
Metadata
Metadata
Assignees
Labels
No labels