minor symfony#37910 [Filesystem] fix test on PHP 8 (xabbuh)

fabpot · fabpot · commit 12706c4ff0c8 · 2020-08-21T15:37:43.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [Filesystem] fix test on PHP 8 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Commits ------- c081789 [Filesystem] fix test on PHP 8
diff --git a/src/Symfony/Component/Filesystem/Filesystem.php b/src/Symfony/Component/Filesystem/Filesystem.php
@@ -198,7 +198,7 @@ public function remove($files)
     public function chmod($files, $mode, $umask = 0000, $recursive = false)
     {
         foreach ($this->toIterable($files) as $file) {
-            if (true !== @chmod($file, $mode & ~$umask)) {
+            if ((\PHP_VERSION_ID < 80000 || \is_int($mode)) && true !== @chmod($file, $mode & ~$umask)) {
                 throw new IOException(sprintf('Failed to chmod file "%s".', $file), 0, null, $file);
             }
             if ($recursive && is_dir($file) && !is_link($file)) {

Original file line number	Diff line number	Diff line change
`@@ -198,7 +198,7 @@ public function remove($files)`
`198`	`198`	`public function chmod($files, $mode, $umask = 0000, $recursive = false)`
`199`	`199`	`{`
`200`	`200`	`foreach ($this->toIterable($files) as $file) {`
`201`		`- if (true !== @chmod($file, $mode & ~$umask)) {`
	`201`	`+ if ((\PHP_VERSION_ID < 80000 \|\| \is_int($mode)) && true !== @chmod($file, $mode & ~$umask)) {`
`202`	`202`	`throw new IOException(sprintf('Failed to chmod file "%s".', $file), 0, null, $file);`
`203`	`203`	`}`
`204`	`204`	`if ($recursive && is_dir($file) && !is_link($file)) {`