bug symfony#38528 [Security] Making login link signature_properties option required (weaverryan)

This PR was merged into the 5.x branch.

Discussion
----------

[Security] Making login link signature_properties option required

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | yes (for a 5.2 feature)
| New feature?  | no
| Deprecations? | no
| Tickets       | none
| License       | MIT
| Doc PR        | not needed

Hi!

My intention was always to force the user to set this option. Before this PR, you can simply leave this option off completely without a validation error. Thanks to Wouter for finding it.

Also: made some punctuation & capitalization consistent on info messages.

Cheers!

Commits
-------

f7bb954 Making login link signature_properties option required

Author: fabpot

src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/LoginLinkFactory.php

@@ -36,33 +36,34 @@ public function addConfiguration(NodeDefinition $node)
         $builder
             ->scalarNode('check_route')
                 ->isRequired()
-                ->info('Route that will validate the login link - e.g. app_login_link_verify')
+                ->info('Route that will validate the login link - e.g. app_login_link_verify.')
             ->end()
             ->arrayNode('signature_properties')
+                ->isRequired()
                 ->prototype('scalar')->end()
                 ->requiresAtLeastOneElement()
-                ->info('An array of properties on your User that are used to sign the link. If any of these change, all existing links will become invalid')
+                ->info('An array of properties on your User that are used to sign the link. If any of these change, all existing links will become invalid.')
                 ->example(['email', 'password'])
             ->end()
             ->integerNode('lifetime')
                 ->defaultValue(600)
-                ->info('The lifetime of the login link in seconds')
+                ->info('The lifetime of the login link in seconds.')
             ->end()
             ->integerNode('max_uses')
                 ->defaultNull()
                 ->info('Max number of times a login link can be used - null means unlimited within lifetime.')
             ->end()
             ->scalarNode('used_link_cache')
-                ->info('Cache service id used to expired links of max_uses is set')
+                ->info('Cache service id used to expired links of max_uses is set.')
             ->end()
             ->scalarNode('success_handler')
-                ->info(sprintf('A service id that implements %s', AuthenticationSuccessHandlerInterface::class))
+                ->info(sprintf('A service id that implements %s.', AuthenticationSuccessHandlerInterface::class))
             ->end()
             ->scalarNode('failure_handler')
-                ->info(sprintf('A service id that implements %s', AuthenticationFailureHandlerInterface::class))
+                ->info(sprintf('A service id that implements %s.', AuthenticationFailureHandlerInterface::class))
             ->end()
             ->scalarNode('provider')
-                ->info('the user provider to load users from.')
+                ->info('The user provider to load users from.')
             ->end()
         ;