bug symfony#38390 [Serializer][Minor] Fix circular reference exception message (bad limit displayed) (l-vo)

This PR was merged into the 4.4 branch.

Discussion
----------

[Serializer][Minor] Fix circular reference exception message (bad limit displayed)

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

36ce902 [Serializer][Minor] Fix exception message

Author: fabpot

src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php

@@ -327,7 +327,7 @@ protected function handleCircularReference($object/*, string $format = null, arr
             return $circularReferenceHandler($object, $format, $context);
         }
 
-        throw new CircularReferenceException(sprintf('A circular reference has been detected when serializing the object of class "%s" (configured limit: %d).', \get_class($object), $this->circularReferenceLimit));
+        throw new CircularReferenceException(sprintf('A circular reference has been detected when serializing the object of class "%s" (configured limit: %d).', \get_class($object), $context[self::CIRCULAR_REFERENCE_LIMIT] ?? $this->defaultContext[self::CIRCULAR_REFERENCE_LIMIT] ?? $this->circularReferenceLimit));
     }
 
     /**

src/Symfony/Component/Serializer/Tests/Normalizer/Features/CircularReferenceTestTrait.php

@@ -10,23 +10,36 @@
  */
 trait CircularReferenceTestTrait
 {
-    abstract protected function getNormalizerForCircularReference(): NormalizerInterface;
+    abstract protected function getNormalizerForCircularReference(array $defaultContext): NormalizerInterface;
 
     abstract protected function getSelfReferencingModel();
 
-    public function testUnableToNormalizeCircularReference()
+    public function provideUnableToNormalizeCircularReference(): array
     {
-        $normalizer = $this->getNormalizerForCircularReference();
+        return [
+            [[], [], 1],
+            [['circular_reference_limit' => 2], [], 2],
+            [['circular_reference_limit' => 2], ['circular_reference_limit' => 3], 3],
+        ];
+    }
+
+    /**
+     * @dataProvider provideUnableToNormalizeCircularReference
+     */
+    public function testUnableToNormalizeCircularReference(array $defaultContext, array $context, int $expectedLimit)
+    {
+        $normalizer = $this->getNormalizerForCircularReference($defaultContext);
 
         $obj = $this->getSelfReferencingModel();
 
         $this->expectException(CircularReferenceException::class);
-        $normalizer->normalize($obj, null, ['circular_reference_limit' => 2]);
+        $this->expectExceptionMessage(sprintf('A circular reference has been detected when serializing the object of class "%s" (configured limit: %d).', \get_class($obj), $expectedLimit));
+        $normalizer->normalize($obj, null, $context);
     }
 
     public function testCircularReferenceHandler()
     {
-        $normalizer = $this->getNormalizerForCircularReference();
+        $normalizer = $this->getNormalizerForCircularReference([]);
 
         $obj = $this->getSelfReferencingModel();
         $expected = ['me' => \get_class($obj)];

src/Symfony/Component/Serializer/Tests/Normalizer/GetSetMethodNormalizerTest.php

@@ -247,10 +247,10 @@ public function testLegacyCallbacks($callbacks, $value, $result)
         );
     }
 
-    protected function getNormalizerForCircularReference(): GetSetMethodNormalizer
+    protected function getNormalizerForCircularReference(array $defaultContext): GetSetMethodNormalizer
     {
         $classMetadataFactory = new ClassMetadataFactory(new AnnotationLoader(new AnnotationReader()));
-        $normalizer = new GetSetMethodNormalizer($classMetadataFactory, new MetadataAwareNameConverter($classMetadataFactory));
+        $normalizer = new GetSetMethodNormalizer($classMetadataFactory, new MetadataAwareNameConverter($classMetadataFactory), null, null, null, $defaultContext);
         new Serializer([$normalizer]);
 
         return $normalizer;

src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php

@@ -365,9 +365,9 @@ public function testLegacyUncallableCallbacks($callbacks)
 
     // circular reference
 
-    protected function getNormalizerForCircularReference(): ObjectNormalizer
+    protected function getNormalizerForCircularReference(array $defaultContext): ObjectNormalizer
     {
-        $normalizer = new ObjectNormalizer();
+        $normalizer = new ObjectNormalizer(null, null, null, null, null, null, $defaultContext);
         new Serializer([$normalizer]);
 
         return $normalizer;

src/Symfony/Component/Serializer/Tests/Normalizer/PropertyNormalizerTest.php

@@ -191,9 +191,9 @@ public function testLegacyUncallableCallbacks($callbacks)
         $this->normalizer->setCallbacks($callbacks);
     }
 
-    protected function getNormalizerForCircularReference(): PropertyNormalizer
+    protected function getNormalizerForCircularReference(array $defaultContext): PropertyNormalizer
     {
-        $normalizer = new PropertyNormalizer();
+        $normalizer = new PropertyNormalizer(null, null, null, null, null, $defaultContext);
         new Serializer([$normalizer]);
 
         return $normalizer;