bug symfony#38385 [PropertyInfo] Fix failure over array<string,mixed> PhpDoc type (romaricdrigon)

This PR was merged into the 5.2-dev branch.

Discussion
----------

[PropertyInfo] Fix failure over array<string,mixed> PhpDoc type

| Q             | A
| ------------- | ---
| Branch?       | master (issue introduced in master)
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | /
| License       | MIT
| Doc PR        | /

**Background**

Since a few days ago ([this commit](symfony@80e5a7f)), PropertyInfo 5.2 component supports array PhpDoc types, such as `array<string,string>`.
While testing SF 5.2 over my project, it was failing over:
```php
class SomeDoctrineEntityProxy implements \Doctrine\ORM\Proxy\Proxy
{
    /**
     * @var array<string, mixed> default values of properties to be lazy loaded, with keys being the property names
     *
     * @see \Doctrine\Common\Proxy\Proxy::__getLazyProperties
     */
    public static $lazyPropertiesDefaults = array();
}
```

Upon investigation, it appears `array<string,mixed>` is causing the issue: `mixed` type is not handled.

**Expected behavior**

PropertyInfo component should not guess anything for `mixed` type (return `NULL`), but it should not throw any exception.

**Comment about my fix**

I added a test case (`arrayOfMixed`) you can use to reproduce the issue.
Since array PhpDoc types were not tested at all, I also added a test case over `array<string,string>`.

Commits
-------

590177f [PropertyInfo] Fix failure over array<string,mixed> PhpDoc type

Author: fabpot

src/Symfony/Component/PropertyInfo/Tests/Extractor/PhpDocExtractorTest.php

@@ -117,6 +117,22 @@ public function typesProvider()
             ['staticGetter', null, null, null],
             ['staticSetter', null, null, null],
             ['emptyVar', null, $this->isPhpDocumentorV5() ? 'This should not be removed.' : null, null],
+            [
+                'arrayWithKeys',
+                $this->isPhpDocumentorV5() ? [
+                    new Type(Type::BUILTIN_TYPE_ARRAY, false, null, true, new Type(Type::BUILTIN_TYPE_STRING), new Type(Type::BUILTIN_TYPE_STRING)),
+                ] : null,
+                null,
+                null,
+            ],
+            [
+                'arrayOfMixed',
+                $this->isPhpDocumentorV5() ? [
+                    new Type(Type::BUILTIN_TYPE_ARRAY, false, null, true, new Type(Type::BUILTIN_TYPE_STRING), null),
+                ] : null,
+                null,
+                null,
+            ],
         ];
     }
 

src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php

@@ -65,6 +65,7 @@ public function testGetProperties()
                 'nestedIterators',
                 'arrayWithKeys',
                 'arrayWithKeysAndComplexValue',
+                'arrayOfMixed',
                 'foo',
                 'foo2',
                 'foo3',
@@ -115,6 +116,7 @@ public function testGetPropertiesWithCustomPrefixes()
                 'nestedIterators',
                 'arrayWithKeys',
                 'arrayWithKeysAndComplexValue',
+                'arrayOfMixed',
                 'foo',
                 'foo2',
                 'foo3',
@@ -155,6 +157,7 @@ public function testGetPropertiesWithNoPrefixes()
                 'nestedIterators',
                 'arrayWithKeys',
                 'arrayWithKeysAndComplexValue',
+                'arrayOfMixed',
                 'foo',
                 'foo2',
                 'foo3',

src/Symfony/Component/PropertyInfo/Tests/Fixtures/Dummy.php

@@ -140,6 +140,11 @@ class Dummy extends ParentDummy
      */
     public $arrayWithKeysAndComplexValue;
 
+    /**
+     * @var array<string,mixed>
+     */
+    public $arrayOfMixed;
+
     public static function getStatic()
     {
     }

src/Symfony/Component/PropertyInfo/Util/PhpDocTypeHelper.php

@@ -122,7 +122,7 @@ private function createType(DocType $type, bool $nullable, string $docType = nul
             $collectionKeyType = $this->getTypes($type->getKeyType())[0];
 
             $collectionValueTypes = $this->getTypes($type->getValueType());
-            if (\count($collectionValueTypes) > 1) {
+            if (0 === \count($collectionValueTypes) || \count($collectionValueTypes) > 1) {
                 // the Type class does not support union types yet, so assume that no type was defined
                 $collectionValueType = null;
             } else {