Merge pull request #391 from wouterpeere/issue390-no-convergence-in-iterative-sizing

First try

Author: wouterpeere

Articles/IEA_HPT_magazine_2023/IEA_HPT_magazine.py

@@ -1,5 +1,5 @@
 """
-This document contains all the code to run create the figures of (Peere W., 2023).
+This document contains all the code to create the figures of (Peere W., 2023).
 The code is created and should be work with GHEtool v2.2.0. Further compatibility is not guaranteed.
 """
 

CHANGELOG.md

@@ -19,6 +19,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 - Problem in ConicalPipe class when working with vfr (issue #378).
 - Problem with start month DHW and optimisation (issue #378).
+- Problem with convergence (issue #390).
 
 ## [2.3.4] - 2025-07-29
 

GHEtool/Borefield.py

@@ -1475,6 +1475,8 @@ def _size_based_on_temperature_profile(self, quadrant: int, hourly: bool = False
         # (convergence if difference between borehole length in iterations is smaller than THRESHOLD_BOREHOLE_LENGTH)
         i = 0
         while not self._check_convergence(self.H, H_prev, i):
+            if H_prev != 0:
+                self.H = self.H * .5 + H_prev * 0.5
             if hourly:
                 self._calculate_temperature_profile(self.H, hourly=True)
             else:

GHEtool/Examples/turbocollector.py

@@ -55,7 +55,7 @@ def create_graphs():
         plt.plot(flow_rates, list_rb_double_smooth, label="Double smooth")
 
         plt.title(f'Borehole thermal resistance for {fluid._name}')
-        plt.ylabel('Effective borehole thermal resistance [W/(mK)]')
+        plt.ylabel('Effective borehole thermal resistance [mK/W]')
         plt.xlabel('Flow rate [l/s]')
         plt.legend()
         plt.figure()

GHEtool/Validation/comparison_with_other_sizing_tools/test1a/test1a.py

@@ -111,7 +111,7 @@ def test_1a_6h():
     assert np.isclose(depth_L4, 56.2659729399716)
     assert np.isclose(depth_L2s, 59.83238790604271)
     assert np.isclose(depth_L3s, 60.00736579796592)
-    assert np.isclose(depth_L4s, 56.73136082379056)
+    assert np.isclose(depth_L4s, 56.732044011668464)
     assert np.isclose(Rb_L2, 0.12801945735995454)
     assert np.isclose(Rb_L3, 0.1280244880933401)
     assert np.isclose(Rb_L4, 0.12793335445966403)
@@ -210,7 +210,7 @@ def test_1a_1h():
     assert np.isclose(depth_L3, 46.73933500137179)
     assert np.isclose(depth_L4, 56.2659729399716)
     assert np.isclose(depth_L2s, 46.986986159967906)
-    assert np.isclose(depth_L3s, 47.28116830541002)
+    assert np.isclose(depth_L3s, 47.28220733547535)
     assert np.isclose(depth_L4s, 56.73136082379056)
     assert np.isclose(Rb_L2, 0.12769092836836982)
     assert np.isclose(Rb_L3, 0.12769755355584275)

GHEtool/Validation/comparison_with_other_sizing_tools/test1b/test1b.py

@@ -109,10 +109,10 @@ def test_1b():
 
     assert np.isclose(depth_L2, 75.67161488446233)
     assert np.isclose(depth_L3, 75.62427445122744)
-    assert np.isclose(depth_L4, 71.49549300696316)
+    assert np.isclose(depth_L4, 71.49641008062054)
     assert np.isclose(depth_L2s, 76.71715998100636)
-    assert np.isclose(depth_L3s, 76.66992885379705)
-    assert np.isclose(depth_L4s, 72.52247308266297)
+    assert np.isclose(depth_L3s, 76.67104470064083)
+    assert np.isclose(depth_L4s, 72.52389782010322)
     assert np.isclose(Rb_L2, 0.12648875915036317)
     assert np.isclose(Rb_L3, 0.12648767833749805)
     assert np.isclose(Rb_L4, 0.12639600391560102)

GHEtool/Validation/comparison_with_other_sizing_tools/test2/test2.py

@@ -107,11 +107,11 @@ def test_2_6h():
         f"The sizing according to L4 has a depth of {depth_L4:.2f}m (using dynamic Rb* of {Rb_L4:.3f}) and {depth_L4s:.2f}m (using constant Rb*)")
 
     assert np.isclose(depth_L2, 76.84063723898525)
-    assert np.isclose(depth_L3, 79.11228401910488)
-    assert np.isclose(depth_L4, 84.77559168467357)
+    assert np.isclose(depth_L3, 79.10831161518712)
+    assert np.isclose(depth_L4, 84.77053904958063)
     assert np.isclose(depth_L2s, 77.43318625702659)
-    assert np.isclose(depth_L3s, 79.59733272530252)
-    assert np.isclose(depth_L4s, 84.97661469091508)
+    assert np.isclose(depth_L3s, 79.6008906105556)
+    assert np.isclose(depth_L4s, 84.97960330484824)
     assert np.isclose(Rb_L2, 0.11113022659380956)
     assert np.isclose(Rb_L3, 0.11146734480480838)
     assert np.isclose(Rb_L4, 0.11234852494964061)

GHEtool/Validation/comparison_with_other_sizing_tools/test4/test4.py

@@ -109,11 +109,11 @@ def test_4():
         f"The sizing according to L4 has a depth of {depth_L4:.2f}m (using dynamic Rb* of {Rb_L4:.3f}) and {depth_L4s:.2f}m (using constant Rb*)")
 
     assert np.isclose(depth_L2, 124.02695636769329)
-    assert np.isclose(depth_L3, 124.67134582762849)
-    assert np.isclose(depth_L4, 122.461471483961)
+    assert np.isclose(depth_L3, 124.67495153457973)
+    assert np.isclose(depth_L4, 122.42819840295917)
     assert np.isclose(depth_L2s, 121.50772080500283)
-    assert np.isclose(depth_L3s, 122.15337731354852)
-    assert np.isclose(depth_L4s, 119.99581098989934)
+    assert np.isclose(depth_L3s, 122.11873098056644)
+    assert np.isclose(depth_L4s, 119.96843598952158)
     assert np.isclose(Rb_L2, 0.21023380751472076)
     assert np.isclose(Rb_L3, 0.21025731326271593)
     assert np.isclose(Rb_L4, 0.2101772055278848)

GHEtool/test/general_tests/test_GHEtool.py

@@ -18,6 +18,7 @@
 from GHEtool.VariableClasses import MonthlyGeothermalLoadAbsolute, HourlyGeothermalLoad, EERCombined, \
     HourlyBuildingLoad, EER, HourlyBuildingLoadMultiYear
 from GHEtool.Methods import *
+from GHEtool import *
 
 data = GroundConstantTemperature(3, 10)
 data_ground_flux = GroundFluxTemperature(3, 10)
@@ -294,7 +295,7 @@ def test_sizing_with_use_constant_Rb():
     borefield.load = load
     assert not borefield.borehole.use_constant_Rb
     borefield.calculation_setup(L4_sizing=True)
-    assert np.isclose(205.49615778557904, borefield.size())
+    assert np.isclose(205.4926086157351, borefield.size())
     assert np.isclose(182.17320067531486, borefield.size(use_constant_Rb=True))
 
 
@@ -303,7 +304,7 @@ def test_size_with_different_peak_lengths(borefield):
 
     borefield.load.peak_injection_duration = 8
     borefield.load.peak_extraction_duration = 6
-    assert np.isclose(99.33058400216774, borefield.size(L3_sizing=True))
+    assert np.isclose(99.36581644570013, borefield.size(L3_sizing=True))
 
 
 def test_convergence_eer_combined():
@@ -468,3 +469,31 @@ def test_optimise_methods_different_start_year_dhw():
 
     load = HourlyBuildingLoadMultiYear(load.hourly_heating_load_simulation_period,
                                        load.hourly_cooling_load_simulation_period)
+
+
+def test_case_issue_390():
+    ground_data = GroundFluxTemperature(1.57, 9.6, flux=0.07)
+    fluid = TemperatureDependentFluidData('MPG', 25, False)
+    flow = ConstantFlowRate(mfr=0.3)
+    pipe = SingleUTube(1.5, 0.013, 0.016, 0.4, 0.035)
+
+    borehole = Borehole(fluid, pipe, flow)
+
+    peak_cooling = [0, 0, 0, 0, 6.225, 11.339999999999998, 15, 14.639999999999999, 8.235, 0, 0, 0]
+    peak_heating = [31.3, 31.0183, 25.102600000000002, 17.7158, 8.2632, 0, 0, 0, 2.0658, 11.5184, 21.8474, 29.2342]
+    baseload_cooling = [0, 0, 0, 0, 1232, 2255, 2970, 2904, 1639, 0, 0, 0]
+    baseload_heating = [11017.6, 10892.4, 8826.6, 6260, 2817, 0, 0, 0, 751.1999999999999, 4069, 7699.8, 10266.4]
+
+    load = MonthlyBuildingLoadAbsolute(baseload_heating, baseload_cooling, peak_heating, peak_cooling, dhw=5000,
+                                       efficiency_dhw=3, efficiency_cooling=20, simulation_period=25)
+
+    borefield = Borefield(ground_data=ground_data, load=load)
+
+    borefield.create_rectangular_borefield(4, 4, 6, 6, 100, 1, 0.07)
+
+    borefield.set_min_avg_fluid_temperature(0)
+    borefield.set_max_avg_fluid_temperature(17)
+
+    borefield.borehole = borehole
+    borefield.size_L3()
+    assert borefield.H == 86.4119598683636

GHEtool/test/general_tests/test_GHEtool_two.py

@@ -244,7 +244,7 @@ def test_size_with_multiple_ground_layers():
     borefield.load.peak_injection_duration = 8
     borefield.load.peak_extraction_duration = 6
     assert np.isclose(96.87238165292221, borefield.size(L2_sizing=True))
-    assert np.isclose(97.60790804951675, borefield.size(L3_sizing=True))
+    assert np.isclose(97.46310736940708, borefield.size(L3_sizing=True))
 
     # now with multiple layers
     layer_1 = GroundLayer(k_s=1.7, thickness=4.9)