fix: catch errors in EnumerateFiles

Author: woutervanranst

src/Arius.Core/Shared/Extensions/IEnumerableExtensions.cs

@@ -0,0 +1,28 @@
+using Microsoft.Extensions.Logging;
+
+namespace Arius.Core.Shared.Extensions;
+
+internal static class IEnumerableExtensions
+{
+    public static IEnumerable<T> WithErrorLogging<T>(this IEnumerable<T> source, ILogger logger, string msg)
+    {
+        using var e = source.GetEnumerator();
+
+        while (true)
+        {
+            bool moved;
+            try
+            {
+                moved = e.MoveNext();
+            }
+            catch (Exception ex)
+            {
+                logger.LogError(ex, msg);
+                throw;
+            }
+
+            if (!moved) yield break;
+            yield return e.Current;
+        }
+    }
+}

src/Arius.Core/Shared/FileSystem/FilePairFileSystem.cs

@@ -1,4 +1,5 @@
-using Microsoft.Extensions.Logging;
+using Arius.Core.Shared.Extensions;
+using Microsoft.Extensions.Logging;
 using Zio;
 using Zio.FileSystems;
 
@@ -109,7 +110,7 @@ private IEnumerable<FileEntry> EnumerateFiles(DirectoryEntry directory, SearchOp
             yield break;
         }
 
-        foreach (var fe in directory.EnumerateFiles())
+        foreach (var fe in directory.EnumerateFiles().WithErrorLogging(logger, $"Error enumerating files in directory {directory.FullName}"))
         {
             if (ShouldSkipFile(fe))
             {
@@ -123,9 +124,9 @@ private IEnumerable<FileEntry> EnumerateFiles(DirectoryEntry directory, SearchOp
         // Only recurse into subdirectories if AllDirectories is specified
         if (searchOption == SearchOption.AllDirectories)
         {
-            foreach (var subDir in directory.EnumerateDirectories())
+            foreach (var subDir in directory.EnumerateDirectories().WithErrorLogging(logger, $"Error enumerating directories in directory {directory.FullName}"))
             {
-                foreach (var file in EnumerateFiles(subDir, searchOption))
+                foreach (var file in EnumerateFiles(subDir, searchOption).WithErrorLogging(logger, $"Error enumerating files in directory {subDir.FullName}"))
                 {
                     yield return file;
                 }