fix: better fix for identical time-based database naming during fast tests

Author: woutervanranst

src/Arius.Core.Tests/Features/Commands/Archive/ArchiveCommandHandlerContextTests.cs

@@ -52,7 +52,7 @@ public async Task CreateAsync_WhenNoRemoteStateExists_ShouldCreateNewStateFile()
         // Verify a new state file was created (with current timestamp format)
         var stateFiles = stateCache.GetStateFileEntries().ToArray();
         stateFiles.Length.ShouldBe(1);
-        stateFiles[0].Name.ShouldMatch(@"\d{4}-\d{2}-\d{2}T\d{2}-\d{2}-\d{2}\.db");
+        stateFiles[0].Name.ShouldMatch(@"\d{4}-\d{2}-\d{2}T\d{2}-\d{2}-\d{2}\-\d{3}\.db");
 
         // Verify no download was attempted since no remote state exists
         await mockArchiveStorage.DidNotReceive().DownloadStateAsync(Arg.Any<string>(), Arg.Any<FileEntry>(), Arg.Any<CancellationToken>());
@@ -101,7 +101,7 @@ await mockArchiveStorage.Received(1).DownloadStateAsync(
 
         var newStateFile = stateFiles.FirstOrDefault(f => f.Name != $"{existingStateName}.db");
         newStateFile.ShouldNotBeNull("a new state file should be created");
-        newStateFile.Name.ShouldMatch(@"\d{4}-\d{2}-\d{2}T\d{2}-\d{2}-\d{2}\.db");
+        newStateFile.Name.ShouldMatch(@"\d{4}-\d{2}-\d{2}T\d{2}-\d{2}-\d{2}\-\d{3}\.db");
     }
 
     [Fact]
@@ -139,6 +139,6 @@ public async Task CreateAsync_WhenRemoteStateExistsAndIsPresentLocally_ShouldNot
 
         var newStateFile = stateFiles.FirstOrDefault(f => f.Name != $"{existingStateName}.db");
         newStateFile.ShouldNotBeNull("a new state file should be created");
-        newStateFile.Name.ShouldMatch(@"\d{4}-\d{2}-\d{2}T\d{2}-\d{2}-\d{2}\.db");
+        newStateFile.Name.ShouldMatch(@"\d{4}-\d{2}-\d{2}T\d{2}-\d{2}-\d{2}\-\d{3}\.db");
     }
 }

src/Arius.Core.Tests/Features/Commands/Archive/ArchiveCommandHandlerHandleTests.cs

@@ -62,24 +62,15 @@ private static (int FileCount, int ExistingPointerCount) GetInitialFileStatistic
         var command        = commandBuilder.Build();
         var archiveStorage = storageBuilder.Build();
 
-        Retry:
-        try
-        {
-            var builder = new HandlerContextBuilder(command, loggerFactory)
-                .WithArchiveStorage(archiveStorage);
+        var builder = new HandlerContextBuilder(command, loggerFactory)
+            .WithArchiveStorage(archiveStorage);
 
-            if (hasher != null)
-                builder = builder.WithHasher(hasher);
+        if (hasher != null)
+            builder = builder.WithHasher(hasher);
 
-            var handlerContext = await builder.BuildAsync();
+        var handlerContext = await builder.BuildAsync();
 
-            return (command, handlerContext, storageBuilder, loggerFactory);
-        }
-        catch (IOException)
-        {
-            await Task.Delay(100); // Delay until the statefile name ("yyyy-MM-ddTHH-mm-ss") is in different seconds
-            goto Retry;
-        }
+        return (command, handlerContext, storageBuilder, loggerFactory);
     }
 
     [Fact(Skip = "TODO")]

src/Arius.Core/Features/Commands/Archive/HandlerContextBuilder.cs

@@ -82,7 +82,7 @@ async Task<StateRepository> BuildStateRepositoryAsync(IArchiveStorage archiveSto
             var stateCache = new StateCache(request.AccountName, request.ContainerName);
 
             // Determine the version name for this run
-            var versionName = DateTime.UtcNow.ToString("yyyy-MM-ddTHH-mm-ss");
+            var versionName = DateTime.UtcNow.ToString("yyyy-MM-ddTHH-mm-ss-fff");
             request.ProgressReporter?.Report(new TaskProgressUpdate($"Determining version name '{versionName}'...", 0));
 
             // Get the latest state from blob storage