noggit: mpq: refacror local file save-load system

Author: gratural

src/noggit/MPQ.cpp

@@ -180,7 +180,7 @@ MPQFile::MPQFile(std::string const& filename)
   : eof(true)
   , pointer(0)
   , External(false)
-  , _filename(noggit::mpq::normalized_filename(filename))
+  , _filename(filename)
   , _disk_path (getDiskPath (_filename))
 {
   if (filename.empty())
@@ -358,5 +358,26 @@ namespace noggit
                      );
       return filename;
     }
+    std::string uni_path (std::string filename)
+    {
+    try
+    {
+      // Check without normalization
+      std::filesystem::path local_path(getDiskPath(filename));
+
+      if (std::filesystem::exists(local_path) || existsInMPQ (filename))
+      {
+        return filename;
+      }
+      else
+      {
+        return normalized_filename(filename);
+      }
+    }
+    catch (const std::exception& e)
+    {
+      throw std::runtime_error ("Error! File " + filename + " does not exists");
+    }
+    }
   }
 }

src/noggit/MPQ.h

@@ -107,5 +107,6 @@ namespace noggit
   {
     std::string normalized_filename (std::string filename);
     std::string normalized_filename_insane (std::string filename);
+    std::string uni_path (std::string filename);
   }
 }

src/noggit/World.cpp

@@ -58,7 +58,7 @@ bool World::IsEditableWorld(int pMapId)
   }
 
   std::stringstream ssfilename;
-  ssfilename << "World\\Maps\\" << lMapName << "\\" << lMapName << ".wdt";
+  ssfilename << noggit::mpq::uni_path("World/Maps/" + lMapName + "/" + lMapName + ".wdt");
 
   if (!MPQFile::exists(ssfilename.str()))
   {

src/noggit/map_horizon.cpp

@@ -92,7 +92,7 @@ namespace noggit
 map_horizon::map_horizon(const std::string& basename, const MapIndex * const index)
 {
   std::stringstream filename;
-  filename << "World\\Maps\\" << basename << "\\" << basename << ".wdl";
+  filename << noggit::mpq::uni_path("World/Maps/" + basename + "/" + basename + ".wdl");
   _filename = filename.str();
 
   if (!MPQFile::exists(_filename))

src/noggit/map_index.cpp

@@ -32,7 +32,7 @@ MapIndex::MapIndex (const std::string &pBasename, int map_id, World* world)
   _loading_radius = NoggitSettings.value("loading_radius", 1).toInt();
 
   std::stringstream filename;
-  filename << "World\\Maps\\" << basename << "\\" << basename << ".wdt";
+  filename << noggit::mpq::uni_path("World/Maps/" + basename + "/" + basename + ".wdt");
 
   MPQFile theFile(filename.str());
 
@@ -87,7 +87,7 @@ MapIndex::MapIndex (const std::string &pBasename, int map_id, World* world)
       theFile.seekRelative(4);
 
       std::stringstream adt_filename;
-      adt_filename << "World\\Maps\\" << basename << "\\" << basename << "_" << i << "_" << j << ".adt";
+      adt_filename << noggit::mpq::uni_path("World/Maps/" + basename + "/" + basename + "_" + std::to_string(i) + "_" + std::to_string(j) + ".adt");
 
       mTiles[j][i].tile = nullptr;
       mTiles[j][i].onDisc = MPQFile::existsOnDisk(adt_filename.str());
@@ -149,7 +149,7 @@ void MapIndex::saveall (World* world)
 void MapIndex::save()
 {
   std::stringstream filename;
-  filename << "World\\Maps\\" << basename << "\\" << basename << ".wdt";
+  filename << noggit::mpq::uni_path("World/Maps/" + basename + "/" + basename + ".wdt");
 
   //NOGGIT_LOG << "Saving WDT \"" << filename << "\"." << std::endl;
 
@@ -317,7 +317,7 @@ MapTile* MapIndex::loadTile(const tile_index& tile, bool reloading)
   }
 
   std::stringstream filename;
-  filename << "World\\Maps\\" << basename << "\\" << basename << "_" << tile.x << "_" << tile.z << ".adt";
+  filename << noggit::mpq::uni_path("World/Maps/" + basename + "/" + basename + "_" + std::to_string(tile.x) + "_" + std::to_string(tile.z) + ".adt");
 
   if (!MPQFile::exists(filename.str()))
   {
@@ -610,7 +610,7 @@ uid_fix_status MapIndex::fixUIDs (World* world, bool cancel_on_model_loading_err
       }
 
       std::stringstream filename;
-      filename << "World\\Maps\\" << basename << "\\" << basename << "_" << x << "_" << z << ".adt";
+      filename << noggit::mpq::uni_path("World/Maps/" + basename + "/" + basename + "_" + std::to_string(x) + "_" + std::to_string(z) + ".adt");
 
       if (!MPQFile::exists(filename.str()))
       {
@@ -860,7 +860,7 @@ uid_fix_status MapIndex::fixUIDs (World* world, bool cancel_on_model_loading_err
       // that shouldn't be there to avoid creating new duplicates
 
       std::stringstream filename;
-      filename << "World\\Maps\\" << basename << "\\" << basename << "_" << x << "_" << z << ".adt";
+      filename << noggit::mpq::uni_path("World/Maps/" + basename + "/" + basename + "_" + std::to_string(x) + "_" + std::to_string(z) + ".adt");
 
       // load the tile without the models
       MapTile tile(x, z, filename.str(), mBigAlpha, false, use_mclq_green_lava(), false, world, tile_mode::uid_fix_all);
@@ -900,7 +900,7 @@ void MapIndex::searchMaxUID()
       }
 
       std::stringstream filename;
-      filename << "World\\Maps\\" << basename << "\\" << basename << "_" << x << "_" << z << ".adt";
+      filename << noggit::mpq::uni_path("World/Maps/" + basename + "/" + basename + "_" + std::to_string(x) + "_" + std::to_string(z) + ".adt");
       highestGUID = std::max(highestGUID, getHighestGUIDFromFile(filename.str()));
     }
   }