chore: improve CI/CD infrastructure and tooling configuration

- Refactored GitHub Actions workflows with deny, WASM, and enhanced caching
- Simplified mise.toml to tool definitions only (removed task aliases)
- Refactored install scripts for cross-project reusability with environment config
- Added yamllint configuration for YAML validation
- Updated CHANGELOG.md with comprehensive infrastructure improvements

Author: danielsreichenbach

.github/workflows/cache-cleanup.yml

@@ -1,34 +1,46 @@
 ---
-name: Cleanup caches for closed PRs
+name: Cache Cleanup
 
 on:
-  # Run twice every day to remove the cache so that the caches from the closed prs
-  # are removed.
   schedule:
     - cron: '0 17 * * *'
     - cron: '30 18 * * *'
+
   workflow_dispatch:
 
+permissions: write-all
+
 jobs:
   cleanup:
-    name: Clear all GitHub action caches
+    name: Cleanup Caches
     runs-on: ubuntu-latest
-    permissions: write-all
-
     steps:
-      - name: Clear all caches
+      - name: Get all cache keys
+        id: caches
         run: |
-          echo "Fetching list of cache key"
-          cacheKeysForPR=$(gh cache list --limit 1000 --json id --jq '.[].id')
+          gh cache list --limit 100 --json id,key --jq '.[].id' > cache_ids.txt
+          CACHE_COUNT=$(wc -l < cache_ids.txt)
+          echo "Found $CACHE_COUNT caches to delete"
+          echo "cache_count=$CACHE_COUNT" >> "$GITHUB_OUTPUT"
+        env:
+          GH_TOKEN: ${{ github.token }}
 
-          ## Setting this to not fail the workflow while deleting cache keys.
-          set +e
-          echo "Deleting caches..."
-          for cacheKey in $cacheKeysForPR
-          do
-              gh cache delete $cacheKey
-          done
-          echo "Done"
+      - name: Delete all caches
+        if: steps.caches.outputs.cache_count != '0'
+        run: |
+          set +e  # Don't fail if some caches can't be deleted
+          while read -r cache_id; do
+            echo "Deleting cache: $cache_id"
+            gh cache delete "$cache_id"
+          done < cache_ids.txt
         env:
           GH_TOKEN: ${{ github.token }}
-          GH_REPO: ${{ github.repository }}
+
+      - name: Summary
+        run: |
+          echo "Cache cleanup completed"
+          if [ "${{ steps.caches.outputs.cache_count }}" = "0" ]; then
+            echo "No caches to delete"
+          else
+            echo "Deleted ${{ steps.caches.outputs.cache_count }} caches"
+          fi

.github/workflows/ci.yml

@@ -17,7 +17,6 @@ env:
   CARGO_INCREMENTAL: 0
   CARGO_NET_RETRY: 10
   RUSTUP_MAX_RETRIES: 10
-  # Performance improvements
   CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
   CARGO_PROFILE_DEV_DEBUG: 0
 
@@ -26,7 +25,6 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  # Detect which crates have changed
   changed-files:
     name: Detect changed crates
     runs-on: ubuntu-latest
@@ -48,16 +46,7 @@ jobs:
           files: |
             Cargo.toml
             Cargo.lock
-            file-formats/archives/wow-mpq/**
-            file-formats/world-data/wow-adt/**
-            file-formats/world-data/wow-wdl/**
-            file-formats/world-data/wow-wdt/**
-            file-formats/graphics/wow-blp/**
-            file-formats/graphics/wow-m2/**
-            file-formats/graphics/wow-wmo/**
-            file-formats/database/wow-cdbc/**
-            warcraft-rs/**
-            ffi/**
+            crates/**
           files_ignore: |
             **/*.md
             **/*.txt
@@ -70,46 +59,42 @@ jobs:
           ALL_CHANGED_FILES: ${{ steps.changed-files.outputs.all_changed_files }}
         run: |
           echo "Changed files: $ALL_CHANGED_FILES"
-          
-          # If no files changed, we still need to run tests (e.g., scheduled runs)
+
           if [ -z "$ALL_CHANGED_FILES" ]; then
             echo "No files changed, will test all crates"
-            echo "any_crate_changed=true" >> $GITHUB_OUTPUT
-            echo "crates_changed=" >> $GITHUB_OUTPUT
+            echo "any_crate_changed=true" >> "$GITHUB_OUTPUT"
+            echo "crates_changed=" >> "$GITHUB_OUTPUT"
             exit 0
           fi
-          
-          # Detect which crates changed
-          crates_changed=""
-          
-          # Check if root Cargo.toml or Cargo.lock changed (affects all crates)
+
           if echo "$ALL_CHANGED_FILES" | grep -E "^Cargo\.(toml|lock)$"; then
             echo "Root Cargo files changed, will test all crates"
-            echo "any_crate_changed=true" >> $GITHUB_OUTPUT
-            echo "crates_changed=" >> $GITHUB_OUTPUT
+            echo "any_crate_changed=true" >> "$GITHUB_OUTPUT"
+            echo "crates_changed=" >> "$GITHUB_OUTPUT"
             exit 0
           fi
-          
-          # Check individual crate changes
-          for crate in wow-mpq wow-adt wow-wdl wow-wdt wow-blp wow-m2 wow-wmo wow-cdbc warcraft-rs; do
-            if echo "$ALL_CHANGED_FILES" | grep -E "$crate/"; then
-              crates_changed="$crates_changed $crate"
-            fi
-          done
-          
-          # Remove leading space and output
-          crates_changed=$(echo $crates_changed | xargs)
+
+          crates_changed=""
+          if [ -d "crates" ]; then
+            for crate_dir in crates/*/; do
+              crate=$(basename "$crate_dir")
+              if echo "$ALL_CHANGED_FILES" | grep -E "crates/$crate/"; then
+                crates_changed="$crates_changed $crate"
+              fi
+            done
+          fi
+
+          crates_changed=$(echo "$crates_changed" | xargs)
           if [ -n "$crates_changed" ]; then
             echo "Crates changed: $crates_changed"
-            echo "any_crate_changed=true" >> $GITHUB_OUTPUT
-            echo "crates_changed=$crates_changed" >> $GITHUB_OUTPUT
+            echo "any_crate_changed=true" >> "$GITHUB_OUTPUT"
+            echo "crates_changed=$crates_changed" >> "$GITHUB_OUTPUT"
           else
             echo "No crate changes detected"
-            echo "any_crate_changed=false" >> $GITHUB_OUTPUT
-            echo "crates_changed=" >> $GITHUB_OUTPUT
+            echo "any_crate_changed=false" >> "$GITHUB_OUTPUT"
+            echo "crates_changed=" >> "$GITHUB_OUTPUT"
           fi
 
-  # Quick checks that should fail fast
   quick-checks:
     name: Quick Checks
     runs-on: ubuntu-latest
@@ -120,7 +105,7 @@ jobs:
       - name: Install Rust toolchain with formatting and linting components
         uses: dtolnay/rust-toolchain@v1
         with:
-          toolchain: 1.92.0
+          toolchain: 1.92
           components: rustfmt, clippy
 
       - name: Cache Rust dependencies
@@ -130,19 +115,29 @@ jobs:
           cache-on-failure: true
           cache-all-crates: true
 
-      # Format check (fastest)
       - name: Check formatting
         run: cargo fmt --all -- --check
 
-      # Check compilation
       - name: Check compilation
-        run: cargo check --all-features --all-targets
+        run: cargo check --workspace --all-targets
 
-      # Clippy lints
       - name: Clippy
-        run: cargo clippy --all-features --all-targets -- -D warnings
+        run: cargo clippy --workspace --all-targets
+
+  deny:
+    name: Cargo Deny
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - name: Check dependencies
+        uses: EmbarkStudios/cargo-deny-action@v2
+        with:
+          command: check
+          arguments: --all-features
+          rust-version: "1.92"
 
-  # Main test suite with optimized matrix
   test:
     name: Test (${{ matrix.rust }} on ${{ matrix.os }})
     needs: [quick-checks, changed-files]
@@ -152,7 +147,7 @@ jobs:
       matrix:
         include:
           - os: ubuntu-latest
-            rust: 1.92.0
+            rust: 1.92
           - os: ubuntu-latest
             rust: stable
     runs-on: ${{ matrix.os }}
@@ -165,6 +160,11 @@ jobs:
         with:
           toolchain: ${{ matrix.rust }}
 
+      - name: Install cargo-nextest
+        uses: taiki-e/install-action@v2
+        with:
+          tool: cargo-nextest
+
       - name: Cache Rust dependencies for ${{ matrix.os }}
         uses: Swatinem/rust-cache@v2
         with:
@@ -173,49 +173,61 @@ jobs:
           cache-all-crates: true
           save-if: ${{ github.ref == 'refs/heads/main' }}
 
-      - name: Install cargo-nextest
-        uses: taiki-e/install-action@v2
-        with:
-          tool: cargo-nextest
-
-      # Determine test scope based on changed crates
       - name: Determine test scope
         id: test-scope
         env:
           CRATES_CHANGED: ${{ needs.changed-files.outputs.crates_changed }}
         run: |
           if [ -z "$CRATES_CHANGED" ]; then
             echo "Testing all crates (full workspace test)"
-            echo "test_args=--workspace" >> $GITHUB_OUTPUT
+            echo "test_args=--workspace" >> "$GITHUB_OUTPUT"
           else
             echo "Testing only changed crates: $CRATES_CHANGED"
             args=""
             for crate in $CRATES_CHANGED; do
               args="$args -p $crate"
             done
-            echo "test_args=$args" >> $GITHUB_OUTPUT
+            echo "test_args=$args" >> "$GITHUB_OUTPUT"
           fi
 
-      # Test with all features
-      - name: Test all features (changed crates)
-        run: cargo nextest run --all-features ${{ steps.test-scope.outputs.test_args }}
+      - name: Test default features (changed crates)
+        run: cargo nextest run --profile ci ${{ steps.test-scope.outputs.test_args }}
 
-      # Test with no default features
       - name: Test no default features (changed crates)
-        run: cargo nextest run --no-default-features ${{ steps.test-scope.outputs.test_args }}
+        run: cargo nextest run --profile ci --no-default-features ${{ steps.test-scope.outputs.test_args }}
 
-      # Test each changed crate individually (only on stable Linux)
-      - name: Test individual changed crates
-        if: matrix.os == 'ubuntu-latest' && matrix.rust == 'stable' && needs.changed-files.outputs.crates_changed != ''
+  wasm:
+    name: WASM Compilation
+    runs-on: ubuntu-latest
+    if: vars.WASM_CRATES != '[]'
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - name: Install Rust toolchain with WASM target
+        uses: dtolnay/rust-toolchain@v1
+        with:
+          toolchain: 1.92
+          targets: wasm32-unknown-unknown
+
+      - name: Cache Rust dependencies
+        uses: Swatinem/rust-cache@v2
+        with:
+          shared-key: "wasm-${{ hashFiles('**/Cargo.lock') }}"
+          cache-on-failure: true
+          cache-all-crates: true
+
+      - name: Check WASM compilation
         env:
-          CRATES_CHANGED: ${{ needs.changed-files.outputs.crates_changed }}
+          WASM_CRATES: ${{ vars.WASM_CRATES }}
         run: |
-          for crate in $CRATES_CHANGED; do
-            echo "Testing $crate individually..."
-            cargo nextest run -p $crate --all-features
-          done
+          if [ -n "$WASM_CRATES" ]; then
+            for crate in $(echo "$WASM_CRATES" | jq -r '.[]'); do
+              echo "Checking $crate for WASM..."
+              cargo check --target wasm32-unknown-unknown -p "$crate"
+            done
+          fi
 
-  # Documentation build - runs in parallel
   docs:
     name: Documentation
     runs-on: ubuntu-latest
@@ -226,23 +238,23 @@ jobs:
       - name: Install Rust toolchain for documentation
         uses: dtolnay/rust-toolchain@v1
         with:
-          toolchain: 1.92.0
+          toolchain: 1.92
 
       - name: Cache documentation dependencies
         uses: Swatinem/rust-cache@v2
         with:
           shared-key: "docs-${{ hashFiles('**/Cargo.lock') }}"
           cache-on-failure: true
           cache-all-crates: true
+
       - name: Build documentation
-        run: cargo doc --all-features --no-deps
+        run: cargo doc --workspace --no-deps
         env:
           RUSTDOCFLAGS: -D warnings
-      - name: Check for broken links
-        run: cargo doc --all-features --no-deps --document-private-items
 
+      - name: Check for broken links
+        run: cargo doc --workspace --no-deps --document-private-items
 
-  # Coverage collection - runs in parallel
   coverage:
     name: Code Coverage
     runs-on: ubuntu-latest
@@ -269,8 +281,13 @@ jobs:
         with:
           tool: cargo-llvm-cov
 
+      - name: Install cargo-nextest for faster coverage collection
+        uses: taiki-e/install-action@v2
+        with:
+          tool: cargo-nextest
+
       - name: Collect coverage
-        run: cargo llvm-cov --all-features --workspace --lcov --output-path lcov.info
+        run: cargo llvm-cov nextest --workspace --lcov --output-path lcov.info
 
       - name: Upload coverage reports to Codecov
         uses: codecov/codecov-action@v5
@@ -279,25 +296,24 @@ jobs:
           fail_ci_if_error: false
           token: ${{ secrets.CODECOV_TOKEN }}
 
-  # Success marker for branch protection
   ci-success:
     name: CI Success
     if: always()
-    needs: [quick-checks, test, docs, changed-files]
+    needs: [quick-checks, deny, test, docs, wasm, coverage, changed-files]
     runs-on: ubuntu-latest
     steps:
       - name: Check all jobs
         run: |
-          # Skip test job check if no crates changed
           if [[ "${{ needs.changed-files.outputs.any_crate_changed }}" == "false" ]]; then
             echo "No crate changes detected, skipping test job check"
-            if [[ "${{ needs.quick-checks.result }}" == "failure" || "${{ needs.docs.result }}" == "failure" ]]; then
-              echo "Quick checks or docs failed"
+            if [[ "${{ needs.quick-checks.result }}" == "failure" || "${{ needs.deny.result }}" == "failure" || "${{ needs.docs.result }}" == "failure" ]]; then
+              echo "Quick checks, deny, or docs failed"
               exit 1
             fi
           else
-            if [[ "${{ contains(needs.*.result, 'failure') }}" == "true" ]]; then
-              echo "One or more jobs failed"
+            # Check critical jobs (wasm and coverage are optional)
+            if [[ "${{ needs.quick-checks.result }}" == "failure" || "${{ needs.deny.result }}" == "failure" || "${{ needs.test.result }}" == "failure" || "${{ needs.docs.result }}" == "failure" ]]; then
+              echo "Critical job failed"
               exit 1
             fi
           fi