Merge pull request #400 from wp-bootstrap/fix/issue/395/typo-in-function-name

Correct typo in function name

Author: pattonwebz

CHANGELOG.md

@@ -1,5 +1,8 @@
 #CHANGELOG
 
+## [4.2.0]
+- Fix typo in function name 'seporate'->'separate' (private function, no need to add back-compat).
+
 ## [4.1.0]
 - Prevent error `trying to get property of non-object` when no menu is set to a location using the walker.
 - Add `$depth` as 4th parameter passed to `nav_menu_link_attributes`.

class-wp-bootstrap-navwalker.php

@@ -116,7 +116,7 @@ public function start_el( &$output, $item, $depth = 0, $args = array(), $id = 0
 			 * NOTE: linkmod and icon class arrays are passed by reference and
 			 * are maybe modified before being used later in this function.
 			 */
-			$classes = self::seporate_linkmods_and_icons_from_classes( $classes, $linkmod_classes, $icon_classes, $depth );
+			$classes = self::separate_linkmods_and_icons_from_classes( $classes, $linkmod_classes, $icon_classes, $depth );
 
 			// Join any icon classes plucked from $classes into a string.
 			$icon_class_string = join( ' ', $icon_classes );
@@ -396,7 +396,7 @@ public static function fallback( $args ) {
 		 *
 		 * @return array  $classes         a maybe modified array of classnames.
 		 */
-		private function seporate_linkmods_and_icons_from_classes( $classes, &$linkmod_classes, &$icon_classes, $depth ) {
+		private function separate_linkmods_and_icons_from_classes( $classes, &$linkmod_classes, &$icon_classes, $depth ) {
 			// Loop through $classes array to find linkmod or icon classes.
 			foreach ( $classes as $key => $class ) {
 				// If any special classes are found, store the class in it's

tests/test-navwalker.php

@@ -240,18 +240,18 @@ public function test_fallback_function_output_loggedin() {
 	}
 
 	/**
-	 * Test seporate_linkmods_and_icons_from_classes Function exists.
+	 * Test separate_linkmods_and_icons_from_classes Function exists.
 	 *
 	 * @access public
 	 * @return void
 	 */
-	public function test_seporate_linkmods_and_icons_from_classes_function_exists() {
+	public function test_separate_linkmods_and_icons_from_classes_function_exists() {
 
 		$wp_bootstrap_navwalker = $this->walker;
 
 		$this->assertTrue(
-			method_exists( $wp_bootstrap_navwalker, 'seporate_linkmods_and_icons_from_classes' ),
-			'Class does not have method seporate_linkmods_and_icons_from_classes.'
+			method_exists( $wp_bootstrap_navwalker, 'separate_linkmods_and_icons_from_classes' ),
+			'Class does not have method separate_linkmods_and_icons_from_classes.'
 		);
 
 	}
@@ -260,19 +260,19 @@ public function test_seporate_linkmods_and_icons_from_classes_function_exists()
 	 * Test that the function catches a random assortment of glyphicon icon
 	 * classes mixed with with regular classnames.
 	 *
-	 * @depends test_seporate_linkmods_and_icons_from_classes_function_exists
+	 * @depends test_separate_linkmods_and_icons_from_classes_function_exists
 	 *
 	 * @access public
 	 * @return void
 	 */
-	public function test_seporate_linkmods_and_icons_from_classes_fontawesome() {
+	public function test_separate_linkmods_and_icons_from_classes_fontawesome() {
 
 		$wp_bootstrap_navwalker = $this->walker;
 		// since we're working with private methods we need to use a reflector.
 		$reflector = new ReflectionClass( 'WP_Bootstrap_Navwalker' );
 
 		// get a reflected method for the opener function and set to public.
-		$method_open = $reflector->getMethod( 'seporate_linkmods_and_icons_from_classes' );
+		$method_open = $reflector->getMethod( 'separate_linkmods_and_icons_from_classes' );
 		$method_open->setAccessible( true );
 
 		$icons_array     = $this->some_fontawesome_classes;
@@ -314,19 +314,19 @@ public function test_seporate_linkmods_and_icons_from_classes_fontawesome() {
 	 * Test that the function catches a random assortment of font awesome icon
 	 * classes mixed with with regular classnames.
 	 *
-	 * @depends test_seporate_linkmods_and_icons_from_classes_function_exists
+	 * @depends test_separate_linkmods_and_icons_from_classes_function_exists
 	 *
 	 * @access public
 	 * @return void
 	 */
-	public function test_seporate_linkmods_and_icons_from_classes_glyphicons() {
+	public function test_separate_linkmods_and_icons_from_classes_glyphicons() {
 
 		$wp_bootstrap_navwalker = $this->walker;
 		// since we're working with private methods we need to use a reflector.
 		$reflector = new ReflectionClass( 'WP_Bootstrap_Navwalker' );
 
 		// get a reflected method for the opener function and set to public.
-		$method_open = $reflector->getMethod( 'seporate_linkmods_and_icons_from_classes' );
+		$method_open = $reflector->getMethod( 'separate_linkmods_and_icons_from_classes' );
 		$method_open->setAccessible( true );
 
 		$icons_array     = $this->some_glyphicons_classes;
@@ -368,19 +368,19 @@ public function test_seporate_linkmods_and_icons_from_classes_glyphicons() {
 	 * Test that the function catches a random assortment of font awesome icon
 	 * classes mixed with with regular classnames.
 	 *
-	 * @depends test_seporate_linkmods_and_icons_from_classes_function_exists
+	 * @depends test_separate_linkmods_and_icons_from_classes_function_exists
 	 *
 	 * @access public
 	 * @return void
 	 */
-	public function test_seporate_linkmods_and_icons_from_classes_linkmods() {
+	public function test_separate_linkmods_and_icons_from_classes_linkmods() {
 
 		$wp_bootstrap_navwalker = $this->walker;
 		// since we're working with private methods we need to use a reflector.
 		$reflector = new ReflectionClass( 'WP_Bootstrap_Navwalker' );
 
 		// get a reflected method for the opener function and set to public.
-		$method_open = $reflector->getMethod( 'seporate_linkmods_and_icons_from_classes' );
+		$method_open = $reflector->getMethod( 'separate_linkmods_and_icons_from_classes' );
 		$method_open->setAccessible( true );
 
 		$valid_linkmods  = $this->valid_linkmod_classes;
@@ -439,23 +439,23 @@ public function test_seporate_linkmods_and_icons_from_classes_linkmods() {
 	 * Test that the function catches all possible linkmod classes, any icon
 	 * classes and leaves the other classes as-is on the array.
 	 *
-	 * @depends test_seporate_linkmods_and_icons_from_classes_function_exists
+	 * @depends test_separate_linkmods_and_icons_from_classes_function_exists
 	 *
-	 * @depends test_seporate_linkmods_and_icons_from_classes_fontawesome
-	 * @depends test_seporate_linkmods_and_icons_from_classes_glyphicons
-	 * @depends test_seporate_linkmods_and_icons_from_classes_linkmods
+	 * @depends test_separate_linkmods_and_icons_from_classes_fontawesome
+	 * @depends test_separate_linkmods_and_icons_from_classes_glyphicons
+	 * @depends test_separate_linkmods_and_icons_from_classes_linkmods
 	 *
 	 * @access public
 	 * @return void
 	 */
-	public function test_seporate_linkmods_and_icons_from_classes_fulltest() {
+	public function test_separate_linkmods_and_icons_from_classes_fulltest() {
 
 		$wp_bootstrap_navwalker = $this->walker;
 		// since we're working with private methods we need to use a reflector.
 		$reflector = new ReflectionClass( 'WP_Bootstrap_Navwalker' );
 
 		// get a reflected method for the opener function and set to public.
-		$method_open = $reflector->getMethod( 'seporate_linkmods_and_icons_from_classes' );
+		$method_open = $reflector->getMethod( 'separate_linkmods_and_icons_from_classes' );
 		$method_open->setAccessible( true );
 
 		$icons_array     = array_merge( $this->some_fontawesome_classes, $this->some_glyphicons_classes );