Merge branch 'main' into copilot/fix-wp-core-check-update-issue

Author: swissspidy

.github/workflows/check-branch-alias.yml

@@ -0,0 +1,14 @@
+name: Check Branch Alias
+
+on:
+  release:
+    types: [released]
+  workflow_dispatch:
+
+permissions:
+  contents: write
+  pull-requests: write
+
+jobs:
+  check-branch-alias:
+    uses: wp-cli/.github/.github/workflows/reusable-check-branch-alias.yml@main

.github/workflows/copilot-setup-steps.yml

@@ -0,0 +1,46 @@
+name: "Copilot Setup Steps"
+
+on:
+  workflow_dispatch:
+  push:
+    paths:
+      - .github/workflows/copilot-setup-steps.yml
+  pull_request:
+    paths:
+      - .github/workflows/copilot-setup-steps.yml
+
+jobs:
+  copilot-setup-steps:
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v6
+
+      - name: Check existence of composer.json file
+        id: check_composer_file
+        uses: andstor/file-existence-action@v3
+        with:
+          files: "composer.json"
+
+      - name: Set up PHP environment
+        if: steps.check_composer_file.outputs.files_exists == 'true'
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: 'latest'
+          ini-values: zend.assertions=1, error_reporting=-1, display_errors=On
+          coverage: 'none'
+          tools: composer,cs2pr
+        env:
+          COMPOSER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Install Composer dependencies & cache dependencies
+        if: steps.check_composer_file.outputs.files_exists == 'true'
+        uses: ramsey/composer-install@v3
+        env:
+          COMPOSER_ROOT_VERSION: dev-${{ github.event.repository.default_branch }}
+        with:
+          # Bust the cache at least once a month - output format: YYYY-MM.
+          custom-cache-suffix: $(date -u "+%Y-%m")

.github/workflows/issue-triage.yml

@@ -0,0 +1,26 @@
+---
+name: Issue and PR Triage
+
+'on':
+  issues:
+    types: [opened]
+  pull_request_target:
+    types: [opened]
+  workflow_dispatch:
+    inputs:
+      issue_number:
+        description: 'Issue/PR number to triage (leave empty to process all)'
+        required: false
+        type: string
+
+jobs:
+  issue-triage:
+    uses: wp-cli/.github/.github/workflows/reusable-issue-triage.yml@main
+    with:
+      issue_number: >-
+        ${{
+          (github.event_name == 'workflow_dispatch' && inputs.issue_number) ||
+          (github.event_name == 'pull_request_target' && github.event.pull_request.number) ||
+          (github.event_name == 'issues' && github.event.issue.number) ||
+          ''
+        }}

.github/workflows/manage-labels.yml

@@ -0,0 +1,19 @@
+---
+name: Manage Labels
+
+'on':
+  workflow_dispatch:
+  push:
+    branches:
+      - main
+      - master
+    paths:
+      - 'composer.json'
+
+permissions:
+  issues: write
+  contents: read
+
+jobs:
+  manage-labels:
+    uses: wp-cli/.github/.github/workflows/reusable-manage-labels.yml@main

.github/workflows/welcome-new-contributors.yml

@@ -0,0 +1,12 @@
+name: Welcome New Contributors
+
+on:
+  pull_request_target:
+    types: [opened]
+    branches:
+      - main
+      - master
+
+jobs:
+  welcome:
+    uses: wp-cli/.github/.github/workflows/reusable-welcome-new-contributors.yml@main

features/core-update.feature

@@ -330,7 +330,7 @@ Feature: Update WordPress core
     When I run `wp post create --post_title='Test post' --porcelain`
     Then STDOUT should be a number
 
-  @require-php-7.2
+  @require-php-7.4
   Scenario Outline: Use `--version=(nightly|trunk)` to update to the latest nightly version
     Given a WP install
 
@@ -350,7 +350,7 @@ Feature: Update WordPress core
       | trunk      |
       | nightly    |
 
-  @require-php-7.2
+  @require-php-7.4
   Scenario: Installing latest nightly build should skip cache
     Given a WP install
 
@@ -384,3 +384,38 @@ Feature: Update WordPress core
       """
       Success:
       """
+
+  Scenario: No HTML output from async translation updates during core update
+    Given a WP install
+    And an empty cache
+
+    # Using `try` in case there are checksum warnings.
+    When I try `wp core download --version=6.5 --locale=de_DE --force`
+    Then STDOUT should contain:
+      """
+      Success: WordPress downloaded.
+      """
+
+    When I run `wp core version --extra`
+    Then STDOUT should contain:
+      """
+      Package language:  de_DE
+      """
+
+    When I run `wp core update --version=latest --force`
+    Then STDOUT should not contain:
+      """
+      <p>
+      """
+    And STDOUT should not contain:
+      """
+      <div
+      """
+    And STDOUT should not contain:
+      """
+      <script
+      """
+    And STDOUT should not contain:
+      """
+      </div>
+      """

src/Core_Command.php

@@ -1228,6 +1228,15 @@ public function update( $args, $assoc_args ) {
 
 			require_once ABSPATH . 'wp-admin/includes/upgrade.php';
 
+			// Prevent async translation updates which output HTML.
+			add_action(
+				'upgrader_process_complete',
+				static function () {
+					remove_action( 'upgrader_process_complete', array( 'Language_Pack_Upgrader', 'async_upgrade' ), 20 );
+				},
+				1
+			);
+
 			if ( $update->version ) {
 				WP_CLI::log( "Updating to version {$update->version} ({$update->locale})..." );
 			} else {