Ask user for confirmation before overwriting if file already exists (#85)

* Add guard if file exists displaying a warning and asking for confirmation and arg --yes

* Add test without testing it

* undo debug command

* remove empty line

* divide STDOUT and STDERR in two different commands

* join STDOUT and STDERR assertions in the same when

* confirm test STDERR should contain

* refactor in favor of scaffold file replacement flow

* Update dist archive ask for confirmation tests

* undo formatting test

* Tweak 'File' to 'Archive file'

---------

Co-authored-by: Daniel Bachhuber <[email protected]>

Author: sejas

features/dist-archive.feature

@@ -437,3 +437,60 @@ Feature: Generate a distribution archive of a project
       """
     And STDERR should be empty
     And the foo.zip file should exist
+
+  Scenario: Ask for confirmation if archive file exists
+    Given a WP install
+
+    When I run `wp scaffold plugin hello-world`
+    Then the wp-content/plugins/hello-world directory should exist
+    And the wp-content/plugins/hello-world/hello-world.php file should exist
+    And the wp-content/plugins/hello-world/.travis.yml file should exist
+    And the wp-content/plugins/hello-world/bin directory should exist
+
+    When I run `mkdir subdir`
+    Then the subdir directory should exist
+
+    When I run `wp dist-archive wp-content/plugins/hello-world ./subdir/hello-world-dist.zip`
+    Then STDOUT should be:
+      """
+      Success: Created hello-world-dist.zip
+      """
+    And STDERR should be empty
+    And the {RUN_DIR}/subdir/hello-world-dist.zip file should exist
+
+    When I try `echo "s" | wp dist-archive wp-content/plugins/hello-world ./subdir/hello-world-dist.zip`
+    Then STDERR should contain:
+      """
+      Warning: Archive file already exists
+      """
+    And STDOUT should contain:
+      """
+      Do you want to skip or replace it with a new archive? [s/r]:
+      """
+    And STDOUT should contain:
+      """
+      Archive generation skipped.
+      """
+    And STDOUT should not contain:
+      """
+      Success: Created hello-world-dist.zip
+      """
+    And the {RUN_DIR}/subdir/hello-world-dist.zip file should exist
+    And the return code should be 0
+
+
+    When I try `echo "r" | wp dist-archive wp-content/plugins/hello-world ./subdir/hello-world-dist.zip`
+    And STDERR should contain:
+      """
+      Warning: Archive file already exists
+      """
+    And STDOUT should contain:
+      """
+      Do you want to skip or replace it with a new archive? [s/r]:
+      """
+    And STDOUT should contain:
+      """
+      Success: Created hello-world-dist.zip
+      """
+    And the {RUN_DIR}/subdir/hello-world-dist.zip file should exist
+    And the return code should be 0

src/Dist_Archive_Command.php

@@ -195,6 +195,23 @@ public function __invoke( $args, $assoc_args ) {
 		}
 		$archive_absolute_filepath = "{$archive_path}/{$archive_filename}";
 
+		if ( file_exists( $archive_absolute_filepath ) ) {
+			WP_CLI::warning( 'Archive file already exists' );
+			WP_CLI::log( $archive_absolute_filepath );
+			$answer      = \cli\prompt(
+				'Do you want to skip or replace it with a new archive?',
+				$default = false,
+				$marker  = ' [s/r]: '
+			);
+			$should_overwrite = 'r' === strtolower( $answer );
+			if ( ! $should_overwrite ) {
+				WP_CLI::log( 'Skipping' . PHP_EOL );
+				WP_CLI::log( 'Archive generation skipped.' );
+				exit( 0 );
+			}
+			WP_CLI::log( 'Replacing' . PHP_EOL );
+		}
+
 		chdir( dirname( $source_path ) );
 
 		if ( Utils\get_flag_value( $assoc_args, 'create-target-dir' ) ) {