Feedback Updates

Author: karthick-murugan

features/user.feature

@@ -376,6 +376,24 @@ Feature: Manage WordPress users
       administrator
       """
 
+    And a user exists with login 9999
+
+    When I run `wp user update 9999 --user-pass=admin`
+    Then STDERR should contain:
+      """
+      Error: Parameter errors:
+      unknown --user-pass parameter
+      Did you mean '--user_pass'?
+      """
+
+    And a user exists with login 9999
+    
+    When I run `wp user update 9999 --user_pass=admin`
+    Then STDOUT should contain:
+      """
+      Success: Updated user 9999.
+      """
+
   Scenario: Managing user capabilities
     Given a WP install
 

src/User_Command.php

@@ -518,9 +518,6 @@ public function create( $args, $assoc_args ) {
 	 * [--role=<role>]
 	 * : A string used to set the user's role.
 	 *
-	 * --<field>=<value>
-	 * : One or more fields to update. For accepted fields, see wp_update_user().
-	 *
 	 * [--skip-email]
 	 * : Don't send an email notification to the user.
 	 *
@@ -536,49 +533,6 @@ public function update( $args, $assoc_args ) {
 			unset( $assoc_args['user_login'] );
 		}
 
-		// Define valid fields for wp_update_user().
-		$valid_fields = array(
-			'user_pass',
-			'user_nicename',
-			'user_url',
-			'user_email',
-			'display_name',
-			'nickname',
-			'first_name',
-			'last_name',
-			'description',
-			'rich_editing',
-			'user_registered',
-			'role',
-			'syntax_highlighting',
-			'comment_shortcuts',
-			'admin_color',
-			'use_ssl',
-			'show_admin_bar_front',
-			'locale',
-		);
-
-		// Check for invalid field names.
-		$invalid_fields = array();
-		foreach ( array_keys( $assoc_args ) as $field ) {
-			// Skip special flags like 'skip-email'.
-			if ( 'skip-email' === $field ) {
-				continue;
-			}
-
-			if ( ! in_array( $field, $valid_fields, true ) ) {
-				$invalid_fields[] = $field;
-			}
-		}
-
-		// Warn about invalid fields.
-		if ( ! empty( $invalid_fields ) ) {
-			foreach ( $invalid_fields as $field ) {
-				WP_CLI::warning( "Unknown --{$field} parameter." );
-				unset( $assoc_args[ $field ] );
-			}
-		}
-
 		if ( isset( $assoc_args['role'] ) ) {
 			self::validate_role( $assoc_args['role'], true );
 		}