Merge pull request #127 from BhargavBhandari90/issue/121

Default to not showing transients in options list

Author: schlessera

features/option-list.feature

@@ -117,3 +117,21 @@ Feature: List WordPress options
       sample_test_field_one,sample_test_field_value_one
       """
 
+  Scenario: Default list option without transient
+    Given a WP install
+    And I run `wp transient set wp_transient_flag wp_transient_flag`
+
+    When I run `wp option list`
+    Then STDOUT should not contain:
+      """
+      wp_transient_flag
+      """
+    And STDOUT should not contain:
+      """
+      _transient
+      """
+    And STDOUT should contain:
+      """
+      siteurl
+      """
+

src/Option_Command.php

@@ -277,11 +277,14 @@ public function list_( $args, $assoc_args ) {
 			}
 		}
 
+		// By default we don't want to display transients.
+		$show_transients = Utils\get_flag_value( $assoc_args, 'transients', false );
+
 		$transients_query = '';
-		if ( true === Utils\get_flag_value( $assoc_args, 'transients', null ) ) {
+		if ( $show_transients ) {
 			$transients_query = " AND option_name LIKE '\_transient\_%'
 			OR option_name LIKE '\_site\_transient\_%'";
-		} else if ( false === Utils\get_flag_value( $assoc_args, 'transients', null ) ) {
+		} else {
 			$transients_query = " AND option_name NOT LIKE '\_transient\_%'
 			AND option_name NOT LIKE '\_site\_transient\_%'";
 		}