Avoid variable abbreviations

Author: schlessera

src/Comment_Command.php

@@ -180,18 +180,18 @@ public function generate( $args, $assoc_args ) {
 		$total         = (int) $comment_count->total_comments;
 		$limit         = $total + $assoc_args['count'];
 
-		for ( $i = $total; $i < $limit; $i++ ) {
+		for ( $index = $total; $index < $limit; $index++ ) {
 			$comment_id = wp_insert_comment(
 				[
-					'comment_content' => "Comment {$i}",
+					'comment_content' => "Comment {$index}",
 					'comment_post_ID' => $assoc_args['post_id'],
 				]
 			);
 			if ( 'progress' === $format ) {
 				$notify->tick();
 			} elseif ( 'ids' === $format ) {
 				echo $comment_id;
-				if ( $i < $limit - 1 ) {
+				if ( $index < $limit - 1 ) {
 					echo ' ';
 				}
 			}

src/Post_Command.php

@@ -785,7 +785,7 @@ public function generate( $args, $assoc_args ) {
 		$current_depth    = 1;
 		$current_parent   = 0;
 
-		for ( $i = $total; $i < $limit; $i++ ) {
+		for ( $index = $total; $index < $limit; $index++ ) {
 
 			if ( $hierarchical ) {
 
@@ -804,11 +804,11 @@ public function generate( $args, $assoc_args ) {
 
 			$args = [
 				'post_type'     => $post_type,
-				'post_title'    => ! empty( $post_title ) && $i === $total ? $label : "{$label} {$i}",
+				'post_title'    => ! empty( $post_title ) && $index === $total ? $label : "{$label} {$index}",
 				'post_status'   => $post_status,
 				'post_author'   => $post_author,
 				'post_parent'   => $current_parent,
-				'post_name'     => ! empty( $post_title ) ? sanitize_title( $post_title . ( $i === $total ? '' : "-{$i}" ) ) : "post-{$i}",
+				'post_name'     => ! empty( $post_title ) ? sanitize_title( $post_title . ( $index === $total ? '' : "-{$index}" ) ) : "post-{$index}",
 				'post_date'     => $post_date,
 				'post_date_gmt' => $post_date_gmt,
 				'post_content'  => $post_content,
@@ -821,7 +821,7 @@ public function generate( $args, $assoc_args ) {
 				$previous_post_id = $post_id;
 				if ( 'ids' === $format ) {
 					echo $post_id;
-					if ( $i < $limit - 1 ) {
+					if ( $index < $limit - 1 ) {
 						echo ' ';
 					}
 				}

src/Term_Command.php

@@ -546,7 +546,7 @@ public function generate( $args, $assoc_args ) {
 		$suspend_cache_invalidation = wp_suspend_cache_invalidation( true );
 		$created                    = [];
 
-		for ( $i = $max_id + 1; $i <= $max_id + $count; $i++ ) {
+		for ( $index = $max_id + 1; $index <= $max_id + $count; $index++ ) {
 
 			if ( $hierarchical ) {
 
@@ -565,10 +565,10 @@ public function generate( $args, $assoc_args ) {
 
 			$args = [
 				'parent' => $current_parent,
-				'slug'   => $slug . "-{$i}",
+				'slug'   => $slug . "-{$index}",
 			];
 
-			$name = "{$label} {$i}";
+			$name = "{$label} {$index}";
 			$term = wp_insert_term( $name, $taxonomy, $args );
 			if ( is_wp_error( $term ) ) {
 				WP_CLI::warning( $term );
@@ -577,7 +577,7 @@ public function generate( $args, $assoc_args ) {
 				$previous_term_id = $term['term_id'];
 				if ( 'ids' === $format ) {
 					echo $term['term_id'];
-					if ( $i < $max_id + $count ) {
+					if ( $index < $max_id + $count ) {
 						echo ' ';
 					}
 				}

src/User_Command.php

@@ -589,9 +589,9 @@ public function generate( $args, $assoc_args ) {
 			$notify = Utils\make_progress_bar( 'Generating users', $assoc_args['count'] );
 		}
 
-		for ( $i = $total; $i < $limit; $i++ ) {
-			$login = "user_{$blog_id}_{$i}";
-			$name  = "User {$i}";
+		for ( $index = $total; $index < $limit; $index++ ) {
+			$login = "user_{$blog_id}_{$index}";
+			$name  = "User {$index}";
 
 			$user_id = wp_insert_user(
 				[
@@ -612,7 +612,7 @@ public function generate( $args, $assoc_args ) {
 				$notify->tick();
 			} elseif ( 'ids' === $format ) {
 				echo $user_id;
-				if ( $i < $limit - 1 ) {
+				if ( $index < $limit - 1 ) {
 					echo ' ';
 				}
 			}
@@ -953,7 +953,7 @@ public function import_csv( $args, $assoc_args ) {
 			$csv_data = new CsvIterator( $filename );
 		}
 
-		foreach ( $csv_data as $i => $new_user ) {
+		foreach ( $csv_data as $new_user ) {
 			$defaults = [
 				'role'            => get_option( 'default_role' ),
 				'user_pass'       => wp_generate_password(),

src/WP_CLI/CommandWithTerms.php

@@ -313,7 +313,7 @@ protected function taxonomy_exists( $taxonomy ) {
 	protected function prepare_terms( $field, $terms, $taxonomy ) {
 		if ( 'id' === $field ) {
 			$new_terms = [];
-			foreach ( $terms as $i => $term_id ) {
+			foreach ( $terms as $term_id ) {
 				$term = get_term_by( 'term_id', $term_id, $taxonomy );
 				if ( $term ) {
 					$new_terms[] = $term->slug;