Skip to content

Commit 3e480f4

Browse files
author
Jonny Harris
committed
Remove delete all param of meta data api.
1 parent 5684cbc commit 3e480f4

File tree

5 files changed

+10
-35
lines changed

5 files changed

+10
-35
lines changed

‎src/Comment_Meta_Command.php‎

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -91,16 +91,11 @@ protected function get_metadata( $object_id, $meta_key = '', $single = false ) {
9191
* this check. For backward compatibility, it is
9292
* not possible to pass an empty string to delete
9393
* those entries with an empty string for a value.
94-
* @param bool $delete_all Optional, default is false. If true, delete
95-
* matching metadata entries for all objects,
96-
* ignoring the specified object_id. Otherwise,
97-
* only delete matching metadata entries for the
98-
* specified object_id.
9994
*
10095
* @return bool True on successful delete, false on failure.
10196
*/
102-
protected function delete_metadata( $object_id, $meta_key, $meta_value = '', $delete_all = false ) {
103-
return delete_comment_meta( $object_id, $meta_key, $meta_value, $delete_all );
97+
protected function delete_metadata( $object_id, $meta_key, $meta_value = '' ) {
98+
return delete_comment_meta( $object_id, $meta_key, $meta_value );
10499
}
105100

106101
/**

‎src/Post_Meta_Command.php‎

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -102,15 +102,10 @@ protected function get_metadata( $object_id, $meta_key = '', $single = false ) {
102102
* this check. For backward compatibility, it is
103103
* not possible to pass an empty string to delete
104104
* those entries with an empty string for a value.
105-
* @param bool $delete_all Optional, default is false. If true, delete
106-
* matching metadata entries for all objects,
107-
* ignoring the specified object_id. Otherwise,
108-
* only delete matching metadata entries for the
109-
* specified object_id.
110105
*
111106
* @return bool True on successful delete, false on failure.
112107
*/
113-
protected function delete_metadata( $object_id, $meta_key, $meta_value = '', $delete_all = false ) {
114-
return delete_post_meta( $object_id, $meta_key, $meta_value, $delete_all );
108+
protected function delete_metadata( $object_id, $meta_key, $meta_value = '' ) {
109+
return delete_post_meta( $object_id, $meta_key, $meta_value );
115110
}
116111
}

‎src/Term_Meta_Command.php‎

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -104,15 +104,10 @@ protected function get_metadata( $object_id, $meta_key = '', $single = false ) {
104104
* this check. For backward compatibility, it is
105105
* not possible to pass an empty string to delete
106106
* those entries with an empty string for a value.
107-
* @param bool $delete_all Optional, default is false. If true, delete
108-
* matching metadata entries for all objects,
109-
* ignoring the specified object_id. Otherwise,
110-
* only delete matching metadata entries for the
111-
* specified object_id.
112107
*
113108
* @return bool True on successful delete, false on failure.
114109
*/
115-
protected function delete_metadata( $object_id, $meta_key, $meta_value = '', $delete_all = false ) {
116-
return delete_term_meta( $object_id, $meta_key, $meta_value, $delete_all );
110+
protected function delete_metadata( $object_id, $meta_key, $meta_value = '' ) {
111+
return delete_term_meta( $object_id, $meta_key, $meta_value );
117112
}
118113
}

‎src/User_Meta_Command.php‎

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -293,16 +293,11 @@ protected function get_metadata( $object_id, $meta_key = '', $single = false ) {
293293
* this check. For backward compatibility, it is
294294
* not possible to pass an empty string to delete
295295
* those entries with an empty string for a value.
296-
* @param bool $delete_all Optional, default is false. If true, delete
297-
* matching metadata entries for all objects,
298-
* ignoring the specified object_id. Otherwise,
299-
* only delete matching metadata entries for the
300-
* specified object_id.
301296
*
302297
* @return bool True on successful delete, false on failure.
303298
*/
304-
protected function delete_metadata( $object_id, $meta_key, $meta_value = '', $delete_all = false ) {
305-
return delete_user_meta( $object_id, $meta_key, $meta_value, $delete_all );
299+
protected function delete_metadata( $object_id, $meta_key, $meta_value = '' ) {
300+
return delete_user_meta( $object_id, $meta_key, $meta_value );
306301
}
307302

308303
/**

‎src/WP_CLI/CommandWithMeta.php‎

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -501,16 +501,11 @@ protected function get_metadata( $object_id, $meta_key = '', $single = false ) {
501501
* this check. For backward compatibility, it is
502502
* not possible to pass an empty string to delete
503503
* those entries with an empty string for a value.
504-
* @param bool $delete_all Optional, default is false. If true, delete
505-
* matching metadata entries for all objects,
506-
* ignoring the specified object_id. Otherwise,
507-
* only delete matching metadata entries for the
508-
* specified object_id.
509504
*
510505
* @return bool True on successful delete, false on failure.
511506
*/
512-
protected function delete_metadata( $object_id, $meta_key, $meta_value = '', $delete_all = false ) {
513-
return delete_metadata( $this->meta_type, $object_id, $meta_key, $meta_value, $delete_all );
507+
protected function delete_metadata( $object_id, $meta_key, $meta_value = '' ) {
508+
return delete_metadata( $this->meta_type, $object_id, $meta_key, $meta_value, false );
514509
}
515510

516511
/**

0 commit comments

Comments
 (0)