Warn when an invalid role is provided for wp user update (#406)

* Added the Invalid role check for the wp user update command

* - Used validate_role() function to validate the role.
- Added $warn_user_only parameter in the validate_role() function.

* - Functional test added

* - Functional test for right scenario added

* - Setting up the user before testing.

* - Functional test added for the wp user update and assertion added for the admin role

Author: SH4LIN

features/user.feature

@@ -239,6 +239,26 @@ Feature: Manage WordPress users
       | Field | Value |
       | roles |       |
 
+  Scenario: Invalid User Role
+    Given a WP install
+    When I run `wp user create testuser4 testemail4@example.com`
+    And I try `wp user update testuser4 --role=banana`
+    Then STDERR should be:
+      """
+      Warning: Role doesn't exist: banana
+      """
+    And STDOUT should contain:
+      """
+      Success:
+      """
+    And the return code should be 0
+
+    When I run `wp user get admin --field=roles`
+    Then STDOUT should be:
+      """
+      administrator
+      """
+
   Scenario: Managing user capabilities
     Given a WP install
 

src/User_Command.php

@@ -529,6 +529,10 @@ public function update( $args, $assoc_args ) {
 			unset( $assoc_args['user_login'] );
 		}
 
+		if ( isset( $assoc_args['role'] ) ) {
+			self::validate_role( $assoc_args['role'], true );
+		}
+
 		$user_ids = [];
 		foreach ( $this->fetcher->get_many( $args ) as $user ) {
 			$user_ids[] = $user->ID;
@@ -1156,12 +1160,17 @@ public function reset_password( $args, $assoc_args ) {
 	/**
 	 * Checks whether the role is valid
 	 *
-	 * @param string
+	 * @param $role string
+	 * @param $warn_user_only bool
 	 */
-	private static function validate_role( $role ) {
+	private static function validate_role( $role, $warn_user_only = false ) {
 
 		if ( ! empty( $role ) && null === get_role( $role ) ) {
-			WP_CLI::error( "Role doesn't exist: {$role}" );
+			if ( $warn_user_only ) {
+				WP_CLI::warning( "Role doesn't exist: {$role}" );
+			} else {
+				WP_CLI::error( "Role doesn't exist: {$role}" );
+			}
 		}
 
 	}