Remove unused code

Author: schlessera

src/Comment_Command.php

@@ -334,7 +334,7 @@ public function get( $args, $assoc_args ) {
 	 *
 	 * @subcommand list
 	 */
-	public function list_( $_, $assoc_args ) {
+	public function list_( $args, $assoc_args ) {
 		$formatter = $this->get_formatter( $assoc_args );
 
 		if ( 'ids' === $formatter->format ) {

src/Menu_Command.php

@@ -91,7 +91,7 @@ public function create( $args, $assoc_args ) {
 	 *     $ wp menu delete "My Menu"
 	 *     Success: 1 menu deleted.
 	 */
-	public function delete( $args, $_ ) {
+	public function delete( $args, $assoc_args ) {
 
 		$count  = 0;
 		$errors = 0;
@@ -160,7 +160,7 @@ public function delete( $args, $_ ) {
 	 *
 	 * @subcommand list
 	 */
-	public function list_( $_, $assoc_args ) {
+	public function list_( $args, $assoc_args ) {
 
 		$menus = wp_get_nav_menus();
 

src/Menu_Item_Command.php

@@ -99,7 +99,7 @@ public function list_( $args, $assoc_args ) {
 		// Correct position inconsistency and
 		// protected `url` param in WP-CLI
 		$items = array_map(
-			function( $item ) use ( $assoc_args ) {
+			function( $item ) {
 					$item->position = $item->menu_order;
 					$item->link     = $item->url;
 					return $item;
@@ -361,7 +361,7 @@ public function update( $args, $assoc_args ) {
 	 *
 	 * @subcommand delete
 	 */
-	public function delete( $args, $_ ) {
+	public function delete( $args, $assoc_args ) {
 		global $wpdb;
 
 		$count  = 0;

src/Menu_Location_Command.php

@@ -64,7 +64,7 @@ class Menu_Location_Command extends WP_CLI_Command {
 	 *
 	 * @subcommand list
 	 */
-	public function list_( $_, $assoc_args ) {
+	public function list_( $args, $assoc_args ) {
 
 		$locations     = get_registered_nav_menus();
 		$location_objs = [];
@@ -108,7 +108,7 @@ function( $o ) {
 	 *
 	 * @subcommand assign
 	 */
-	public function assign( $args, $_ ) {
+	public function assign( $args, $assoc_args ) {
 
 		list( $menu, $location ) = $args;
 
@@ -148,7 +148,7 @@ public function assign( $args, $_ ) {
 	 *
 	 * @subcommand remove
 	 */
-	public function remove( $args, $_ ) {
+	public function remove( $args, $assoc_args ) {
 
 		list( $menu, $location ) = $args;
 

src/Option_Command.php

@@ -248,7 +248,6 @@ public function list_( $args, $assoc_args ) {
 		$fields         = array( 'option_name', 'option_value' );
 		$size_query     = ',LENGTH(option_value) AS `size_bytes`';
 		$autoload_query = '';
-		$sort           = Utils\get_flag_value( $assoc_args, 'order' );
 
 		if ( isset( $assoc_args['search'] ) ) {
 			$pattern = self::esc_like( $assoc_args['search'] );
@@ -285,7 +284,6 @@ public function list_( $args, $assoc_args ) {
 		// By default we don't want to display transients.
 		$show_transients = Utils\get_flag_value( $assoc_args, 'transients', false );
 
-		$transients_query = '';
 		if ( $show_transients ) {
 			$transients_query = " AND option_name LIKE '\_transient\_%'
 			OR option_name LIKE '\_site\_transient\_%'";

src/Post_Command.php

@@ -370,7 +370,7 @@ function ( $params ) {
 	 *     # Launch system editor to edit post
 	 *     $ wp post edit 123
 	 */
-	public function edit( $args, $_ ) {
+	public function edit( $args, $assoc_args ) {
 		$post = $this->fetcher->get_check( $args[0] );
 
 		$result = $this->_edit( $post->post_content, "WP-CLI post {$post->ID}" );
@@ -600,7 +600,7 @@ protected function delete_callback( $post_id, $assoc_args ) {
 	 *
 	 * @subcommand list
 	 */
-	public function list_( $_, $assoc_args ) {
+	public function list_( $args, $assoc_args ) {
 		$formatter = $this->get_formatter( $assoc_args );
 
 		$defaults   = [

src/Site_Command.php

@@ -89,11 +89,9 @@ private function empty_taxonomies() {
 
 		// Empty taxonomies and terms
 		$terms      = $wpdb->get_results( "SELECT term_id, taxonomy FROM $wpdb->term_taxonomy" );
-		$ids        = [];
 		$taxonomies = [];
 		foreach ( (array) $terms as $term ) {
 			$taxonomies[] = $term->taxonomy;
-			$ids[]        = $term->term_id;
 			wp_cache_delete( $term->term_id, $term->taxonomy );
 		}
 
@@ -354,7 +352,7 @@ public function delete( $args, $assoc_args ) {
 	 *     $ wp site create --slug=example
 	 *     Success: Site 3 created: http://www.example.com/example/
 	 */
-	public function create( $_, $assoc_args ) {
+	public function create( $args, $assoc_args ) {
 		if ( ! is_multisite() ) {
 			WP_CLI::error( 'This is not a multisite installation.' );
 		}
@@ -412,11 +410,9 @@ public function create( $_, $assoc_args ) {
 		if ( is_subdomain_install() ) {
 			$newdomain = $base . '.' . preg_replace( '|^www\.|', '', $current_site->domain );
 			$path      = $current_site->path;
-			$url       = $newdomain;
 		} else {
 			$newdomain = $current_site->domain;
 			$path      = $current_site->path . $base . '/';
-			$url       = $newdomain . $path;
 		}
 
 		$user_id = email_exists( $email );
@@ -539,7 +535,7 @@ private function get_network( $network_id ) {
 	 *
 	 * @subcommand list
 	 */
-	public function list_( $_, $assoc_args ) {
+	public function list_( $args, $assoc_args ) {
 		if ( ! is_multisite() ) {
 			WP_CLI::error( 'This is not a multisite installation.' );
 		}

src/Term_Command.php

@@ -365,8 +365,6 @@ public function update( $args, $assoc_args ) {
 
 		$assoc_args = wp_slash( $assoc_args );
 
-		list( $taxonomy, $term ) = $args;
-
 		$term = get_term_by( Utils\get_flag_value( $assoc_args, 'by' ), $term, $taxonomy );
 
 		if ( ! $term ) {
@@ -677,8 +675,6 @@ public function recount( $args ) {
 	 *     Success: Migrated the term '9190' from taxonomy 'category' to taxonomy 'post_tag' for 1 posts
 	 */
 	public function migrate( $args, $assoc_args ) {
-		$clean_term_cache     = [];
-		$values               = [];
 		$term_reference       = $args[0];
 		$original_taxonomy    = Utils\get_flag_value( $assoc_args, 'from' );
 		$destination_taxonomy = Utils\get_flag_value( $assoc_args, 'to' );

src/WP_CLI/CommandWithDBObject.php

@@ -27,7 +27,7 @@ abstract class CommandWithDBObject extends WP_CLI_Command {
 	/**
 	 * @var array $obj_fields Default fields to display for each object.
 	 */
-	protected $obj_fields = null;
+	protected $obj_fields;
 
 	/**
 	 * Create a given database object.