Accept multiple signups in activate command

Author: ernilambar

features/signup.feature

@@ -45,61 +45,78 @@ Feature: Manage signups in a multisite installation
 		Given a WP multisite install
 		And I run `wp eval 'wpmu_signup_user( "bobuser", "[email protected]" );'`
 
+		When I run `wp signup get 1 --field=user_login`
+		Then STDOUT should be:
+			"""
+			bobuser
+			"""
+
 		When I run `wp signup get bobuser --fields=signup_id,user_login,user_email,active --format=csv`
 		Then STDOUT should be:
 			"""
 			signup_id,user_login,user_email,active
 			1,bobuser,[email protected],0
 			"""
 
-	Scenario: Delete signup
+	Scenario: Activate signup
 		Given a WP multisite install
+		And I run `wp eval 'wpmu_signup_user( "bobuser", "[email protected]" );'`
 
-		When I run `wp eval 'wpmu_signup_user( "bobuser", "[email protected]" );'`
-		And I run `wp signup get bobuser --field=user_login`
+		When I run `wp signup get bobuser --field=active`
 		Then STDOUT should be:
 			"""
-			bobuser
+			0
 			"""
 
-		When I run `wp signup delete bobuser@example.com`
-		Then STDOUT should be:
+		When I run `wp signup activate bobuser`
+		Then STDOUT should contain:
 			"""
-			Success: Signup 1 deleted.
+			Success: Signup 1 activated.
 			"""
 
-		When I try `wp signup get bobuser`
+		When I try the previous command again
 		Then STDERR should be:
 			"""
-			Error: Invalid signup ID, email, login, or activation key: 'bobuser'
+			Warning: Failed activating signup 1.
 			"""
 
-	Scenario: Activate signup
+		When I run `wp signup get bobuser --field=active`
+		Then STDOUT should be:
+			"""
+			1
+			"""
+
+		When I run `wp user get bobuser --field=user_email`
+		Then STDOUT should be:
+			"""
+			[email protected]
+			"""
+
+	Scenario: Activate multiple signups
 		Given a WP multisite install
 		And I run `wp eval 'wpmu_signup_user( "bobuser", "[email protected]" );'`
+    And I run `wp eval 'wpmu_signup_user( "johnuser", "[email protected]" );'`
 
-		And I run `wp signup get bobuser --field=active`
+		When I run `wp signup list --active=0 --format=count`
 		Then STDOUT should be:
 			"""
-			0
+			2
 			"""
 
-		When I run `wp signup activate bobuser`
+		When I run `wp signup activate bobuser johnuser`
 		Then STDOUT should contain:
 			"""
 			Success: Signup 1 activated.
 			"""
-
-		When I run `wp signup get bobuser --field=active`
-		Then STDOUT should be:
+		And STDOUT should contain:
 			"""
-			1
+			Success: Signup 2 activated.
 			"""
 
-		When I run `wp user get bobuser --field=user_email`
+		When I run `wp signup list --active=1 --format=count`
 		Then STDOUT should be:
 			"""
-			[email protected]
+			2
 			"""
 
 	Scenario: Activate blog signup entry
@@ -124,3 +141,33 @@ Feature: Manage signups in a multisite installation
 			| domain      | path      |
 			| example.com | /         |
 			| example.com | /bobsite/ |
+
+	Scenario: Delete signups
+		Given a WP multisite install
+		And I run `wp eval 'wpmu_signup_user( "bobuser", "[email protected]" );'`
+		And I run `wp eval 'wpmu_signup_user( "johnuser", "[email protected]" );'`
+
+		When I run `wp signup get bobuser --field=user_email`
+		Then STDOUT should be:
+			"""
+			[email protected]
+			"""
+
+		When I run `wp signup get johnuser --field=user_email`
+		Then STDOUT should be:
+			"""
+			[email protected]
+			"""
+
+		When I run `wp signup delete bobuser@example.com johnuser@example.com`
+		Then STDOUT should be:
+			"""
+			Success: Signup 1 deleted.
+			Success: Signup 2 deleted.
+			"""
+
+		When I try `wp signup get bobuser`
+		Then STDERR should be:
+			"""
+			Error: Invalid signup ID, email, login, or activation key: 'bobuser'
+			"""

src/Signup_Command.php

@@ -198,12 +198,12 @@ public function get( $args, $assoc_args ) {
 	}
 
 	/**
-	 * Activates a signup.
+	 * Activates one or more signups.
 	 *
 	 * ## OPTIONS
 	 *
-	 * <signup>
-	 * : Signup ID, user login, user email, or activation key.
+	 * <signup>...
+	 * : Signup ID, user login, user email, or activation key of the signup(s) to activate.
 	 *
 	 * ## EXAMPLES
 	 *
@@ -214,16 +214,16 @@ public function get( $args, $assoc_args ) {
 	 * @package wp-cli
 	 */
 	public function activate( $args, $assoc_args ) {
-		$signup = $this->fetcher->get_check( $args[0] );
+		$signups = $this->fetcher->get_many( $args );
 
-		if ( $signup ) {
+		foreach ( $signups as $signup ) {
 			$result = wpmu_activate_signup( $signup->activation_key );
-		}
 
-		if ( is_wp_error( $result ) ) {
-			WP_CLI::error( "Failed activating signup {$signup->signup_id}." );
-		} else {
-			WP_CLI::success( "Signup {$signup->signup_id} activated. Password: {$result['password']}" );
+			if ( is_wp_error( $result ) ) {
+				WP_CLI::warning( "Failed activating signup {$signup->signup_id}." );
+			} else {
+				WP_CLI::success( "Signup {$signup->signup_id} activated. Password: {$result['password']}" );
+			}
 		}
 	}