Avoid unneeded empty check, flags return booleans

schlessera · schlessera · commit 7bca56cfd123 · 2018-12-04T00:37:15.000+01:00
diff --git a/src/Post_Command.php b/src/Post_Command.php
@@ -713,9 +713,9 @@ public function generate( $args, $assoc_args ) {
 			$post_author = $user_fetcher->get_check( $post_author )->ID;
 		}
 
-		if ( !empty( \WP_CLI\Utils\get_flag_value( $assoc_args, 'post_content' ) ) ) {
-			if ( !\WP_CLI\Entity\Utils::has_stdin() ) {
-				WP_CLI::error( "The parameter `post_content` reads from STDIN." );
+		if ( \WP_CLI\Utils\get_flag_value( $assoc_args, 'post_content' ) ) {
+			if ( ! \WP_CLI\Entity\Utils::has_stdin() ) {
+				WP_CLI::error( 'The parameter `post_content` reads from STDIN.' );
 			}
 
 			$post_content = file_get_contents( 'php://stdin' );

Original file line number	Diff line number	Diff line change
`@@ -713,9 +713,9 @@ public function generate( $args, $assoc_args ) {`
`713`	`713`	`$post_author = $user_fetcher->get_check( $post_author )->ID;`
`714`	`714`	`}`
`715`	`715`
`716`		`- if ( !empty( \WP_CLI\Utils\get_flag_value( $assoc_args, 'post_content' ) ) ) {`
`717`		`- if ( !\WP_CLI\Entity\Utils::has_stdin() ) {`
`718`		- WP_CLI::error( "The parameter `post_content` reads from STDIN." );
	`716`	`+ if ( \WP_CLI\Utils\get_flag_value( $assoc_args, 'post_content' ) ) {`
	`717`	`+ if ( ! \WP_CLI\Entity\Utils::has_stdin() ) {`
	`718`	+ WP_CLI::error( 'The parameter `post_content` reads from STDIN.' );
`719`	`719`	`}`
`720`	`720`
`721`	`721`	`$post_content = file_get_contents( 'php://stdin' );`