Merge pull request #527 from karthick-murugan/wpcli/user-update-command

Ensure wp user update Returns Non-Zero Exit Code for Invalid Users

Author: mrsdizzie

features/user.feature

@@ -147,6 +147,13 @@ Feature: Manage WordPress users
       3
       """
 
+    When I try `wp user update 9999 --user_pass=securepassword`
+    Then the return code should be 1
+    And STDERR should contain:
+      """
+      Error: No valid users found.
+      """
+
   Scenario: Delete user with invalid reassign
     Given a WP install
     And a session_no file:

src/User_Command.php

@@ -545,6 +545,10 @@ public function update( $args, $assoc_args ) {
 			$user_ids[] = $user->ID;
 		}
 
+		if ( empty( $user_ids ) ) {
+			WP_CLI::error( 'No valid users found.' );
+		}
+
 		$skip_email = Utils\get_flag_value( $assoc_args, 'skip-email' );
 		if ( $skip_email ) {
 			add_filter( 'send_email_change_email', '__return_false' );