rewriting to optimize

Author: Mte90

features/post-generate.feature

@@ -12,6 +12,12 @@ Feature: Generate new WordPress posts
       """
     And STDERR should be empty
 
+    When I try `wp post generate --count=1 --post_content`
+    Then STDERR should contain:
+      """
+      Error: The parameter `post_content` reads from STDIN.
+      """
+
   Scenario: Generating posts by a specific author
 
     When I run `wp user create dummyuser dummy@example.com --porcelain`

src/Post_Command.php

@@ -711,10 +711,10 @@ public function generate( $args, $assoc_args ) {
 		}
 
 		if ( !empty( \WP_CLI\Utils\get_flag_value( $assoc_args, 'post_content' ) ) ) {
-			WP_CLI::error( "The parameter `post_content` reads from STDIN." );
-		}
-		
-		if ( \WP_CLI\Entity\Utils::has_stdin() && \WP_CLI\Utils\get_flag_value( $assoc_args, 'post_content' ) ) {
+			if ( !\WP_CLI\Entity\Utils::has_stdin() ) {
+				WP_CLI::error( "The parameter `post_content` reads from STDIN." );
+			}
+
 			$post_content = file_get_contents( 'php://stdin' );
 		}