Skip to content

Commit c54664c

Browse files
schlesseraschlessera
authored
Merge pull request #215 from BhargavBhandari90/Issue-GH-190
Harmonize representation of serialized and JSON-encoded meta values
2 parents 4f4992f + 96a6cf5 commit c54664c

File tree

4 files changed

+68
-51
lines changed

4 files changed

+68
-51
lines changed

‎features/comment-meta.feature‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,3 +56,21 @@ Feature: Manage comment custom fields
5656
"""
5757
-- hi
5858
"""
59+
60+
Scenario: List comment meta
61+
Given a WP install
62+
63+
When I run `wp comment meta add 1 apple banana`
64+
And I run `wp comment meta add 1 apple banana`
65+
Then STDOUT should not be empty
66+
67+
When I run `wp comment meta set 1 banana '["apple", "apple"]' --format=json`
68+
Then STDOUT should not be empty
69+
70+
When I run `wp comment meta list 1`
71+
Then STDOUT should be a table containing rows:
72+
| comment_id | meta_key | meta_value |
73+
| 1 | apple | banana |
74+
| 1 | apple | banana |
75+
| 1 | banana | a:2:{i:0;s:5:"apple";i:1;s:5:"apple";} |
76+

‎features/post-meta.feature‎

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -59,45 +59,45 @@ Feature: Manage post custom fields
5959

6060
When I run `wp post meta list 1`
6161
Then STDOUT should be a table containing rows:
62-
| post_id | meta_key | meta_value |
63-
| 1 | apple | banana |
64-
| 1 | apple | banana |
65-
| 1 | banana | ["apple","apple"] |
62+
| post_id | meta_key | meta_value |
63+
| 1 | apple | banana |
64+
| 1 | apple | banana |
65+
| 1 | banana | a:2:{i:0;s:5:"apple";i:1;s:5:"apple";} |
6666

6767
When I run `wp post meta list 1 --orderby=id --order=desc`
6868
Then STDOUT should be a table containing rows:
69-
| post_id | meta_key | meta_value |
70-
| 1 | banana | ["apple","apple"] |
71-
| 1 | apple | banana |
72-
| 1 | apple | banana |
69+
| post_id | meta_key | meta_value |
70+
| 1 | banana | a:2:{i:0;s:5:"apple";i:1;s:5:"apple";} |
71+
| 1 | apple | banana |
72+
| 1 | apple | banana |
7373

7474
When I run `wp post meta list 1 --orderby=meta_key --order=asc`
7575
Then STDOUT should be a table containing rows:
76-
| post_id | meta_key | meta_value |
77-
| 1 | apple | banana |
78-
| 1 | apple | banana |
79-
| 1 | banana | ["apple","apple"] |
76+
| post_id | meta_key | meta_value |
77+
| 1 | apple | banana |
78+
| 1 | apple | banana |
79+
| 1 | banana | a:2:{i:0;s:5:"apple";i:1;s:5:"apple";} |
8080

8181
When I run `wp post meta list 1 --orderby=meta_key --order=desc`
8282
Then STDOUT should be a table containing rows:
83-
| post_id | meta_key | meta_value |
84-
| 1 | banana | ["apple","apple"] |
85-
| 1 | apple | banana |
86-
| 1 | apple | banana |
83+
| post_id | meta_key | meta_value |
84+
| 1 | banana | a:2:{i:0;s:5:"apple";i:1;s:5:"apple";} |
85+
| 1 | apple | banana |
86+
| 1 | apple | banana |
8787

8888
When I run `wp post meta list 1 --orderby=meta_value --order=asc`
8989
Then STDOUT should be a table containing rows:
90-
| post_id | meta_key | meta_value |
91-
| 1 | apple | banana |
92-
| 1 | apple | banana |
93-
| 1 | banana | ["apple","apple"] |
90+
| post_id | meta_key | meta_value |
91+
| 1 | apple | banana |
92+
| 1 | apple | banana |
93+
| 1 | banana | a:2:{i:0;s:5:"apple";i:1;s:5:"apple";} |
9494

9595
When I run `wp post meta list 1 --orderby=meta_value --order=desc`
9696
Then STDOUT should be a table containing rows:
97-
| post_id | meta_key | meta_value |
98-
| 1 | banana | ["apple","apple"] |
99-
| 1 | apple | banana |
100-
| 1 | apple | banana |
97+
| post_id | meta_key | meta_value |
98+
| 1 | banana | a:2:{i:0;s:5:"apple";i:1;s:5:"apple";} |
99+
| 1 | apple | banana |
100+
| 1 | apple | banana |
101101

102102
Scenario: Delete all post meta
103103
Given a WP install

‎features/user-meta.feature‎

Lines changed: 26 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -62,56 +62,57 @@ Feature: Manage user custom fields
6262
When I run `wp user meta list 1 --format=json --keys=nickname,foo --fields=meta_key,meta_value`
6363
Then STDOUT should be JSON containing:
6464
"""
65-
[{"meta_key":"nickname","meta_value":"admin"},{"meta_key":"foo","meta_value":["1","2"]}]
65+
[{"meta_key":"nickname","meta_value":"admin"},{"meta_key":"foo","meta_value":"a:2:{i:0;s:1:\"1\";i:1;s:1:\"2\";}"}]
6666
"""
6767

6868
When I run `wp user meta list 1 --keys=nickname,foo`
6969
Then STDOUT should be a table containing rows:
70-
| user_id | meta_key | meta_value |
71-
| 1 | nickname | admin |
72-
| 1 | foo | ["1","2"] |
70+
| user_id | meta_key | meta_value |
71+
| 1 | nickname | admin |
72+
| 1 | foo | a:2:{i:0;s:1:"1";i:1;s:1:"2";} |
7373

7474
When I run `wp user meta list admin --keys=nickname,foo`
7575
Then STDOUT should be a table containing rows:
76-
| user_id | meta_key | meta_value |
77-
| 1 | nickname | admin |
78-
| 1 | foo | ["1","2"] |
76+
| user_id | meta_key | meta_value |
77+
| 1 | nickname | admin |
78+
| 1 | foo | a:2:{i:0;s:1:"1";i:1;s:1:"2";} |
7979

8080
When I run `wp user meta list admin --keys=nickname,foo --orderby=id --order=asc`
8181
Then STDOUT should be a table containing rows:
82-
| user_id | meta_key | meta_value |
83-
| 1 | nickname | admin |
84-
| 1 | foo | ["1","2"] |
82+
| user_id | meta_key | meta_value |
83+
| 1 | nickname | admin |
84+
| 1 | foo | a:2:{i:0;s:1:"1";i:1;s:1:"2";} |
8585

8686
When I run `wp user meta list admin --keys=nickname,foo --orderby=id --order=desc`
8787
Then STDOUT should be a table containing rows:
88-
| user_id | meta_key | meta_value |
89-
| 1 | foo | ["1","2"] |
90-
| 1 | nickname | admin |
88+
| user_id | meta_key | meta_value |
89+
| 1 | foo | a:2:{i:0;s:1:"1";i:1;s:1:"2";} |
90+
| 1 | nickname | admin |
9191

9292
When I run `wp user meta list admin --keys=nickname,foo --orderby=meta_key --order=asc`
9393
Then STDOUT should be a table containing rows:
94-
| user_id | meta_key | meta_value |
95-
| 1 | foo | ["1","2"] |
96-
| 1 | nickname | admin |
94+
| user_id | meta_key | meta_value |
95+
| 1 | foo | a:2:{i:0;s:1:"1";i:1;s:1:"2";} |
96+
| 1 | nickname | admin |
9797

9898
When I run `wp user meta list admin --keys=nickname,foo --orderby=meta_key --order=desc`
9999
Then STDOUT should be a table containing rows:
100-
| user_id | meta_key | meta_value |
101-
| 1 | nickname | admin |
102-
| 1 | foo | ["1","2"] |
100+
| user_id | meta_key | meta_value |
101+
| 1 | nickname | admin |
102+
| 1 | foo | a:2:{i:0;s:1:"1";i:1;s:1:"2";} |
103103

104104
When I run `wp user meta list admin --keys=nickname,foo --orderby=meta_value --order=asc`
105105
Then STDOUT should be a table containing rows:
106-
| user_id | meta_key | meta_value |
107-
| 1 | nickname | admin |
108-
| 1 | foo | ["1","2"] |
106+
| user_id | meta_key | meta_value |
107+
| 1 | nickname | admin |
108+
| 1 | foo | a:2:{i:0;s:1:"1";i:1;s:1:"2";} |
109109

110110
When I run `wp user meta list admin --keys=nickname,foo --orderby=meta_value --order=desc`
111111
Then STDOUT should be a table containing rows:
112-
| user_id | meta_key | meta_value |
113-
| 1 | foo | ["1","2"] |
114-
| 1 | nickname | admin |
112+
| user_id | meta_key | meta_value |
113+
| 1 | foo | a:2:{i:0;s:1:"1";i:1;s:1:"2";} |
114+
| 1 | nickname | admin |
115+
115116

116117
Scenario: Get particular user meta
117118
Given a WP install

‎src/WP_CLI/CommandWithMeta.php‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,6 @@ public function list_( $args, $assoc_args ) {
8484

8585
foreach( $values as $item_value ) {
8686

87-
$item_value = maybe_unserialize( $item_value );
88-
8987
$items[] = (object) array(
9088
"{$this->meta_type}_id" => $object_id,
9189
'meta_key' => $key,

0 commit comments

Comments
 (0)