update post 'create/update'

update code and fix tests

Author: thrijith

features/post.feature

@@ -29,6 +29,28 @@ Feature: Manage WordPress posts
     When I try the previous command again
     Then the return code should be 1
 
+    When I run `wp term create category "First Category" --porcelain`
+    And save STDOUT as {TERM_ID}
+    And I run `wp term create category "Second Category" --porcelain`
+    And save STDOUT as {SECOND_TERM_ID}
+
+    When I run `wp post create --post_title="Test category" --post_category="First Category" --porcelain`
+    Then STDOUT should be a number
+    And save STDOUT as {POST_ID}
+
+    When I run `wp post update {POST_ID} --post_category={SECOND_TERM_ID}`
+    Then STDOUT should be:
+      """
+      Success: Updated post {POST_ID}.
+      """
+
+    When I run `wp post update {POST_ID} --post_category=test --porcelain`
+    Then STDOUT should be:
+      """
+      Warning: Unable to set test as post category
+      Success: Updated post {POST_ID}.
+      """
+
   Scenario: Creating/getting/editing posts
     Given a content.html file:
       """

src/Post_Command.php

@@ -159,13 +159,7 @@ public function create( $args, $assoc_args ) {
 		}
 
 		if ( isset( $assoc_args['post_category'] ) ) {
-			$assoc_args['post_category'] = explode( ',', $assoc_args['post_category'] );
-			foreach ( $assoc_args['post_category'] as $post_category ) {
-				$post_category = ( true === is_numeric( $post_category ) ) ? intval( $post_category ) : $post_category;
-				$category_id = category_exists( $post_category );
-				$category_ids[] = ( null !== $category_id ? $category_id : $post_category );
-			}
-			$assoc_args['post_category'] = $category_ids;
+			$assoc_args['post_category'] = $this->get_category_ids( $assoc_args['post_category'] );
 		}
 
 		$assoc_args = wp_slash( $assoc_args );
@@ -288,13 +282,7 @@ public function update( $args, $assoc_args ) {
 		}
 
 		if ( isset( $assoc_args['post_category'] ) ) {
-			$assoc_args['post_category'] = explode( ',', $assoc_args['post_category'] );
-			foreach ( $assoc_args['post_category'] as $post_category ) {
-				$post_category = ( true === is_numeric( $post_category ) ) ? intval( $post_category ) : $post_category;
-				$category_id = category_exists( $post_category );
-				$category_ids[] = ( null !== $category_id ? $category_id : $post_category );
-			}
-			$assoc_args['post_category'] = $category_ids;
+			$assoc_args['post_category'] = $this->get_category_ids( $assoc_args['post_category'] );
 		}
 
 		$assoc_args = wp_slash( $assoc_args );
@@ -760,4 +748,27 @@ private function read_from_file_or_stdin( $arg ) {
 		}
 		return file_get_contents( $readfile );
 	}
+
+	/**
+	 * Get category id if given name/slug
+	 *
+	 * @param string $arg Supplied argument.
+	 * @return array
+	 */
+	private function get_category_ids( $arg ) {
+		$categoires = explode( ',', $arg );
+
+		foreach ( $categoires as $post_category ) {
+			$post_category = ( true === is_numeric( $post_category ) ) ? intval( $post_category ) : $post_category;
+
+			$category_id    = category_exists( $post_category );
+			if ( null === $category_id ) {
+				$category_ids[] = $post_category;
+				WP_CLI::warning( "Unable to set $post_category as post category" );
+			} else {
+				$category_ids[] = $category_id;
+			}
+		}
+		return $category_ids;
+	}
 }