Fix typing bug in site management code

schlessera · schlessera · commit f33cacc40da6 · 2019-04-23T11:58:00.000+02:00
diff --git a/src/Site_Command.php b/src/Site_Command.php
@@ -775,6 +775,8 @@ public function set_private( $args ) {
 	}
 
 	private function update_site_status( $ids, $pref, $value ) {
+		$value = (int) $value;
+
 		switch ( $pref ) {
 			case 'archived':
 				$action = $value ? 'archived' : 'unarchived';
@@ -801,7 +803,7 @@ private function update_site_status( $ids, $pref, $value ) {
 				continue;
 			}
 
-			$old_value = get_blog_status( $site->blog_id, $pref );
+			$old_value = (int) get_blog_status( $site->blog_id, $pref );
 
 			if ( $value === $old_value ) {
 				WP_CLI::warning( "Site {$site->blog_id} already {$action}." );

Original file line number	Diff line number	Diff line change
`@@ -775,6 +775,8 @@ public function set_private( $args ) {`
`775`	`775`	`}`
`776`	`776`
`777`	`777`	`private function update_site_status( $ids, $pref, $value ) {`
	`778`	`+ $value = (int) $value;`
	`779`	`+`
`778`	`780`	`switch ( $pref ) {`
`779`	`781`	`case 'archived':`
`780`	`782`	`$action = $value ? 'archived' : 'unarchived';`
`@@ -801,7 +803,7 @@ private function update_site_status( $ids, $pref, $value ) {`
`801`	`803`	`continue;`
`802`	`804`	`}`
`803`	`805`
`804`		`- $old_value = get_blog_status( $site->blog_id, $pref );`
	`806`	`+ $old_value = (int) get_blog_status( $site->blog_id, $pref );`
`805`	`807`
`806`	`808`	`if ( $value === $old_value ) {`
`807`	`809`	`WP_CLI::warning( "Site {$site->blog_id} already {$action}." );`