PHPCS: Update ruleset to exclude classes from PrefixAllGlobals.NonPrefixedClassFound sniff

Fix CS in Option command

Author: thrijith

phpcs.xml.dist

@@ -58,6 +58,7 @@
 	</rule>
 
 	<rule ref="WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedClassFound">
+	<exclude-pattern>*/src/Option_Command\.php$</exclude-pattern>
 		<exclude-pattern>*/src/Post(_Meta|_Term|_Type)?_Command\.php$</exclude-pattern>
 		<exclude-pattern>*/src/Site(_Meta|_Option)?_Command\.php$</exclude-pattern>
 		<exclude-pattern>*/src/Term(_Meta)?_Command\.php$</exclude-pattern>

src/Option_Command.php

@@ -131,7 +131,7 @@ public function add( $args, $assoc_args ) {
 			$autoload = 'yes';
 		}
 
-		if ( !add_option( $key, $value, '', $autoload ) ) {
+		if ( ! add_option( $key, $value, '', $autoload ) ) {
 			WP_CLI::error( "Could not add option '{$key}'. Does it already exist?" );
 		} else {
 			WP_CLI::success( "Added '{$key}' option." );
@@ -242,12 +242,12 @@ public function add( $args, $assoc_args ) {
 	public function list_( $args, $assoc_args ) {
 
 		global $wpdb;
-		$pattern = '%';
-		$exclude = '';
-		$fields = array( 'option_name', 'option_value' );
-		$size_query = ",LENGTH(option_value) AS `size_bytes`";
+		$pattern        = '%';
+		$exclude        = '';
+		$fields         = array( 'option_name', 'option_value' );
+		$size_query     = ',LENGTH(option_value) AS `size_bytes`';
 		$autoload_query = '';
-		$sort = Utils\get_flag_value( $assoc_args, 'order' );
+		$sort           = Utils\get_flag_value( $assoc_args, 'order' );
 
 		if ( isset( $assoc_args['search'] ) ) {
 			$pattern = self::esc_like( $assoc_args['search'] );
@@ -267,8 +267,8 @@ public function list_( $args, $assoc_args ) {
 		}
 
 		if ( Utils\get_flag_value( $assoc_args, 'format' ) === 'total_bytes' ) {
-			$fields = array( 'size_bytes' );
-			$size_query = ",SUM(LENGTH(option_value)) AS `size_bytes`";
+			$fields     = array( 'size_bytes' );
+			$size_query = ',SUM(LENGTH(option_value)) AS `size_bytes`';
 		}
 
 		if ( isset( $assoc_args['autoload'] ) ) {
@@ -295,28 +295,33 @@ public function list_( $args, $assoc_args ) {
 
 		$where = '';
 		if ( $pattern ) {
-			$where .= $wpdb->prepare( "WHERE `option_name` LIKE %s", $pattern );
+			$where .= $wpdb->prepare( 'WHERE `option_name` LIKE %s', $pattern );
 		}
 
 		if ( $exclude ) {
-			$where .= $wpdb->prepare( " AND `option_name` NOT LIKE %s", $exclude );
+			$where .= $wpdb->prepare( ' AND `option_name` NOT LIKE %s', $exclude );
 		}
 		$where .= $autoload_query . $transients_query;
 
-		$results = $wpdb->get_results( "SELECT `option_name`,`option_value`,`autoload`" . $size_query
-					. " FROM `$wpdb->options` {$where}" );
+		$results = $wpdb->get_results(
+			'SELECT `option_name`,`option_value`,`autoload`' . $size_query
+			. " FROM `$wpdb->options` {$where}"
+		);
 
 		$orderby = Utils\get_flag_value( $assoc_args, 'orderby' );
 		$order   = Utils\get_flag_value( $assoc_args, 'order' );
 
 		// Sort result.
 		if ( 'option_id' !== $orderby ) {
-			usort( $results, function ( $a, $b ) use ( $orderby, $order ) {
-				// Sort array.
-				return 'asc' === $order
+			usort(
+				$results,
+				function ( $a, $b ) use ( $orderby, $order ) {
+					// Sort array.
+					return 'asc' === $order
 						? $a->$orderby > $b->$orderby
 						: $a->$orderby < $b->$orderby;
-			});
+				}
+			);
 		} elseif ( 'option_id' === $orderby && 'desc' === $order ) { // Sort by default descending.
 			krsort( $results );
 		}
@@ -408,13 +413,13 @@ public function update( $args, $assoc_args ) {
 		$value = WP_CLI::read_value( $value, $assoc_args );
 
 		$autoload = Utils\get_flag_value( $assoc_args, 'autoload' );
-		if ( ! in_array( $autoload, array( 'yes', 'no' ) ) ) {
+		if ( ! in_array( $autoload, [ 'yes', 'no' ], true ) ) {
 			$autoload = null;
 		}
 
 		$value = sanitize_option( $key, $value );
 		// Sanitization WordPress normally performs when getting an option
-		if ( in_array( $key, array('siteurl', 'home', 'category_base', 'tag_base') ) ) {
+		if ( in_array( $key, [ 'siteurl', 'home', 'category_base', 'tag_base' ], true ) ) {
 			$value = untrailingslashit( $value );
 		}
 		$old_value = sanitize_option( $key, get_option( $key ) );
@@ -490,12 +495,15 @@ public function pluck( $args, $assoc_args ) {
 			WP_CLI::halt( 1 );
 		}
 
-		$key_path = array_map( function( $key ) {
-			if ( is_numeric( $key ) && ( $key === (string) intval( $key ) ) ) {
-				return (int) $key;
-			}
-			return $key;
-		}, array_slice( $args, 1 ) );
+		$key_path = array_map(
+			function( $key ) {
+				if ( is_numeric( $key ) && ( (string) intval( $key ) === $key ) ) {
+					return (int) $key;
+				}
+					return $key;
+			},
+			array_slice( $args, 1 )
+		);
 
 		$traverser = new RecursiveDataStructureTraverser( $value );
 
@@ -542,14 +550,17 @@ public function pluck( $args, $assoc_args ) {
 	 */
 	public function patch( $args, $assoc_args ) {
 		list( $action, $key ) = $args;
-		$key_path = array_map( function( $key ) {
-			if ( is_numeric( $key ) && ( $key === (string) intval( $key ) ) ) {
-				return (int) $key;
-			}
-			return $key;
-		}, array_slice( $args, 2 ) );
+		$key_path             = array_map(
+			function( $key ) {
+				if ( is_numeric( $key ) && ( (string) intval( $key ) === $key ) ) {
+					return (int) $key;
+				}
+					return $key;
+			},
+			array_slice( $args, 2 )
+		);
 
-		if ( 'delete' == $action ) {
+		if ( 'delete' === $action ) {
 			$patch_value = null;
 		} else {
 			$stdin_value = EntityUtils::has_stdin()
@@ -561,7 +572,8 @@ public function patch( $args, $assoc_args ) {
 		}
 
 		/* Need to make a copy of $current_value here as it is modified by reference */
-		$old_value = $current_value = sanitize_option( $key, get_option( $key ) );
+		$old_value     = sanitize_option( $key, get_option( $key ) );
+		$current_value = $old_value;
 		if ( is_object( $current_value ) ) {
 			$old_value = clone $current_value;
 		}
@@ -591,11 +603,11 @@ private static function esc_like( $old ) {
 		global $wpdb;
 
 		// Remove notices in 4.0 and support backwards compatibility
-		if( method_exists( $wpdb, 'esc_like' ) ) {
+		if ( method_exists( $wpdb, 'esc_like' ) ) {
 			// 4.0
 			$old = $wpdb->esc_like( $old );
 		} else {
-			// 3.9 or less
+			// phpcs:ignore WordPress.WP.DeprecatedFunctions.like_escapeFound -- called in WordPress 3.9 or less.
 			$old = like_escape( esc_sql( $old ) );
 		}