Add —force-check flag to wp plugin list and wp theme list. (wip)

Author: baizmandesign

features/plugin-list.feature

@@ -0,0 +1,71 @@
+Feature: List WordPress plugins
+
+  Background:
+    Given a WP install
+    And I run `wp plugin uninstall --all`
+    And I run `wp plugin install hello-dolly`
+    And a setup.php file:
+      """
+      <?php
+      $plugin_transient = get_site_transient('update_plugins') ;
+      # manually set the version
+      $fake_version = '10.0.0';
+      $plugin_transient->no_update["hello-dolly/hello.php"]->new_version = $fake_version;
+      $return = set_site_transient( 'update_plugins', $plugin_transient );
+      """
+#    And a wp-content/mu-plugins/test-plugin-update.php file:
+#      """
+#      <?php
+#      /**
+#       * Plugin Name: Test Plugin Update
+#       * Description: Fakes installed plugin's data to verify plugin version mismatch
+#       * Author: WP-CLI tests
+#       */
+#
+#      add_filter( 'site_transient_update_plugins', function( $value ) {
+#          if ( ! is_object( $value ) ) {
+#              return $value;
+#          }
+#          $fake_version = '10.0.0';
+#
+#          unset( $value->response['hello-dolly/hello.php'] );
+#          $value->no_update['hello-dolly/hello.php']->new_version = $fake_version;
+#
+#          return $value;
+#      } );
+#      ?>
+#      """
+
+  Scenario: Refresh update_plugins transient when listing plugins with --force-check flag
+
+    # Listing the plugins will populate the transient in the database
+    When I run `wp plugin list`
+    Then STDOUT should not be empty
+    And save STDOUT as {PLUGIN_LIST_ORIGINAL_VERSIONS}
+
+    # Write a test value
+    When I run `wp eval-file setup.php`
+    Then STDOUT should be empty
+
+    # Get value of plugin transient
+    #When I run `wp option get _site_transient_update_plugins`
+    #Then STDOUT should be empty
+
+    # Run list again
+    When I run `wp plugin list`
+    Then STDOUT should be empty
+    And save STDOUT as {PLUGIN_LIST_FAKE_VERSIONS}
+
+    # TODO: compare {PLUGIN_LIST_ORIGINAL_VERSIONS} to {PLUGIN_LIST_FAKE_VERSIONS}
+    # expected result: they should be different
+
+    # Get value of plugin transient
+    When I run `wp option get _site_transient_update_plugins`
+    Then STDOUT should be empty
+
+    When I run `wp plugin list --force-check`
+    Then STDOUT should not be empty
+    And save STDOUT as {PLUGIN_LIST_FORCE_CHECK_VERSIONS}
+
+    # TODO: compare {PLUGIN_LIST_ORIGINAL_VERSIONS} to {PLUGIN_LIST_FORCE_CHECK_VERSIONS}
+    # expected result: they should be the same

features/theme-list.feature

@@ -0,0 +1,27 @@
+Feature: List WordPress themes
+
+  Background:
+    Given a WP install
+    And a setup.php file:
+      """
+      <?php
+      $theme_transient = new stdClass;
+      $theme_transient->last_checked = time();
+      $theme_transient->checked = [];
+      $theme_transient->response = [];
+      $theme_transient->no_update = [];
+      $theme_transient->translations = [];
+      $return = update_option( '_site_transient_update_themes', $theme_transient );
+      """
+    And I run `wp transient delete update_themes --network`
+
+  Scenario: Refresh update_themes transient when listing themes with --force-check flag
+
+    # Listing the themes will populate the transient in the database
+    When I run `wp theme list`
+    Then STDOUT should not be empty
+
+    When I run `wp transient set update_themes test_value --network`
+    And I run `wp theme list --force-check`
+
+    Then STDOUT should be empty

src/Plugin_Command.php

@@ -1325,6 +1325,9 @@ public function delete( $args, $assoc_args = array() ) {
 	 * [--skip-update-check]
 	 * : If set, the plugin update check will be skipped.
 	 *
+	 * [--force-check]
+	 * : Bypass the transient cache and force a fresh update check.
+     *
 	 * [--recently-active]
 	 * : If set, only recently active plugins will be shown and the status filter will be ignored.
 	 *

src/Theme_Command.php

@@ -857,6 +857,9 @@ public function delete( $args, $assoc_args ) {
 	 * [--skip-update-check]
 	 * : If set, the theme update check will be skipped.
 	 *
+	 * [--force-check]
+	 * : Bypass the transient cache and force a fresh update check.
+	 *
 	 * ## AVAILABLE FIELDS
 	 *
 	 * These fields will be displayed by default for each theme:

src/WP_CLI/CommandWithUpgrade.php

@@ -532,6 +532,11 @@ static function ( $result ) {
 	// phpcs:ignore PSR2.Methods.MethodDeclaration.Underscore -- Whitelisting to provide backward compatibility to classes possibly extending this class.
 	protected function _list( $_, $assoc_args ) {
 
+		// If `--force-check` flag is present, delete the ${item_type} transient.
+		if ( true === (bool) Utils\get_flag_value( $assoc_args, 'force-check', false ) ) {
+			delete_site_transient( $this->item_type . 's' );
+		}
+
 		// Force WordPress to check for updates if `--skip-update-check` is not passed.
 		if ( false === (bool) Utils\get_flag_value( $assoc_args, 'skip-update-check', false ) ) {
 			call_user_func( $this->upgrade_refresh );