Do a strict check for the flag skip-update-check

Nikschavan · schlessera · commit 50deb81c90a1 · 2021-10-13T07:26:14.000+02:00
diff --git a/src/WP_CLI/CommandWithUpgrade.php b/src/WP_CLI/CommandWithUpgrade.php
@@ -482,7 +482,7 @@ static function ( $result ) {
 	protected function _list( $_, $assoc_args ) {
 
 		// Force WordPress to check for updates if `--skip-update-check` is not passed.
-		if ( Utils\get_flag_value( $assoc_args, 'skip-update-check', false ) ) {
+		if ( false === (bool) Utils\get_flag_value( $assoc_args, 'skip-update-check', false ) ) {
 			call_user_func( $this->upgrade_refresh );
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -482,7 +482,7 @@ static function ( $result ) {`
`482`	`482`	`protected function _list( $_, $assoc_args ) {`
`483`	`483`
`484`	`484`	// Force WordPress to check for updates if `--skip-update-check` is not passed.
`485`		`- if ( Utils\get_flag_value( $assoc_args, 'skip-update-check', false ) ) {`
	`485`	`+ if ( false === (bool) Utils\get_flag_value( $assoc_args, 'skip-update-check', false ) ) {`
`486`	`486`	`call_user_func( $this->upgrade_refresh );`
`487`	`487`	`}`
`488`	`488`