Revise the tests in theme-list.feature.

Signed-off-by: Saul Baizman <[email protected]>

Author: baizmandesign

features/theme-list.feature

@@ -1,27 +1,64 @@
 Feature: List WordPress themes
 
-  Background:
+  Scenario: Refresh update_themes transient when listing themes with --force-check flag
     Given a WP install
-    And a setup.php file:
+    And I run `wp theme delete --all --force`
+    And I run `wp theme install --force twentytwentyfour --version=1.1`
+    And a update-transient.php file:
       """
       <?php
-      $theme_transient = new stdClass;
-      $theme_transient->last_checked = time();
-      $theme_transient->checked = [];
-      $theme_transient->response = [];
-      $theme_transient->no_update = [];
-      $theme_transient->translations = [];
-      $return = update_option( '_site_transient_update_themes', $theme_transient );
+      $transient = get_site_transient( 'update_themes' );
+      $transient->response['twentytwentyfour'] = (object) array(
+        'theme'        => 'twentytwentyfour',
+        'new_version'  => '100.0.0',
+        'url'          => 'https://wordpress.org/themes/twentytwentyfour/',
+        'package'      => 'https://downloads.wordpress.org/theme/twentytwentyfour.100.zip',
+        'requires'     => '6.4',
+        'requires_php' => '7.0'
+      );
+      $transient->checked = array(
+        'twentytwentyfour' => '1.1',
+      );
+      unset( $transient->no_update['twentytwentyfour'] );
+      set_site_transient( 'update_themes', $transient );
+      WP_CLI::success( 'Transient updated.' );
       """
-    And I run `wp transient delete update_themes --network`
 
-  Scenario: Refresh update_themes transient when listing themes with --force-check flag
+    # Populates the initial transient in the database
+    When I run `wp theme list --fields=name,status,update`
+    Then STDOUT should be a table containing rows:
+      | name              | status   | update |
+      | twentytwentyfour  | active   | none   |
+
+    # Modify the transient in the database to simulate an update
+    When I run `wp eval-file update-transient.php`
+    Then STDOUT should be:
+      """
+      Success: Transient updated.
+      """
+
+    # Verify the fake transient value produces the expected output
+    When I run `wp theme list --fields=name,status,update`
+    Then STDOUT should be a table containing rows:
+      | name              | status   | update    |
+      | twentytwentyfour  | active   | available |
 
-    # Listing the themes will populate the transient in the database
-    When I run `wp theme list`
-    Then STDOUT should not be empty
+    # Repeating the same command again should produce the same results
+    When I run `wp theme list --fields=name,status,update`
+    Then STDOUT should be a table containing rows:
+      | name              | status   | update    |
+      | twentytwentyfour  | active   | available |
 
-    When I run `wp transient set update_themes test_value --network`
-    And I run `wp theme list --force-check`
+    # Using the --force-check flag should refresh the transient back to the original value
+    When I run `wp theme list --fields=name,status,update --force-check`
+    Then STDOUT should be a table containing rows:
+      | name              | status   | update |
+      | twentytwentyfour  | active   | none   |
 
-    Then STDOUT should be empty
+    When I try `wp theme list --skip-update-check --force-check`
+    Then STDERR should contain:
+      """
+      Error: theme updates cannot be both force-checked and skipped. Choose one.
+      """
+    And STDOUT should be empty
+    And the return code should be 1