Merge pull request #300 from Nikschavan/299-skip-update-check

Author: schlessera

composer.json

@@ -21,6 +21,7 @@
         "wp-cli/wp-cli": "^2.5.1"
     },
     "require-dev": {
+        "wp-cli/cache-command": "^2.0",
         "wp-cli/entity-command": "^1.3 || ^2",
         "wp-cli/scaffold-command": "^1.2 || ^2",
         "wp-cli/wp-cli-tests": "^3.0.16"

features/plugin.feature

@@ -341,6 +341,31 @@ Feature: Manage WordPress plugins
       | akismet            | active   | akismet/akismet.php                       |
       | wordpress-importer | inactive | wordpress-importer/wordpress-importer.php |
 
+  Scenario: Flag `--skip-update-check` skips update check when running `wp plugin list`
+    Given a WP install
+
+    When I run `wp plugin install wordpress-importer --version=0.2`
+    Then STDOUT should contain:
+      """
+      Plugin installed successfully.
+      """
+
+    When I run `wp plugin list --fields=name,status,update --status=inactive`
+    Then STDOUT should be a table containing rows:
+      | name               | status   | update    |
+      | wordpress-importer | inactive | available |
+
+    When I run `wp transient delete update_plugins --network`
+    Then STDOUT should be:
+      """
+      Success: Transient deleted.
+      """
+
+    When I run `wp plugin list --fields=name,status,update --status=inactive --skip-update-check`
+    Then STDOUT should be a table containing rows:
+      | name               | status   | update   |
+      | wordpress-importer | inactive | none     |
+
   Scenario: Install a plugin when directory doesn't yet exist
     Given a WP install
 

features/theme.feature

@@ -178,6 +178,31 @@ Feature: Manage WordPress themes
     And STDOUT should be empty
     And the return code should be 0
 
+  Scenario: Flag `--skip-update-check` skips update check when running `wp theme list`
+    Given a WP install
+
+    When I run `wp theme install astra --version=1.0.0`
+    Then STDOUT should contain:
+      """
+      Theme installed successfully.
+      """
+
+    When I run `wp theme list --fields=name,status,update`
+    Then STDOUT should be a table containing rows:
+      | name  | status   | update    |
+      | astra | inactive | available |
+
+    When I run `wp transient delete update_themes --network`
+    Then STDOUT should be:
+      """
+      Success: Transient deleted.
+      """
+
+    When I run `wp theme list --fields=name,status,update --skip-update-check`
+    Then STDOUT should be a table containing rows:
+      | name  | status   | update |
+      | astra | inactive | none   |
+
   Scenario: Install a theme when the theme directory doesn't yet exist
     Given a WP install
 

src/Plugin_Command.php

@@ -1083,6 +1083,9 @@ public function delete( $args, $assoc_args = array() ) {
 	 *   - must-use
 	 * ---
 	 *
+	 * [--skip-update-check]
+	 * : If set, the plugin update check will be skipped.
+	 *
 	 * ## AVAILABLE FIELDS
 	 *
 	 * These fields will be displayed by default for each plugin:

src/Theme_Command.php

@@ -832,6 +832,9 @@ public function delete( $args, $assoc_args ) {
 	 *   - inactive
 	 * ---
 	 *
+	 * [--skip-update-check]
+	 * : If set, the theme update check will be skipped.
+	 *
 	 * ## AVAILABLE FIELDS
 	 *
 	 * These fields will be displayed by default for each theme:

src/WP_CLI/CommandWithUpgrade.php

@@ -480,8 +480,11 @@ static function ( $result ) {
 
 	// phpcs:ignore PSR2.Methods.MethodDeclaration.Underscore -- Whitelisting to provide backward compatibility to classes possibly extending this class.
 	protected function _list( $_, $assoc_args ) {
-		// Force WordPress to check for updates
-		call_user_func( $this->upgrade_refresh );
+
+		// Force WordPress to check for updates if `--skip-update-check` is not passed.
+		if ( false === (bool) Utils\get_flag_value( $assoc_args, 'skip-update-check', false ) ) {
+			call_user_func( $this->upgrade_refresh );
+		}
 
 		$all_items = $this->get_all_items();