Merge pull request #209 from jrfnl/feature/cs-fixes-3

PHPCS: fix up the code base [3] - strict comparisons

Author: danielbachhuber

src/Scaffold_Command.php

@@ -421,7 +421,7 @@ public function _s( $args, $assoc_args ) {
 		}
 
 		$response_code = wp_remote_retrieve_response_code( $response );
-		if ( 200 != $response_code ) {
+		if ( 200 !== (int) $response_code ) {
 			WP_CLI::error( "Couldn't create theme (received $response_code response)." );
 		}
 
@@ -493,7 +493,7 @@ public function _s( $args, $assoc_args ) {
 	function child_theme( $args, $assoc_args ) {
 		$theme_slug = $args[0];
 
-		if ( in_array( $theme_slug, array( '.', '..' ) ) ) {
+		if ( in_array( $theme_slug, array( '.', '..' ), true ) ) {
 			WP_CLI::error( "Invalid theme slug specified. The slug cannot be '.' or '..'." );
 		}
 
@@ -639,7 +639,7 @@ function plugin( $args, $assoc_args ) {
 		$plugin_name    = ucwords( str_replace( '-', ' ', $plugin_slug ) );
 		$plugin_package = str_replace( ' ', '_', $plugin_name );
 
-		if ( in_array( $plugin_slug, array( '.', '..' ) ) ) {
+		if ( in_array( $plugin_slug, array( '.', '..' ), true ) ) {
 			WP_CLI::error( "Invalid plugin slug specified. The slug cannot be '.' or '..'." );
 		}
 
@@ -811,7 +811,7 @@ private function scaffold_plugin_theme_tests( $args, $assoc_args, $type ) {
 
 		if ( ! empty( $args[0] ) ) {
 			$slug = $args[0];
-			if ( in_array( $slug, array( '.', '..' ) ) ) {
+			if ( in_array( $slug, array( '.', '..' ), true ) ) {
 				WP_CLI::error( "Invalid {$type} slug specified. The slug cannot be '.' or '..'." );
 			}
 			if ( 'theme' === $type ) {
@@ -977,7 +977,7 @@ protected function prompt_if_files_will_be_overwritten( $filename, $force ) {
 					$default = false,
 					$marker = '[s/r]: '
 				);
-			} while ( ! in_array( $answer, array( 's', 'r' ) ) );
+			} while ( ! in_array( $answer, array( 's', 'r' ), true ) );
 			$should_write_file = 'r' === $answer;
 		}