Omit second is_string() check

schlessera · web-flow · commit 08f795fbd044 · 2020-11-13T07:40:31.000+01:00
diff --git a/src/WP_CLI/SearchReplacer.php b/src/WP_CLI/SearchReplacer.php
@@ -84,7 +84,7 @@ private function run_recursively( $data, $serialised, $recursion_level = 0, $vis
 			}
 
 			$unserialized = is_string( $data ) ? @unserialize( $data ) : false;
-			if ( is_string( $data ) && false !== $unserialized ) {
+			if ( false !== $unserialized ) {
 				$data = $this->run_recursively( $unserialized, true, $recursion_level + 1 );
 			} elseif ( is_array( $data ) ) {
 				$keys = array_keys( $data );
@@ -180,4 +180,3 @@ private function preg_error_message( $error ) {
 			: '<unknown error>';
 	}
 }
-

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ private function run_recursively( $data, $serialised, $recursion_level = 0, $vis`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`$unserialized = is_string( $data ) ? @unserialize( $data ) : false;`
`87`		`- if ( is_string( $data ) && false !== $unserialized ) {`
	`87`	`+ if ( false !== $unserialized ) {`
`88`	`88`	`$data = $this->run_recursively( $unserialized, true, $recursion_level + 1 );`
`89`	`89`	`} elseif ( is_array( $data ) ) {`
`90`	`90`	`$keys = array_keys( $data );`
`@@ -180,4 +180,3 @@ private function preg_error_message( $error ) {`
`180`	`180`	`: '<unknown error>';`
`181`	`181`	`}`
`182`	`182`	`}`
`183`		`-`