PHPStan level 9

wip

Author: swissspidy

phpstan.neon.dist

@@ -0,0 +1,14 @@
+parameters:
+  level: 9
+  paths:
+    - src
+    - shell-command.php
+  scanDirectories:
+    - vendor/wp-cli/wp-cli/php
+  scanFiles:
+    - vendor/php-stubs/wordpress-stubs/wordpress-stubs.php
+  treatPhpDocTypesAsCertain: false
+  ignoreErrors:
+    - identifier: missingType.property
+    - identifier: missingType.parameter
+    - identifier: missingType.return

src/Shell_Command.php

@@ -27,6 +27,9 @@ class Shell_Command extends WP_CLI_Command {
 	 *     => string(6) "WP-CLI"
 	 */
 	public function __invoke( $_, $assoc_args ) {
+		/**
+		 * @var array<class-string> $implementations
+		 */
 		$implementations = array(
 			'Psy\\Shell',
 			'Boris\\Boris',
@@ -44,6 +47,10 @@ public function __invoke( $_, $assoc_args ) {
 			}
 		}
 
+		/**
+		 * @var class-string $class
+		 */
+
 		if ( 'Psy\\Shell' === $class ) {
 			$shell = new Psy\Shell();
 			$shell->run();

src/WP_CLI/Shell/REPL.php

@@ -17,6 +17,7 @@ public function __construct( $prompt ) {
 	}
 
 	public function start() {
+		// @phpstan-ignore while.alwaysTrue
 		while ( true ) {
 			$line = $this->prompt();
 
@@ -30,7 +31,7 @@ public function start() {
 				ob_start();
 				// phpcs:ignore Squiz.PHP.Eval.Discouraged -- This is meant to be a REPL, no way to avoid eval.
 				eval( $line );
-				$out = ob_get_clean();
+				$out = (string) ob_get_clean();
 				if ( 0 < strlen( $out ) ) {
 					$out = rtrim( $out, "\n" ) . "\n";
 				}
@@ -44,13 +45,13 @@ public function start() {
 				ob_start();
 				// phpcs:ignore Squiz.PHP.Eval.Discouraged -- This is meant to be a REPL, no way to avoid eval.
 				$evl = eval( $line );
-				$out = ob_get_clean();
+				$out = (string) ob_get_clean();
 				if ( 0 < strlen( $out ) ) {
 					echo rtrim( $out, "\n" ) . "\n";
 				}
 				echo '=> ';
 				var_dump( $evl );
-				fwrite( STDOUT, ob_get_clean() );
+				fwrite( STDOUT, (string) ob_get_clean() );
 			}
 		}
 	}
@@ -86,9 +87,11 @@ private function prompt() {
 
 			$fp = popen( self::create_prompt_cmd( $prompt, $this->history_file ), 'r' );
 
-			$line = fgets( $fp );
+			$line = $fp ? fgets( $fp ) : '';
 
-			pclose( $fp );
+			if ( $fp ) {
+				pclose( $fp );
+			}
 
 			if ( ! $line ) {
 				break;