Use short array notation

Author: schlessera

utils/maintenance/Contrib_List_Command.php

@@ -69,10 +69,10 @@ public function __invoke( $_, $assoc_args ) {
 		$composer_json = json_decode( $response->body, true );
 
 		// TODO: Only need for initial v2.
-		$composer_json['packages'][] = array(
+		$composer_json['packages'][] = [
 			'name'    => 'wp-cli/i18n-command',
 			'version' => 'v2',
-		);
+		];
 		usort(
 			$composer_json['packages'],
 			function ( $a, $b ) {
@@ -86,22 +86,22 @@ function ( $a, $b ) {
 			if ( ! preg_match( '#^wp-cli/.+-command$#', $package_name )
 				&& ! in_array(
 					$package_name,
-					array(
+					[
 						'wp-cli/wp-cli-tests',
 						'wp-cli/regenerate-readme',
 						'wp-cli/autoload-splitter',
 						'wp-cli/wp-config-transformer',
 						'wp-cli/php-cli-tools',
 						'wp-cli/spyc',
-					),
+					],
 					true
 				) ) {
 				continue;
 			}
 			// Closed milestones denote a tagged release
 			$milestones       = GitHub::get_project_milestones( $package_name, [ 'state' => 'closed' ] );
-			$milestone_ids    = array();
-			$milestone_titles = array();
+			$milestone_ids    = [];
+			$milestone_titles = [];
 			foreach ( $milestones as $milestone ) {
 				if ( ! version_compare( $milestone->title, $version_constraint, '>' ) ) {
 					continue;

utils/maintenance/Milestones_After_Command.php

@@ -29,7 +29,7 @@ public function __invoke( $args, $assoc_args ) {
 		$milestones        = array_filter(
 			GitHub::get_project_milestones(
 				$repo,
-				array( 'state' => 'closed' )
+				[ 'state' => 'closed' ]
 			),
 			function ( $milestone ) use (
 				$milestone_name,

utils/maintenance/Milestones_Since_Command.php

@@ -32,7 +32,7 @@ public function __invoke( $args, $assoc_args ) {
 		$milestones = array_filter(
 			GitHub::get_project_milestones(
 				$repo,
-				array( 'state' => 'closed' )
+				[ 'state' => 'closed' ]
 			),
 			function ( $milestone ) use ( $date ) {
 				$closed = new DateTime( $milestone->closed_at );

utils/maintenance/Release_Date_Command.php

@@ -31,7 +31,7 @@ public function __invoke( $args, $assoc_args ) {
 			strpos( $milestone_name, 'v' ) === 0
 				? $milestone_name
 				: "v{$milestone_name}",
-			array( 'state' => 'all' )
+			[ 'state' => 'all' ]
 		);
 
 		WP_CLI::log( $release->published_at );

utils/maintenance/Release_Notes_Command.php

@@ -69,12 +69,12 @@ public function __invoke( $args, $assoc_args ) {
 	private function get_bundle_release_notes( $source, $format ) {
 		// Get the release notes for the current open large project milestones.
 		foreach (
-			array(
+			[
 				'wp-cli/wp-cli-bundle',
 				'wp-cli/wp-cli',
 				'wp-cli/handbook',
 				'wp-cli/wp-cli.github.com',
-			) as $repo
+			] as $repo
 		) {
 			$milestones = GitHub::get_project_milestones( $repo );
 			// Cheap way to get the latest milestone
@@ -100,7 +100,7 @@ private function get_bundle_release_notes( $source, $format ) {
 
 		$milestones = GitHub::get_project_milestones(
 			'wp-cli/wp-cli',
-			array( 'state' => 'closed' )
+			[ 'state' => 'closed' ]
 		);
 		// Cheap way to get the latest closed milestone
 		$milestone = array_shift( $milestones );
@@ -128,10 +128,10 @@ private function get_bundle_release_notes( $source, $format ) {
 		$composer_json = json_decode( $response->body, true );
 
 		// TODO: Only need for initial v2.
-		$composer_json['packages'][] = array(
+		$composer_json['packages'][] = [
 			'name'    => 'wp-cli/i18n-command',
 			'version' => 'v2',
-		);
+		];
 		usort(
 			$composer_json['packages'],
 			function ( $a, $b ) {
@@ -145,14 +145,14 @@ function ( $a, $b ) {
 			if ( ! preg_match( '#^wp-cli/.+-command$#', $package_name )
 				&& ! in_array(
 					$package_name,
-					array(
+					[
 						'wp-cli/wp-cli-tests',
 						'wp-cli/regenerate-readme',
 						'wp-cli/autoload-splitter',
 						'wp-cli/wp-config-transformer',
 						'wp-cli/php-cli-tools',
 						'wp-cli/spyc',
-					),
+					],
 					true
 				) ) {
 				continue;
@@ -163,7 +163,7 @@ function ( $a, $b ) {
 			// Closed milestones denote a tagged release
 			$milestones = GitHub::get_project_milestones(
 				$package_name,
-				array( 'state' => 'closed' )
+				[ 'state' => 'closed' ]
 			);
 			foreach ( $milestones as $milestone ) {
 				if ( ! version_compare(
@@ -198,10 +198,10 @@ private function get_repo_release_notes(
 
 		$potential_milestones = GitHub::get_project_milestones(
 			$repo,
-			array( 'state' => 'all' )
+			[ 'state' => 'all' ]
 		);
 
-		$milestones = array();
+		$milestones = [];
 		foreach ( $potential_milestones as $potential_milestone ) {
 			if ( in_array(
 				$potential_milestone->title,
@@ -228,7 +228,7 @@ private function get_repo_release_notes(
 			);
 		}
 
-		$entries = array();
+		$entries = [];
 		foreach ( $milestones as $milestone ) {
 			switch ( $source ) {
 				case 'release':
@@ -239,7 +239,7 @@ private function get_repo_release_notes(
 					$release = GitHub::get_release_by_tag(
 						$repo,
 						$tag,
-						array( 'throw_errors' => false )
+						[ 'throw_errors' => false ]
 					);
 
 					if ( $release ) {

utils/make-phar-spec.php

@@ -1,37 +1,37 @@
 <?php
 
-return array(
-	'output'        => array(
+return [
+	'output'        => [
 		'runtime' => '=<path>',
 		'file'    => '<path>',
 		'desc'    => 'Path to output file',
-	),
+	],
 
-	'version'       => array(
+	'version'       => [
 		'runtime' => '=<version>',
 		'file'    => '<version>',
 		'desc'    => 'New package version',
-	),
+	],
 
-	'store-version' => array(
+	'store-version' => [
 		'runtime' => '',
 		'file'    => '<bool>',
 		'default' => false,
 		'desc'    => 'If true the contents of ./VERSION will be set to the value passed to --version',
-	),
+	],
 
-	'quiet'         => array(
+	'quiet'         => [
 		'runtime' => '',
 		'file'    => '<bool>',
 		'default' => false,
 		'desc'    => 'Suppress informational messages',
-	),
+	],
 
-	'build'         => array(
+	'build'         => [
 		'runtime' => '=<cli>',
 		'file'    => '<cli>',
 		'default' => '',
 		'desc'    => 'Create a minimum test build "cli", that only supports cli commands',
-	),
-);
+	],
+];