Skip to content

Commit 888cf29

Browse files
committed
Adapt milestone selection
1 parent 8bc601f commit 888cf29

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

.maintenance/src/Release_Notes_Command.php

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,7 @@ final class Release_Notes_Command {
4040
*/
4141
public function __invoke( $args, $assoc_args ) {
4242

43-
$repo = null;
44-
$milestone_names = null;
43+
$repo = null;
4544

4645
if ( count( $args ) > 0 ) {
4746
$repo = array_shift( $args );
@@ -67,7 +66,7 @@ public function __invoke( $args, $assoc_args ) {
6766
}
6867

6968
private function get_bundle_release_notes( $source, $format ) {
70-
// Get the release notes for the current open large project milestones.
69+
// Get the release notes for the lowest open project milestones.
7170
foreach (
7271
array(
7372
'wp-cli/wp-cli-bundle',
@@ -79,8 +78,11 @@ private function get_bundle_release_notes( $source, $format ) {
7978
$milestones = GitHub::get_project_milestones( $repo );
8079
$milestone = array_reduce(
8180
$milestones,
82-
function ( $latest, $milestone ) {
83-
return version_compare( $milestone->title, $latest, '>' ) ? $milestone : $latest;
81+
static function ( $latest, $milestone ) {
82+
if ( $latest === null ) {
83+
return $milestone;
84+
}
85+
return version_compare( $milestone->title, $latest->title, '<' ) ? $milestone : $latest;
8486
}
8587
);
8688

0 commit comments

Comments
 (0)