Merge branch 'main' into improve/error-no-github-token

Author: danielbachhuber

.github/dependabot.yml

@@ -7,3 +7,11 @@ updates:
     open-pull-requests-limit: 10
     labels:
       - scope:distribution
+  - package-ecosystem: github-actions
+    directory: "/"
+    schedule:
+      interval: daily
+    open-pull-requests-limit: 10
+    labels:
+      - scope:distribution
+

.github/workflows/code-quality.yml

@@ -20,11 +20,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Check out source code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Check existence of composer.json file
         id: check_composer_file
-        uses: andstor/file-existence-action@v1
+        uses: andstor/file-existence-action@v2
         with:
           files: "composer.json"
 
@@ -45,7 +45,7 @@ jobs:
 
       - name: Check existence of vendor/bin/parallel-lint file
         id: check_linter_file
-        uses: andstor/file-existence-action@v1
+        uses: andstor/file-existence-action@v2
         with:
           files: "vendor/bin/parallel-lint"
 
@@ -59,11 +59,11 @@ jobs:
 
     steps:
       - name: Check out source code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Check existence of composer.json & phpcs.xml.dist files
         id: check_files
-        uses: andstor/file-existence-action@v1
+        uses: andstor/file-existence-action@v2
         with:
           files: "composer.json, phpcs.xml.dist"
 
@@ -84,7 +84,7 @@ jobs:
 
       - name: Check existence of vendor/bin/phpcs file
         id: check_phpcs_binary_file
-        uses: andstor/file-existence-action@v1
+        uses: andstor/file-existence-action@v2
         with:
           files: "vendor/bin/phpcs"
 

.maintenance/clone-all-repositories.php

@@ -12,20 +12,18 @@
 	'wp-cli-roadmap',
 );
 
-$request        = 'https://api.github.com/orgs/wp-cli/repos?per_page=100';
-$headers        = '';
-$token          = getenv( 'GITHUB_TOKEN' );
-if (!empty($token)) {
-$headers = '--header "Authorization: token $token"';
-$response       = shell_exec( "curl -s {$headers} {$request}" );
+$request = 'https://api.github.com/orgs/wp-cli/repos?per_page=100';
+$headers = '';
+$token   = getenv( 'GITHUB_TOKEN' );
+if ( ! empty( $token ) ) {
+	$headers  = '--header "Authorization: token $token"';
+	$response = shell_exec( "curl -s {$headers} {$request}" );
+} else {
+	$response = shell_exec( "curl -s {$request}" );
 }
-else
-{
-$response       = shell_exec( "curl -s {$request}" );
-}
-$repositories   = json_decode( $response );
+$repositories = json_decode( $response );
 if ( ! is_array( $repositories ) && property_exists( $repositories, 'message' ) ) {
-	echo "GitHub responded with: " . $repositories->message . "\n";
+	echo 'GitHub responded with: ' . $repositories->message . "\n";
 	echo "If you are running into a rate limiting issue during large events please set GITHUB_TOKEN environment variable.\n";
 	exit( 1 );
 }
@@ -40,9 +38,10 @@
 
 	if ( ! is_dir( $repository->name ) ) {
 		printf( "Fetching \033[32mwp-cli/{$repository->name}\033[0m...\n" );
-		system( "git clone {$repository->ssh_url}" );
+		$clone_url = getenv( 'GITHUB_ACTION' ) ? $repository->clone_url : $repository->ssh_url;
+		system( "git clone {$clone_url}" );
 	}
-	
+
 	$update_folders[] = $repository->name;
 }
 

.maintenance/phpstorm.exclude-recursive-folders.php

@@ -1,9 +1,10 @@
 <?php
+
+// phpcs:disable PEAR.NamingConventions.ValidClassName.StartWithCapital,PEAR.NamingConventions.ValidClassName.Invalid
 /**
  * phpstorm follows symlinks when indexing, which creates an infinite loop of indexing.
  * The inclusion of the vendor folders is mostly the problem
  */
-
 class phpstorm_exclude_recursive_folders {
 
 	public static function init() {
@@ -74,7 +75,7 @@ protected static function has_project_iml() {
 	 */
 	protected static function get_project_name() {
 		$pwd          = getcwd();
-		$project_name = substr( $pwd, strrpos( $pwd, "/" ) + 1 );
+		$project_name = substr( $pwd, strrpos( $pwd, '/' ) + 1 );
 
 		return $project_name;
 	}
@@ -87,8 +88,8 @@ protected static function get_project_iml_path() {
 		$modules_xml = new DOMDocument();
 		$modules_xml->load( '.idea/modules.xml' );
 		$iml_file_path = $modules_xml->getElementsByTagName( 'component' )->item( 0 )
-		                             ->getElementsByTagName( 'modules' )->item( 0 )
-		                             ->getElementsByTagName( 'module' )->item( 0 )->getAttribute( 'filepath' );
+									->getElementsByTagName( 'modules' )->item( 0 )
+									->getElementsByTagName( 'module' )->item( 0 )->getAttribute( 'filepath' );
 		$iml_file_path = str_replace( '$PROJECT_DIR$/', '', $iml_file_path );
 
 		return $iml_file_path;
@@ -120,13 +121,15 @@ protected static function get_exclude_dir_list() {
 	 * Add the folders to exclude in the iml file.
 	 */
 	protected static function set_exclude_in_project_iml() {
-		$folders_to_exclude          = self::get_exclude_dir_list();
-		$iml_xml                     = new DOMDocument();
+		$folders_to_exclude = self::get_exclude_dir_list();
+		$iml_xml            = new DOMDocument();
+		// phpcs:ignore WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase
 		$iml_xml->preserveWhiteSpace = false;
-		$iml_xml->formatOutput       = true;
+		// phpcs:ignore WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase
+		$iml_xml->formatOutput = true;
 		$iml_xml->load( self::get_project_iml_path() );
 		$iml_xml_content_node = $iml_xml->getElementsByTagName( 'component' )->item( 0 )
-		                                ->getElementsByTagName( 'content' )->item( 0 );
+										->getElementsByTagName( 'content' )->item( 0 );
 		$xpath                = new DomXpath( $iml_xml );
 
 		foreach ( $folders_to_exclude as $folder ) {
@@ -144,8 +147,10 @@ protected static function set_exclude_in_project_iml() {
 			$iml_xml_content_node->appendChild( $exclude_node );
 		}
 
+		// phpcs:ignore WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase
 		$iml_xml->preserveWhiteSpace = false;
-		$iml_xml->formatOutput       = true;
+		// phpcs:ignore WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase
+		$iml_xml->formatOutput = true;
 		$iml_xml->save( self::get_project_iml_path() );
 	}
 }

.maintenance/refresh-repository.php

@@ -1,11 +1,11 @@
 <?php
 
-if ( ! isset ( $argv[1] ) || ! is_dir( $argv[1] ) ) {
+if ( ! isset( $argv[1] ) || ! is_dir( $argv[1] ) ) {
 	exit( "Usage: php refresh-repository.php <repository-folder>\n" );
 }
 
 $repository = $argv[1];
-$path = realpath( getcwd() . "/{$repository}" );
+$path       = realpath( getcwd() . "/{$repository}" );
 
 printf( "--- Refreshing repository \033[32m{$repository}\033[0m ---\n" );