Skip to content

Commit 327e63b

Browse files
Copilotswissspidy
andcommitted
Use natural syntax for version-specific WP installation steps
Co-authored-by: swissspidy <[email protected]>
1 parent 6dc669a commit 327e63b

File tree

2 files changed

+14
-48
lines changed

2 files changed

+14
-48
lines changed

features/testing.feature

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ Feature: Test that WP-CLI loads.
6464
"""
6565

6666
Scenario: WP installation with specific version
67-
Given a WP installation with version "6.4.2"
67+
Given a WP 6.4.2 installation
6868

6969
When I run `wp core version`
7070
Then STDOUT should be:
@@ -73,7 +73,7 @@ Feature: Test that WP-CLI loads.
7373
"""
7474

7575
Scenario: WP installation in subdirectory with specific version
76-
Given a WP installation in 'wordpress' with version "6.3.1"
76+
Given a WP 6.3.1 installation in 'wordpress'
7777

7878
When I run `wp core version --path=wordpress`
7979
Then STDOUT should be:

src/Context/GivenStepDefinitions.php

Lines changed: 12 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -391,36 +391,20 @@ public function given_a_database(): void {
391391
* Scenario: My other scenario
392392
* Given a WP install
393393
* ...
394-
* ```
395-
*
396-
* @access public
397-
*
398-
* @Given a WP install(ation)
399-
*/
400-
public function given_a_wp_installation(): void {
401-
$this->install_wp();
402-
}
403-
404-
/**
405-
* Installs WordPress with a specific version.
406-
*
407-
* ```
408-
* Scenario: My example scenario
409-
* Given a WP installation with version "6.4.2"
410-
* ...
411394
*
412-
* Scenario: My other scenario
413-
* Given a WP install with version "6.3.1"
395+
* Scenario: My version-specific scenario
396+
* Given a WP 6.4.2 installation
414397
* ...
415398
* ```
416399
*
417400
* @access public
418401
*
419-
* @Given a WP install(ation) with version :version
402+
* @Given /^a WP( ([^\s]+))? install(?:ation)?$/
420403
*
421-
* @param string $version
404+
* @param string $version_with_space Optional version with leading space
405+
* @param string $version Optional version number
422406
*/
423-
public function given_a_wp_installation_with_version( $version ): void {
407+
public function given_a_wp_installation( $version_with_space = '', $version = '' ): void {
424408
$this->install_wp( '', $version );
425409
}
426410

@@ -435,39 +419,21 @@ public function given_a_wp_installation_with_version( $version ): void {
435419
* Scenario: My other scenario
436420
* Given a WP install in 'bar'
437421
* ...
438-
* ```
439422
*
440-
* @access public
441-
*
442-
* @Given a WP install(ation) in :subdir
443-
*
444-
* @param string $subdir
445-
*/
446-
public function given_a_wp_installation_in_a_specific_folder( $subdir ): void {
447-
$this->install_wp( $subdir );
448-
}
449-
450-
/**
451-
* Installs WordPress in a given directory with a specific version.
452-
*
453-
* ```
454-
* Scenario: My example scenario
455-
* Given a WP installation in 'foo' with version "6.4.2"
456-
* ...
457-
*
458-
* Scenario: My other scenario
459-
* Given a WP install in 'bar' with version "6.3.1"
423+
* Scenario: My version-specific scenario
424+
* Given a WP 6.4.2 installation in 'wordpress'
460425
* ...
461426
* ```
462427
*
463428
* @access public
464429
*
465-
* @Given a WP install(ation) in :subdir with version :version
430+
* @Given /^a WP( ([^\s]+))? install(?:ation)? in ['"]?([^'"]+)['"]?$/
466431
*
432+
* @param string $version_with_space Optional version with leading space
433+
* @param string $version Optional version number
467434
* @param string $subdir
468-
* @param string $version
469435
*/
470-
public function given_a_wp_installation_in_a_specific_folder_with_version( $subdir, $version ): void {
436+
public function given_a_wp_installation_in_a_specific_folder( $version_with_space = '', $version = '', $subdir = '' ): void {
471437
$this->install_wp( $subdir, $version );
472438
}
473439

0 commit comments

Comments
 (0)