Another attempt at properly setting the directory for code coverage

Assume that the folder that `composer behat` is run in will be the
project level folder in all situations, which avoids long chained
dirname calls that don't work with the wp-cli-dev environment.

Update itterator to use a call back filter as well, just to keep the
logic of what files we want all in a single place.

Author: mrsdizzie

src/Context/FeatureContext.php

@@ -38,6 +38,11 @@ class FeatureContext implements SnippetAcceptingContext {
 	 */
 	private static $run_dir;
 
+	/**
+	 * The Directory that 'composer behat' is run from, assumed to always be the top level project folder
+	 */
+	private static $behat_run_dir;
+
 	/**
 	 * Where WordPress core is downloaded to for caching, and which is copied to RUN_DIR during a "Given a WP installation" step. Lives until manually deleted.
 	 */
@@ -286,9 +291,10 @@ private static function get_process_env_variables() {
 
 		$path_separator = Utils\is_windows() ? ';' : ':';
 		$env            = [
-			'PATH'      => $bin_path . $path_separator . getenv( 'PATH' ),
-			'BEHAT_RUN' => 1,
-			'HOME'      => sys_get_temp_dir() . '/wp-cli-home',
+			'PATH'         => $bin_path . $path_separator . getenv( 'PATH' ),
+			'BEHAT_RUN'    => 1,
+			'HOME'         => sys_get_temp_dir() . '/wp-cli-home',
+			'TEST_RUN_DIR' => self::$behat_run_dir,
 		];
 
 		$config_path = getenv( 'WP_CLI_CONFIG_PATH' );
@@ -371,6 +377,7 @@ private static function get_behat_internal_variables() {
 			'FRAMEWORK_ROOT' => realpath( $framework_root ),
 			'SRC_DIR'        => realpath( dirname( dirname( __DIR__ ) ) ),
 			'PROJECT_DIR'    => realpath( dirname( dirname( dirname( dirname( dirname( __DIR__ ) ) ) ) ) ),
+			'TEST_RUN_DIR'   => self::$behat_run_dir,
 		];
 
 		return $variables;
@@ -475,6 +482,7 @@ public static function prepare( BeforeSuiteScope $scope ) {
 		if ( false !== self::$log_run_times ) {
 			self::log_run_times_before_suite( $scope );
 		}
+		self::$behat_run_dir = getcwd();
 
 		$result = Process::create( 'wp cli info', null, self::get_process_env_variables() )->run_check();
 		echo "{$result->stdout}\n";
@@ -521,7 +529,6 @@ public function beforeScenario( BeforeScenarioScope $scope ) {
 		if ( self::$log_run_times ) {
 			self::log_run_times_before_scenario( $scope );
 		}
-
 		$this->variables = array_merge(
 			$this->variables,
 			self::get_behat_internal_variables()
@@ -693,8 +700,24 @@ public function __construct() {
 	 */
 	public function get_command_with_coverage( $cmd ) {
 		$with_code_coverage = (string) getenv( 'WP_CLI_TEST_COVERAGE' );
+
 		if ( \in_array( $with_code_coverage, [ 'true', '1' ], true ) ) {
-			return preg_replace( '/(^wp )|( wp )|(\/wp )/', '$1$2$3--require={SRC_DIR}/utils/generate-coverage.php ', $cmd );
+
+			$modify_command = function ( $part ) {
+				if ( preg_match( '/(^wp )|( wp )|(\/wp )/', $part ) ) {
+					$part  = preg_replace( '/(^wp )|( wp )|(\/wp )/', '$1$2$3', $part );
+					$part .= ' --require={TEST_RUN_DIR}/vendor/wp-cli/wp-cli-tests/utils/generate-coverage.php';
+				}
+				return $part;
+			};
+
+			if ( strpos( $cmd, '|' ) !== false ) {
+				$parts = explode( '|', $cmd );
+				$parts = array_map( $modify_command, $parts );
+				$cmd   = implode( '|', $parts );
+			} else {
+				$cmd = $modify_command( $cmd );
+			}
 		}
 
 		return $cmd;

utils/generate-coverage.php

@@ -12,62 +12,47 @@
 use SebastianBergmann\CodeCoverage\Report\Clover;
 
 
-// The wp-cli-tests directory.
-$package_folder = realpath( dirname( __DIR__ ) );
-
-// If installed as a dependency in `<somedir>/vendor/wp-cli/wp-cli-tests, this is <somedir>.
-$project_dir = (string) getenv( 'BEHAT_PROJECT_DIR' );
-
-// If we're not in a Behat environment.
-if ( ! $project_dir ) {
-	$project_dir = realpath( dirname( dirname( dirname( dirname( __DIR__ ) ) ) ) );
-}
-
-if ( ! file_exists( $project_dir . '/vendor/autoload.php' ) ) {
-	$project_dir = $package_folder;
-}
+$project_dir = (string) getenv( 'TEST_RUN_DIR' );
 
 if ( ! class_exists( 'SebastianBergmann\CodeCoverage\Filter' ) ) {
 	if ( ! file_exists( $project_dir . '/vendor/autoload.php' ) ) {
 		die( 'Could not load dependencies for generating code coverage' );
 	}
-
 	require "{$project_dir}/vendor/autoload.php";
 }
 
-$files = [];
-
-$dir_to_search = null;
-
-// In wp-cli/wp-cli, all source code is in the "php" folder.
-// In commands, all source code is in the "src" folder.
-if ( is_dir( "{$project_dir}/php" ) ) {
-	$dir_to_search = "{$project_dir}/php";
-} elseif ( is_dir( "{$project_dir}/src" ) ) {
-	$dir_to_search = "{$project_dir}/src";
-}
+$filtered_items = new CallbackFilterIterator(
+	new DirectoryIterator( $project_dir ),
+	function ( $file ) {
+		// Allow directories named "php" or "src"
+		if ( $file->isDir() && in_array( $file->getFilename(), [ 'php', 'src' ], true ) ) {
+			return true;
+		}
 
-if ( $dir_to_search ) {
-	foreach (
-		new RecursiveIteratorIterator(
-			new RecursiveDirectoryIterator( $dir_to_search, RecursiveDirectoryIterator::SKIP_DOTS | RecursiveDirectoryIterator::FOLLOW_SYMLINKS )
-		)
-		as $file
-	) {
-		if ( $file->isFile() && 'php' === $file->getExtension() ) {
-			$files[] = $file->getPathname();
+		// Allow top-level files ending in "-command.php"
+		if ( $file->isFile() && false !== strpos( $file->getFilename(), '-command.php' ) ) {
+			return true;
 		}
+
+		return false;
 	}
-}
+);
+
+$files = [];
 
-// There is also a "*-command.php" file.
-foreach (
-	new IteratorIterator(
-		new DirectoryIterator( $project_dir )
-	) as $file ) {
-	if ( $file->isFile() && false !== strpos( $file->getFilename(), '-command.php' ) ) {
-		$files[] = $file->getPathname();
-		break;
+foreach ( $filtered_items as $item ) {
+	if ( $item->isDir() ) {
+		foreach (
+			new RecursiveIteratorIterator(
+				new RecursiveDirectoryIterator( $item->getPathname(), RecursiveDirectoryIterator::SKIP_DOTS )
+			) as $file
+		) {
+			if ( $file->isFile() && $file->getExtension() === 'php' ) {
+				$files[] = $file->getPathname();
+			}
+		}
+	} else {
+		$files[] = $item->getPathname();
 	}
 }