Skip to content

Commit 5625944

Browse files
committed
Revert quoting variable
It is actually wrong in this case since we store several options in there
1 parent 47ee4a5 commit 5625944

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

bin/install-package-tests

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -75,9 +75,9 @@ echo "DEBUG: CLIENT_VERSION is: '${CLIENT_VERSION}'"
7575
echo "DEBUG: TYPE is: '${TYPE}'"
7676

7777
if [ "${TYPE}" = "MySQL" ]; then
78-
SERVER_VERSION=$(mysql -e "SELECT VERSION()" --skip-column-names "${HOST_STRING}" -u"${USER}" "${PASSWORD_STRING}")
78+
SERVER_VERSION=$(mysql -e "SELECT VERSION()" --skip-column-names ${HOST_STRING} -u"${USER}" "${PASSWORD_STRING}")
7979
else
80-
SERVER_VERSION=$(mariadb -e "SELECT VERSION()" --skip-column-names "${HOST_STRING}" -u"${USER}" "${PASSWORD_STRING}")
80+
SERVER_VERSION=$(mariadb -e "SELECT VERSION()" --skip-column-names ${HOST_STRING} -u"${USER}" "${PASSWORD_STRING}")
8181
fi
8282

8383
VERSION=$(echo "${SERVER_VERSION}" | grep -o '^[^-]*')
@@ -89,7 +89,7 @@ echo "Detected ${TYPE} at version ${MAJOR}.${MINOR}"
8989
echo 'Checking if database is ready...'
9090

9191
if [ "${TYPE}" = "MySQL" ]; then
92-
while ! mysql "${HOST_STRING}" --user="${USER}" "${PASSWORD_STRING}" --execute="SHOW DATABASES;" | grep 'information_schema' >/dev/null;
92+
while ! mysql ${HOST_STRING} --user="${USER}" "${PASSWORD_STRING}" --execute="SHOW DATABASES;" | grep 'information_schema' >/dev/null;
9393
do
9494
echo 'Waiting for database...'
9595
sleep 5
@@ -100,7 +100,7 @@ if [ "${TYPE}" = "MySQL" ]; then
100100
fi
101101
done
102102
else
103-
while ! mariadb "${HOST_STRING}" --user="${USER}" "${PASSWORD_STRING}" --execute="SHOW DATABASES;" | grep 'information_schema' >/dev/null;
103+
while ! mariadb ${HOST_STRING} --user="${USER}" "${PASSWORD_STRING}" --execute="SHOW DATABASES;" | grep 'information_schema' >/dev/null;
104104
do
105105
echo 'Waiting for database...'
106106
sleep 5
@@ -115,27 +115,27 @@ fi
115115
# Prepare the database for running the tests with a MySQL version 8.0 or higher.
116116
install_mysql_db_8_0_plus() {
117117
set -ex
118-
mysql -e "CREATE DATABASE IF NOT EXISTS \`${TEST_DB}\`;" "${HOST_STRING}" -u"${USER}" "${PASSWORD_STRING}"
119-
mysql -e "CREATE USER IF NOT EXISTS \`${TEST_USER}\`@'%' IDENTIFIED WITH caching_sha2_password BY '${TEST_PASSWORD}'" "${HOST_STRING}" -u"${USER}" "${PASSWORD_STRING}"
120-
mysql -e "GRANT ALL PRIVILEGES ON \`${TEST_DB}\`.* TO '${TEST_USER}'@'%'" "${HOST_STRING}" -u"${USER}" "${PASSWORD_STRING}"
121-
mysql -e "GRANT ALL PRIVILEGES ON \`${TEST_DB}_scaffold\`.* TO '${TEST_USER}'@'%'" "${HOST_STRING}" -u"${USER}" "${PASSWORD_STRING}"
118+
mysql -e "CREATE DATABASE IF NOT EXISTS \`${TEST_DB}\`;" ${HOST_STRING} -u"${USER}" "${PASSWORD_STRING}"
119+
mysql -e "CREATE USER IF NOT EXISTS \`${TEST_USER}\`@'%' IDENTIFIED WITH caching_sha2_password BY '${TEST_PASSWORD}'" ${HOST_STRING} -u"${USER}" "${PASSWORD_STRING}"
120+
mysql -e "GRANT ALL PRIVILEGES ON \`${TEST_DB}\`.* TO '${TEST_USER}'@'%'" ${HOST_STRING} -u"${USER}" "${PASSWORD_STRING}"
121+
mysql -e "GRANT ALL PRIVILEGES ON \`${TEST_DB}_scaffold\`.* TO '${TEST_USER}'@'%'" ${HOST_STRING} -u"${USER}" "${PASSWORD_STRING}"
122122
}
123123

124124
# Prepare the database for running the tests with a MySQL version lower than 8.0.
125125
install_mysql_db_lower_than_8_0() {
126126
set -ex
127-
mysql -e "CREATE DATABASE IF NOT EXISTS \`${TEST_DB}\`;" "${HOST_STRING}" -u"${USER}" "${PASSWORD_STRING}"
128-
mysql -e "GRANT ALL ON \`${TEST_DB}\`.* TO '${TEST_USER}'@'%' IDENTIFIED BY '${TEST_PASSWORD}'" "${HOST_STRING}" -u"${USER}" "${PASSWORD_STRING}"
129-
mysql -e "GRANT ALL ON \`${TEST_DB}_scaffold\`.* TO '${TEST_USER}'@'%' IDENTIFIED BY '${TEST_PASSWORD}'" "${HOST_STRING}" -u"${USER}" "${PASSWORD_STRING}"
127+
mysql -e "CREATE DATABASE IF NOT EXISTS \`${TEST_DB}\`;" ${HOST_STRING} -u"${USER}" "${PASSWORD_STRING}"
128+
mysql -e "GRANT ALL ON \`${TEST_DB}\`.* TO '${TEST_USER}'@'%' IDENTIFIED BY '${TEST_PASSWORD}'" ${HOST_STRING} -u"${USER}" "${PASSWORD_STRING}"
129+
mysql -e "GRANT ALL ON \`${TEST_DB}_scaffold\`.* TO '${TEST_USER}'@'%' IDENTIFIED BY '${TEST_PASSWORD}'" ${HOST_STRING} -u"${USER}" "${PASSWORD_STRING}"
130130
}
131131

132132
# Prepare the database for running the tests with MariaDB
133133
install_mariadb() {
134134
set -ex
135-
mariadb -e "CREATE DATABASE IF NOT EXISTS \`${TEST_DB}\`;" "${HOST_STRING}" -u"${USER}" "${PASSWORD_STRING}"
136-
mariadb -e "CREATE USER IF NOT EXISTS \`${TEST_USER}\`@'%' IDENTIFIED WITH caching_sha2_password BY '${TEST_PASSWORD}'" "${HOST_STRING}" -u"${USER}" "${PASSWORD_STRING}"
137-
mariadb -e "GRANT ALL PRIVILEGES ON \`${TEST_DB}\`.* TO '${TEST_USER}'@'%'" "${HOST_STRING}" -u"${USER}" "${PASSWORD_STRING}"
138-
mariadb -e "GRANT ALL PRIVILEGES ON \`${TEST_DB}_scaffold\`.* TO '${TEST_USER}'@'%'" "${HOST_STRING}" -u"${USER}" "${PASSWORD_STRING}"
135+
mariadb -e "CREATE DATABASE IF NOT EXISTS \`${TEST_DB}\`;" ${HOST_STRING} -u"${USER}" "${PASSWORD_STRING}"
136+
mariadb -e "CREATE USER IF NOT EXISTS \`${TEST_USER}\`@'%' IDENTIFIED WITH caching_sha2_password BY '${TEST_PASSWORD}'" ${HOST_STRING} -u"${USER}" "${PASSWORD_STRING}"
137+
mariadb -e "GRANT ALL PRIVILEGES ON \`${TEST_DB}\`.* TO '${TEST_USER}'@'%'" ${HOST_STRING} -u"${USER}" "${PASSWORD_STRING}"
138+
mariadb -e "GRANT ALL PRIVILEGES ON \`${TEST_DB}_scaffold\`.* TO '${TEST_USER}'@'%'" ${HOST_STRING} -u"${USER}" "${PASSWORD_STRING}"
139139
}
140140

141141
if [ "${TYPE}" = "MariaDB" ]; then

0 commit comments

Comments
 (0)