DRY unit test

Author: swissspidy

tests/tests/TestBehatTags.php

@@ -35,6 +35,30 @@ protected function tear_down(): void {
 		parent::tear_down();
 	}
 
+	/**
+	 * Runs the behat-tags.php script in a cross-platform way.
+	 *
+	 * @param string $env Environment variable string to set (e.g., 'WP_VERSION=4.5').
+	 * @return string|false The output of the script.
+	 */
+	private function run_behat_tags_script( $env = '' ) {
+		$behat_tags = dirname( dirname( __DIR__ ) ) . '/utils/behat-tags.php';
+
+		if ( ! empty( $env ) ) {
+			putenv( $env );
+		}
+
+		$command = 'cd ' . escapeshellarg( $this->temp_dir ) . ' && php ' . escapeshellarg( $behat_tags );
+		$output  = exec( $command );
+
+		if ( ! empty( $env ) ) {
+			list( $key ) = explode( '=', $env, 2 );
+			putenv( $key ); // Unsets the variable.
+		}
+
+		return $output;
+	}
+
 	/**
 	 * @dataProvider data_behat_tags_wp_version_github_token
 	 *
@@ -50,19 +74,10 @@ public function test_behat_tags_wp_version_github_token( $env, $expected ): void
 		putenv( 'WP_VERSION' );
 		putenv( 'GITHUB_TOKEN' );
 
-		$behat_tags = dirname( dirname( __DIR__ ) ) . '/utils/behat-tags.php';
-
 		$contents = '@require-wp-4.6 @require-wp-4.8 @require-wp-4.9 @less-than-wp-4.6 @less-than-wp-4.8 @less-than-wp-4.9';
 		file_put_contents( $this->temp_dir . '/features/wp_version.feature', $contents );
 
-		if ( ! empty( $env ) ) {
-			putenv( $env );
-		}
-		$output = exec( 'cd ' . escapeshellarg( $this->temp_dir ) . ' && php ' . escapeshellarg( $behat_tags ) );
-		if ( ! empty( $env ) ) {
-			list( $key ) = explode( '=', $env, 2 );
-			putenv( $key );
-		}
+		$output = $this->run_behat_tags_script( $env );
 
 		$expected .= '&&~@broken';
 		if ( in_array( $env, array( 'WP_VERSION=trunk', 'WP_VERSION=nightly' ), true ) ) {
@@ -116,8 +131,6 @@ public function test_behat_tags_php_version(): void {
 
 		putenv( 'GITHUB_TOKEN' );
 
-		$behat_tags = dirname( dirname( __DIR__ ) ) . '/utils/behat-tags.php';
-
 		$php_version = substr( PHP_VERSION, 0, 3 );
 		$contents    = '';
 		$expected    = '';
@@ -172,7 +185,7 @@ public function test_behat_tags_php_version(): void {
 
 		file_put_contents( $this->temp_dir . '/features/php_version.feature', $contents );
 
-		$output = exec( "cd {$this->temp_dir}; php $behat_tags" );
+		$output = $this->run_behat_tags_script();
 		$this->assertSame( '--tags=' . $expected, $output );
 
 		putenv( false === $env_github_token ? 'GITHUB_TOKEN' : "GITHUB_TOKEN=$env_github_token" );
@@ -184,8 +197,6 @@ public function test_behat_tags_extension(): void {
 
 		putenv( 'GITHUB_TOKEN' );
 
-		$behat_tags = dirname( dirname( __DIR__ ) ) . '/utils/behat-tags.php';
-
 		file_put_contents( $this->temp_dir . '/features/extension.feature', '@require-extension-imagick @require-extension-curl' );
 
 		$expecteds = array();
@@ -215,7 +226,7 @@ public function test_behat_tags_extension(): void {
 		}
 
 		$expected = '--tags=' . implode( '&&', array_merge( array( '~@github-api', '~@broken' ), $expecteds ) );
-		$output   = exec( "cd {$this->temp_dir}; php $behat_tags" );
+		$output   = $this->run_behat_tags_script();
 		$this->assertSame( $expected, $output );
 
 		putenv( false === $env_github_token ? 'GITHUB_TOKEN' : "GITHUB_TOKEN=$env_github_token" );
@@ -264,7 +275,7 @@ public function test_behat_tags_db_version(): void {
 		file_put_contents( $this->temp_dir . '/features/extension.feature', $contents );
 
 		$expected = '--tags=' . implode( '&&', array_merge( array( '~@github-api', '~@broken' ), $expecteds ) );
-		$output   = exec( "cd {$this->temp_dir}; php $behat_tags" );
+		$output   = $this->run_behat_tags_script();
 		$this->assertSame( $expected, $output );
 	}
 }