Skip to content

Commit c6fde56

Browse files
authored
Merge pull request #260 from wp-cli/fix/252-polyfills
2 parents 003d38e + c7995a3 commit c6fde56

File tree

4 files changed

+17
-20
lines changed

4 files changed

+17
-20
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,5 @@ phpunit.xml
1212
phpcs.xml
1313
.phpcs.xml
1414
.phpunit.result.cache
15+
.phpunit.cache
1516
build/logs

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"wp-cli/eval-command": "^1 || ^2",
2424
"wp-cli/wp-cli": "^2.12",
2525
"wp-coding-standards/wpcs": "^3",
26-
"yoast/phpunit-polyfills": "^1.0.3 || ^2.0.1"
26+
"yoast/phpunit-polyfills": "^4.0.0"
2727
},
2828
"require-dev": {
2929
"roave/security-advisories": "dev-latest"

phpunit.xml.dist

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
1+
<?xml version="1.0" ?>
12
<phpunit
23
bootstrap="tests/bootstrap.php"
34
colors="true"
45
convertErrorsToExceptions="true"
56
convertWarningsToExceptions="true"
67
convertNoticesToExceptions="true"
78
convertDeprecationsToExceptions="true"
9+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10+
xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/8.5/phpunit.xsd"
811
>
912
<testsuites>
1013
<testsuite name="default">

tests/tests/TestBehatTags.php

Lines changed: 12 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
use WP_CLI\Tests\TestCase;
44
use WP_CLI\Utils;
5+
use PHPUnit\Framework\Attributes\DataProvider;
56

67
class TestBehatTags extends TestCase {
78

@@ -37,6 +38,7 @@ protected function tear_down(): void {
3738
* @param string $env
3839
* @param string $expected
3940
*/
41+
#[DataProvider( 'data_behat_tags_wp_version_github_token' )] // phpcs:ignore PHPCompatibility.Attributes.NewAttributes.PHPUnitAttributeFound
4042
public function test_behat_tags_wp_version_github_token( $env, $expected ): void {
4143
$env_wp_version = getenv( 'WP_VERSION' );
4244
$env_github_token = getenv( 'GITHUB_TOKEN' );
@@ -110,25 +112,7 @@ public function test_behat_tags_php_version(): void {
110112
$contents = '';
111113
$expected = '';
112114

113-
if ( '5.3' === $php_version ) {
114-
$contents = '@require-php-5.2 @require-php-5.3 @require-php-5.4 @less-than-php-5.2 @less-than-php-5.3 @less-than-php-5.4';
115-
116-
} elseif ( '5.4' === $php_version ) {
117-
$contents = '@require-php-5.3 @require-php-5.4 @require-php-5.5 @less-than-php-5.3 @less-than-php-5.4 @less-than-php-5.5';
118-
119-
} elseif ( '5.5' === $php_version ) {
120-
$contents = '@require-php-5.4 @require-php-5.5 @require-php-5.6 @less-than-php-5.4 @less-than-php-5.5 @less-than-php-5.6';
121-
122-
} elseif ( '5.6' === $php_version ) {
123-
$contents = '@require-php-5.5 @require-php-5.6 @require-php-7.0 @less-than-php-5.5 @less-than-php-5.6 @less-than-php-7.0';
124-
125-
} elseif ( '7.0' === $php_version ) {
126-
$contents = '@require-php-5.6 @require-php-7.0 @require-php-7.1 @less-than-php-5.6 @less-than-php-7.0 @less-than-php-7.1';
127-
128-
} elseif ( '7.1' === $php_version ) {
129-
$contents = '@require-php-7.0 @require-php-7.1 @require-php-7.2 @less-than-php-7.0 @less-than-php-7.1 @less-than-php-7.2';
130-
131-
} elseif ( '7.2' === $php_version ) {
115+
if ( '7.2' === $php_version ) {
132116
$contents = '@require-php-7.1 @require-php-7.2 @require-php-7.3 @less-than-php-7.1 @less-than-php-7.2 @less-than-php-7.3';
133117
134118
} elseif ( '7.3' === $php_version ) {
@@ -143,6 +127,15 @@ public function test_behat_tags_php_version(): void {
143127
} elseif ( '8.1' === $php_version ) {
144128
$contents = '@require-php-8.0 @require-php-8.1 @require-php-8.2 @less-than-php-8.0 @less-than-php-8.1 @less-than-php-8.2';
145129
130+
} elseif ( '8.2' === $php_version ) {
131+
$contents = '@require-php-8.0 @require-php-8.1 @require-php-8.2 @require-php-8.3 @less-than-php-8.0 @less-than-php-8.1 @less-than-php-8.2 @less-than-php-8.3 @less-than-php-8.4';
132+
133+
} elseif ( '8.3' === $php_version ) {
134+
$contents = '@require-php-8.1 @require-php-8.2 @require-php-8.3 @require-php-8.4 @less-than-php-8.0 @less-than-php-8.1 @less-than-php-8.2 @less-than-php-8.3 @less-than-php-8.4';
135+
136+
} elseif ( '8.4' === $php_version ) {
137+
$contents = '@require-php-8.2 @require-php-8.3 @require-php-8.4 @require-php-8.5 @less-than-php-8.0 @less-than-php-8.1 @less-than-php-8.2 @less-than-php-8.3 @less-than-php-8.4 @less-than-php-8.5';
138+
146139
} else {
147140
$this->markTestSkipped( "No test for PHP_VERSION $php_version." );
148141
}

0 commit comments

Comments
 (0)