AI fixes

Author: swissspidy

src/Context/FeatureContext.php

@@ -405,26 +405,12 @@ public static function get_bin_path(): ?string {
 			self::get_framework_dir() . DIRECTORY_SEPARATOR . 'bin',
 		];
 
-		if ( Utils\is_windows() ) {
-			foreach ( $bin_paths as $path ) {
-				$wp_script_path = $path . DIRECTORY_SEPARATOR . 'wp';
-				if ( is_file( $wp_script_path ) ) {
-					$wp_bat_path = $path . DIRECTORY_SEPARATOR . 'wp.bat';
-					if ( ! is_file( $wp_bat_path ) ) {
-						$bat_content = '@ECHO OFF' . PHP_EOL;
-						// Use the currently running PHP executable to avoid PATH issues.
-						$bat_content .= '"' . PHP_BINARY . '" "' . realpath( $wp_script_path ) . '" %*';
-						file_put_contents( $wp_bat_path, $bat_content );
-					}
-					return $path;
-				}
-			}
-		} else {
-			foreach ( $bin_paths as $path ) {
-				$full_bin_path = $path . DIRECTORY_SEPARATOR . 'wp';
-				if ( is_file( $full_bin_path ) && is_executable( $full_bin_path ) ) {
-					return $path;
-				}
+		$bin = Utils\is_windows() ? 'wp.bat' : 'wp';
+
+		foreach ( $bin_paths as $path ) {
+			$full_bin_path = $path . DIRECTORY_SEPARATOR . $bin;
+			if ( is_file( $full_bin_path ) && ( Utils\is_windows() || is_executable( $full_bin_path ) ) ) {
+				return $path;
 			}
 		}
 
@@ -684,6 +670,10 @@ public static function prepare( BeforeSuiteScope $scope ): void {
 		if ( file_exists( $install_cache_dir ) ) {
 			self::remove_dir( $install_cache_dir );
 		}
+
+		if ( getenv( 'WP_CLI_TEST_DEBUG_BEHAT_ENV' ) ) {
+			exit;
+		}
 	}
 
 	/**
@@ -1847,9 +1837,6 @@ private static function log_proc_method_run_time( $key, $start_time ): void {
  * @param string $message
  */
 function wp_cli_behat_env_debug( $message ): void { // phpcs:ignore Universal.Files.SeparateFunctionsFromOO.Mixed
-	// Always print the message to STDERR for debugging purposes.
-	fwrite( STDERR, "{$message}\n" );
-
 	if ( ! getenv( 'WP_CLI_TEST_DEBUG_BEHAT_ENV' ) ) {
 		return;
 	}

src/Context/Process.php

@@ -82,7 +82,7 @@ public function run() {
 				1 => [ 'file', $stdout_file, 'a' ],
 				2 => [ 'file', $stderr_file, 'a' ],
 			];
-			$proc  = \WP_CLI\Utils\proc_open_compat( $this->command, $descriptors, $pipes, $this->cwd, $this->env );
+			$proc        = \WP_CLI\Utils\proc_open_compat( $this->command, $descriptors, $pipes, $this->cwd, $this->env );
 			fclose( $pipes[0] );
 		} else {
 			$proc   = \WP_CLI\Utils\proc_open_compat( $this->command, self::$descriptors, $pipes, $this->cwd, $this->env );

tests/tests/TestBehatTags.php

@@ -225,10 +225,13 @@ public function test_behat_tags_extension(): void {
 				break;
 		}
 
-		if ( ! extension_loaded( 'imagick' ) ) {
+		// Check which extensions are loaded in the clean `php -n` environment to build the correct expectation.
+		$imagick_loaded_in_script = (bool) exec( escapeshellarg( PHP_BINARY ) . ' -n -r "echo (int)extension_loaded(\'imagick\');"' );
+		if ( ! $imagick_loaded_in_script ) {
 			$expecteds[] = '~@require-extension-imagick';
 		}
-		if ( ! extension_loaded( 'curl' ) ) {
+		$curl_loaded_in_script = (bool) exec( escapeshellarg( PHP_BINARY ) . ' -n -r "echo (int)extension_loaded(\'curl\');"' );
+		if ( ! $curl_loaded_in_script ) {
 			$expecteds[] = '~@require-extension-curl';
 		}