Fix return code comparisons

schlessera · schlessera · commit f75bae4bcd09 · 2019-04-19T17:10:54.000+02:00
diff --git a/features/steps/then.php b/features/steps/then.php
@@ -7,7 +7,10 @@
 $steps->Then(
 	'/^the return code should( not)? be (\d+)$/',
 	function ( $world, $not, $return_code ) {
-		if ( ( ! $not && $return_code !== $world->result->return_code ) || ( $not && $return_code === $world->result->return_code ) ) {
+		if (
+			( ! $not && (int) $return_code !== $world->result->return_code )
+			|| ( $not && (int) $return_code === $world->result->return_code )
+		) {
 			throw new RuntimeException( $world->result );
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,10 @@`
`7`	`7`	`$steps->Then(`
`8`	`8`	`'/^the return code should( not)? be (\d+)$/',`
`9`	`9`	`function ( $world, $not, $return_code ) {`
`10`		`- if ( ( ! $not && $return_code !== $world->result->return_code ) \|\| ( $not && $return_code === $world->result->return_code ) ) {`
	`10`	`+ if (`
	`11`	`+ ( ! $not && (int) $return_code !== $world->result->return_code )`
	`12`	`+ \|\| ( $not && (int) $return_code === $world->result->return_code )`
	`13`	`+ ) {`
`11`	`14`	`throw new RuntimeException( $world->result );`
`12`	`15`	`}`
`13`	`16`	`}`