-
Notifications
You must be signed in to change notification settings - Fork 26
Closed
Labels
Description
The change in #246 fixes the issue of allowing different client binary names.
However, I now realized that we're still using a faulty approach to even try to detect MySQL vs MariaDB to begin with. In the script, where we try to deduce the type, we're actually querying the version of the mysql client binary, not of the DB version. The type of the client is not really relevant here, all we are interested in is what dialect of SQL the server will need.
The script needs to split this into different phases:
- Detect what client binary can be used
- Use said client binary to connect to the server and retrieve the server version
- From the server version, extract the DB server type, i.e.
MySQLorMariaDB
Copilot